Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior

2024-04-22 Thread Andreas Rheinhardt
Stefano Sabatini: > On date Saturday 2024-04-20 18:47:58 +0200, Andreas Rheinhardt wrote: >> Stefano Sabatini: > [...] 1. This does not match mkvextract behaviour. mkvextract does not force a 1ms timebase. >>> >>> From your past comment: The accuracy of the timestamps output by

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior

2024-04-22 Thread Stefano Sabatini
On date Saturday 2024-04-20 18:47:58 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: [...] > >> 1. This does not match mkvextract behaviour. mkvextract does not force a > >> 1ms timebase. > > > > From your past comment: > >> The accuracy of the timestamps output by mkvextract is determined

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior

2024-04-20 Thread Stefano Sabatini
On date Saturday 2024-04-20 18:47:58 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > On date Saturday 2024-04-20 15:18:39 +0200, Andreas Rheinhardt wrote: > >> Stefano Sabatini: > >>> Harmonize internal implementation with the mkvextract behavior: > >>> - print PTS in place of DTS values

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior

2024-04-20 Thread Andreas Rheinhardt
Stefano Sabatini: > On date Saturday 2024-04-20 15:18:39 +0200, Andreas Rheinhardt wrote: >> Stefano Sabatini: >>> Harmonize internal implementation with the mkvextract behavior: >>> - print PTS in place of DTS values >>> - ignore NOPTS values >>> - sort PTS values >>> --- >>>

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior

2024-04-20 Thread Stefano Sabatini
On date Saturday 2024-04-20 15:18:39 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > Harmonize internal implementation with the mkvextract behavior: > > - print PTS in place of DTS values > > - ignore NOPTS values > > - sort PTS values > > --- > > libavformat/mkvtimestamp_v2.c | 69

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior

2024-04-20 Thread Andreas Rheinhardt
Stefano Sabatini: > Harmonize internal implementation with the mkvextract behavior: > - print PTS in place of DTS values > - ignore NOPTS values > - sort PTS values > --- > libavformat/mkvtimestamp_v2.c | 69 +-- > 1 file changed, 65 insertions(+), 4 deletions(-) >

[FFmpeg-devel] [PATCH 2/3] lavf/mkvtimestamp_v2: review implementation to match mkvextract behavior

2024-04-20 Thread Stefano Sabatini
Harmonize internal implementation with the mkvextract behavior: - print PTS in place of DTS values - ignore NOPTS values - sort PTS values --- libavformat/mkvtimestamp_v2.c | 69 +-- 1 file changed, 65 insertions(+), 4 deletions(-) diff --git