Re: [FFmpeg-devel] [PATCH 2/4] avisynth: drop support of AviSynth 2.5
On Tue, Mar 24, 2015 at 03:23:30PM -0400, Stephen Hutchinson wrote: If the user attempts to use AviSynth 2.5, an error message will now tell them they need to upgrade. --- compat/avisynth/avisynth_c_25.h | 68 - libavformat/avisynth.c | 23 +- 2 files changed, 15 insertions(+), 76 deletions(-) delete mode 100644 compat/avisynth/avisynth_c_25.h applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/4] avisynth: drop support of AviSynth 2.5
On Tue, Mar 24, 2015 at 3:33 PM, Hendrik Leppkes h.lepp...@gmail.com wrote: On Tue, Mar 24, 2015 at 8:23 PM, Stephen Hutchinson qyo...@gmail.com wrote: If the user attempts to use AviSynth 2.5, an error message will now tell them they need to upgrade. Whats the advantage in dropping support? Earlier versions seemed to work just fine against both 2.5 and 2.6. If we want to make sure that we supply official and up-to-date headers, then 2.5 support becomes harder to maintain. The only reason it currently supports 2.5* is the avisynth_c_25.h compat header, which would have to be expanded with additional *_25 versions of functions and cause more branching in the demuxer to continue supporting it. *more precisely, supports video under 2.5, because the changes requiring the compat header were to video-related functions. Also, the compat header was sourced from FFMS2's C plugin. Now, since said header was originally committed to FFMS2 by the same author that contributed C header work to earlier alphas of AviSynth 2.6, I trust that the compat header is ISC licensed rather than GPLv2 with linking exception was done without violating the GPL. But adding more functions to that header would be a lot trickier, and ditching the compat header would resolve any what-ifs about that situation (I'd rather even remove the 2.5 compat mode from FFMS2's C plugin too, for that matter). And while it doesn't pertain directly to the libavformat demuxer, users should be strongly encouraged to upgrade to either 2.6 or better, AviSynth+, since those versions are more stable than 2.5. One of the main problems was that users were scared off by classic AviSynth's 'alpha' tag on the 2.6 releases, even though the actual dev(s) stated the 'alpha' only referred to 2.6-specific features. But with 2.6 RC1 having been out now for a little over three months, the alpha argument can't hold sway anymore (and AviSynth+ deliberately uses a different versioning scheme to avoid this, and has since its inception in late 2013). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/4] avisynth: drop support of AviSynth 2.5
On Tue, Mar 24, 2015 at 4:35 PM, John Warburton j...@johnwarburton.net wrote: Just had avisynth.c fail to compile from a clean tree, whereas yesterday's compile was fine. Complete error report is below. I'm certainly not a code expert but is avisynth.c not finding what it would like to refer to in avisynth_c.h? The errors are being caused by a commit this morning merging a fix from Libav that allowed libavformat to use the updated headers (which changed several functions from AVSC_INLINE to AVSC_API). FFmpeg currently uses an older version of the header that still declares them as AVSC_INLINE, and thus compilation fails. The first commit in this patchset addresses that particular problem. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/4] avisynth: drop support of AviSynth 2.5
On Tue, Mar 24, 2015 at 8:23 PM, Stephen Hutchinson qyo...@gmail.com wrote: If the user attempts to use AviSynth 2.5, an error message will now tell them they need to upgrade. Whats the advantage in dropping support? Earlier versions seemed to work just fine against both 2.5 and 2.6. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/4] avisynth: drop support of AviSynth 2.5
On Tue, Mar 24, 2015 at 7:33 PM, Hendrik Leppkes h.lepp...@gmail.com wrote:
On Tue, Mar 24, 2015 at 8:23 PM, Stephen Hutchinson qyo...@gmail.com wrote:
If the user attempts to use AviSynth 2.5, an error message will
now tell them they need to upgrade.
Just had avisynth.c fail to compile from a clean tree, whereas
yesterday's compile was fine.
Complete error report is below. I'm certainly not a code expert but is
avisynth.c not finding what it would like to refer to in avisynth_c.h?
CC libavformat/avisynth.o
In file included from libavformat/avisynth.c:33:0:
./compat/avisynth/avisynth_c.h:806:27: warning: function declaration
isn't a prototype [-Wstrict-prototypes]
AVSC_INLINE AVS_Library * avs_load_library() {
^
libavformat/avisynth.c:69:23: error: unknown type name 'avs_bits_per_pixel_func'
AVSC_DECLARE_FUNC(avs_bits_per_pixel);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c:70:23: error: unknown type name 'avs_get_height_p_func'
AVSC_DECLARE_FUNC(avs_get_height_p);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c:71:23: error: unknown type name 'avs_get_pitch_p_func'
AVSC_DECLARE_FUNC(avs_get_pitch_p);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c:72:23: error: unknown type name 'avs_get_read_ptr_p_func'
AVSC_DECLARE_FUNC(avs_get_read_ptr_p);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c:73:23: error: unknown type name 'avs_get_row_size_p_func'
AVSC_DECLARE_FUNC(avs_get_row_size_p);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c:74:23: error: unknown type name 'avs_is_yv24_func'
AVSC_DECLARE_FUNC(avs_is_yv24);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c:75:23: error: unknown type name 'avs_is_yv16_func'
AVSC_DECLARE_FUNC(avs_is_yv16);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c:76:23: error: unknown type name 'avs_is_yv411_func'
AVSC_DECLARE_FUNC(avs_is_yv411);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
libavformat/avisynth.c:77:23: error: unknown type name 'avs_is_y8_func'
AVSC_DECLARE_FUNC(avs_is_y8);
^
libavformat/avisynth.c:53:33: note: in definition of macro 'AVSC_DECLARE_FUNC'
#define AVSC_DECLARE_FUNC(name) name ## _func name
^
libavformat/avisynth.c: In function 'avisynth_load_library':
libavformat/avisynth.c:123:26: warning: assignment makes integer from
pointer without a cast
avs_library.name = \
^
libavformat/avisynth.c:143:5: note: in expansion of macro 'LOAD_AVS_FUNC'
LOAD_AVS_FUNC(avs_bits_per_pixel, 0);
^
libavformat/avisynth.c:123:26: warning: assignment makes integer from
pointer without a cast
avs_library.name = \
^
libavformat/avisynth.c:144:5: note: in expansion of macro 'LOAD_AVS_FUNC'
LOAD_AVS_FUNC(avs_get_height_p, 0);
^
libavformat/avisynth.c:123:26: warning: assignment makes integer from
pointer without a cast
avs_library.name = \
^
libavformat/avisynth.c:145:5: note: in expansion of macro 'LOAD_AVS_FUNC'
LOAD_AVS_FUNC(avs_get_pitch_p, 0);
^
libavformat/avisynth.c:123:26: warning: assignment makes integer from
pointer without a cast
avs_library.name = \
^
libavformat/avisynth.c:146:5: note: in expansion of macro 'LOAD_AVS_FUNC'
LOAD_AVS_FUNC(avs_get_read_ptr_p, 0);
^
libavformat/avisynth.c:123:26: warning: assignment makes integer from
pointer without a cast
avs_library.name = \
^
