Re: [FFmpeg-devel] [PATCH 2/4] png: Clearly separate encoding header and frames

2015-03-31 Thread wm4
On Tue, 31 Mar 2015 20:01:45 +0200 Michael Niedermayer wrote: > On Tue, Mar 31, 2015 at 12:37:23PM +, Donny Yang wrote: > > Signed-off-by: Donny Yang > [...] > > > +ret = encode_headers(avctx, pict); > > +if (ret) > > +return ret; > > + > > +ret = encode_frame(avctx, pic

Re: [FFmpeg-devel] [PATCH 2/4] png: Clearly separate encoding header and frames

2015-03-31 Thread Michael Niedermayer
On Tue, Mar 31, 2015 at 12:37:23PM +, Donny Yang wrote: > Signed-off-by: Donny Yang [...] > +ret = encode_headers(avctx, pict); > +if (ret) > +return ret; > + > +ret = encode_frame(avctx, pict); > +if (ret) > +return ret; error checks are "< 0" in ffmpeg unles

[FFmpeg-devel] [PATCH 2/4] png: Clearly separate encoding header and frames

2015-03-31 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngenc.c | 142 +++- 1 file changed, 84 insertions(+), 58 deletions(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index ca0ed25..e7c343b 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c