Re: [FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

Thanks for looking at it. On Wed, Aug 24, 2016 at 1:06 PM, Carl Eugen Hoyos wrote: > Hi! > > 2016-08-24 16:38 GMT+02:00 Burt P. : >> On Tue, Aug 23, 2016 at 2:29 PM, Carl Eugen Hoyos wrote: >>> It seems safer to me to use the actual

Re: [FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

Hi! 2016-08-24 16:38 GMT+02:00 Burt P. : > On Tue, Aug 23, 2016 at 2:29 PM, Carl Eugen Hoyos wrote: >> It seems safer to me to use the actual number of channels than the >> channel layout. > > Alright, new patch version incoming. No more comments from me.

Re: [FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

On Tue, Aug 23, 2016 at 2:29 PM, Carl Eugen Hoyos wrote: > It seems safer to me to use the actual number of channels than the > channel layout. Alright, new patch version incoming. -- Burt ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

Hi! 2016-08-23 1:01 GMT+02:00 Burt P : > +int channel_count = > av_get_channel_layout_nb_channels(inlink->channel_layout); It seems safer to me to use the actual number of channels than the channel layout. (Or to say it differently: It is most likely a bug that FFmpeg

[FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

Mostly just re-arranges some code to make it easier to update this filter and libhdcd together. filter_frame() is much simpler as a result. * use the HDCD detection data structure and functions from libhdcd * moved detection code out of filter_frame() * moved analyze_mode preparation out of