Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-22 Thread Derek Buitenhuis
On 11/22/2017 1:33 PM, Kevin Wheatley wrote: > The guess work comes from this list: > > https://developer.apple.com/library/content/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG10-SAMPLE__COLR__SETTINGS It's a mistake to conflate resolutions with the standards listed

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-22 Thread Kevin Wheatley
The guess work comes from this list: https://developer.apple.com/library/content/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG10-SAMPLE__COLR__SETTINGS and I agree is the source of a lot of chaos, but it is what several tools have done in the absence of any specified

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Derek Buitenhuis
On 11/20/2017 4:45 PM, Dave Rice wrote: > What do you propose as the default for guessed_hacky_crap? Also are there > supporters for the need of a guessed_hacky_crap optio? Is there precedence in > ffmpeg to enable/disable guesswork via a user option? I personally would never use the guesswork

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Dave Rice
> On Nov 20, 2017, at 11:22 AM, Derek Buitenhuis > wrote: > > On 11/20/2017 3:19 PM, Dave Rice wrote: >> TN2162 requires a colr atom for uncompressed yuv (including v210, v308, >> v408, etc) in mov, so I'd prefer to write it in this case. Note that the >> colr

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Derek Buitenhuis
On 11/20/2017 3:19 PM, Dave Rice wrote: > TN2162 requires a colr atom for uncompressed yuv (including v210, v308, v408, > etc) in mov, so I'd prefer to write it in this case. Note that the colr atom > provides an option for unspecified for each of the color values, so there's a > method to

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Dave Rice
> On Nov 20, 2017, at 9:55 AM, Derek Buitenhuis > wrote: > > On 11/20/2017 2:50 PM, Dave Rice wrote: >> I am hesitant to see write_colr option removed since the guesswork used here >>

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Derek Buitenhuis
On 11/20/2017 2:50 PM, Dave Rice wrote: > I am hesitant to see write_colr option removed since the guesswork used here > https://github.com/FFmpeg/FFmpeg/blob/8f4702a93f87f9f76563e80f1ae2141a40029d9d/libavformat/movenc.c#L1747-L1775 > would then be applied to all movs of standard HD and SD size

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Dave Rice
> On Nov 20, 2017, at 9:01 AM, Carl Eugen Hoyos wrote: > > 2017-11-20 2:24 GMT+01:00 James Almer >: >> On 11/18/2017 11:19 PM, Dave Rice wrote: >>> From 41da5e48f8788b85dd7a382030bb2866c506cc03 Mon Sep 17 00:00:00 2001 >>>

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Carl Eugen Hoyos
2017-11-20 2:24 GMT+01:00 James Almer : > On 11/18/2017 11:19 PM, Dave Rice wrote: >> From 41da5e48f8788b85dd7a382030bb2866c506cc03 Mon Sep 17 00:00:00 2001 >> From: Dave Rice >> Date: Sat, 18 Nov 2017 20:31:27 -0500 >> Subject: [PATCH 3/4] avformat/movenc:

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-19 Thread Michael Niedermayer
On Sun, Nov 19, 2017 at 10:24:41PM -0300, James Almer wrote: > On 11/18/2017 11:19 PM, Dave Rice wrote: > > From 41da5e48f8788b85dd7a382030bb2866c506cc03 Mon Sep 17 00:00:00 2001 > > From: Dave Rice > > Date: Sat, 18 Nov 2017 20:31:27 -0500 > > Subject: [PATCH 3/4]

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-19 Thread James Almer
On 11/18/2017 11:19 PM, Dave Rice wrote: > From 41da5e48f8788b85dd7a382030bb2866c506cc03 Mon Sep 17 00:00:00 2001 > From: Dave Rice > Date: Sat, 18 Nov 2017 20:31:27 -0500 > Subject: [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in > mov > MIME-Version: 1.0

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-19 Thread Michael Niedermayer
On Sun, Nov 19, 2017 at 10:05:56AM +0100, Reto Kromer wrote: > Dave Rice wrote: > > >As required by Apple’s TN2162. > >--- > > libavformat/movenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM will apply thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-19 Thread Reto Kromer
Dave Rice wrote: >As required by Apple’s TN2162. >--- > libavformat/movenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-18 Thread Dave Rice
From 41da5e48f8788b85dd7a382030bb2866c506cc03 Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Sat, 18 Nov 2017 20:31:27 -0500 Subject: [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8