Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Hello Matthias, Thanks for the feedback. Comments inline: > On Jan 2, 2018, at 4:52 AM, Matthias Hunstock wrote: > > Am 29.12.2017 um 19:12 schrieb Devin Heitmueller: >> To support the existing use case where multi-channel audio can be >> captured (i.e. 7.1) > > Just

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

>> +if (ctx->max_audio_channels > DECKLINK_MAX_AUDIO_CHANNELS) { >> +av_log(avctx, AV_LOG_WARNING, "Decklink card reported support for >> more channels than ffmpeg supports\n"); > > "Decklink" -> "DeckLink", "ffmpeg" -> "FFmpeg". Also, I think it is > preferable to not state

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Am 29.12.2017 um 19:12 schrieb Devin Heitmueller: > To support the existing use case where multi-channel audio can be > captured (i.e. 7.1) Just to be clear, the current use case is NOT to capture multi-channel audio like 7.1. It's just to capture all of the mono SDI channels into one

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

On 12/29/2017 10:12 AM, Devin Heitmueller wrote: Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

> On Dec 29, 2017, at 4:17 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 22:14 GMT+01:00 Devin Heitmueller : >> Hi Carl, >> >>> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote: >>> >>> 2017-12-29 19:12 GMT+01:00 Devin

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 22:14 GMT+01:00 Devin Heitmueller : > Hi Carl, > >> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote: >> >> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : >> >>> +for (int i = 0; i <

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Hi Carl, > On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > >> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) { >> +st = avformat_new_stream(avctx, NULL); >> +

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 19:12 GMT+01:00 Devin Heitmueller : > +for (int i = 0; i < ctx->max_audio_channels / 2; i++) { > +st = avformat_new_stream(avctx, NULL); > +if (!st) { > +av_log(avctx, AV_LOG_ERROR, "Cannot add stream %d\n",

[FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo pair per audio language). To support the existing