Hello Matthias,
Thanks for the feedback. Comments inline:
> On Jan 2, 2018, at 4:52 AM, Matthias Hunstock wrote:
>
> Am 29.12.2017 um 19:12 schrieb Devin Heitmueller:
>> To support the existing use case where multi-channel audio can be
>> captured (i.e. 7.1)
>
> Just to be clear, the current
>> +if (ctx->max_audio_channels > DECKLINK_MAX_AUDIO_CHANNELS) {
>> +av_log(avctx, AV_LOG_WARNING, "Decklink card reported support for
>> more channels than ffmpeg supports\n");
>
> "Decklink" -> "DeckLink", "ffmpeg" -> "FFmpeg". Also, I think it is
> preferable to not state "FFmpe
Am 29.12.2017 um 19:12 schrieb Devin Heitmueller:
> To support the existing use case where multi-channel audio can be
> captured (i.e. 7.1)
Just to be clear, the current use case is NOT to capture multi-channel
audio like 7.1. It's just to capture all of the mono SDI channels into
one FFmpeg-inter
On 12/29/2017 10:12 AM, Devin Heitmueller wrote:
Add support for the ability to capture all audio pairs available
to the capture hardware. Each pair is exposed as a different audio
stream, which matches up with the most common use cases for the
broadcast space (i.e. where there is one stereo pai
> On Dec 29, 2017, at 4:17 PM, Carl Eugen Hoyos wrote:
>
> 2017-12-29 22:14 GMT+01:00 Devin Heitmueller :
>> Hi Carl,
>>
>>> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote:
>>>
>>> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller :
>>>
+for (int i = 0; i < ctx->max_audio_channe
2017-12-29 22:14 GMT+01:00 Devin Heitmueller :
> Hi Carl,
>
>> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote:
>>
>> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller :
>>
>>> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) {
>>> +st = avformat_new_stream(avctx, NULL);
>
Hi Carl,
> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos wrote:
>
> 2017-12-29 19:12 GMT+01:00 Devin Heitmueller :
>
>> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) {
>> +st = avformat_new_stream(avctx, NULL);
>> +if (!st) {
>> +av_log(a
2017-12-29 19:12 GMT+01:00 Devin Heitmueller :
> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) {
> +st = avformat_new_stream(avctx, NULL);
> +if (!st) {
> +av_log(avctx, AV_LOG_ERROR, "Cannot add stream %d\n", i);
> +ret = AV
Add support for the ability to capture all audio pairs available
to the capture hardware. Each pair is exposed as a different audio
stream, which matches up with the most common use cases for the
broadcast space (i.e. where there is one stereo pair per audio
language).
To support the existing use
