Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-25 Thread Lukasz Marek
On 24.10.2014 00:18, Reynaldo H. Verdejo Pinochet wrote: Hi Lukasz +static int ffserver_apply_stream_config(AVCodecContext *enc, const AVDictionary *conf, AVDictionary **opts) +{ +static const char *error_message = Cannot parse '%s' as number for %s parameter.\n; +AVDictionaryEntry

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-23 Thread Reynaldo H. Verdejo Pinochet
Hi Lukasz On 10/22/2014 06:44 PM, Lukasz Marek wrote: [..] To save your time: 1. I updated ffserver_apply_stream_config function, 2. added comments in FFServerConfig struct in header (according to Stefano's remark) 3. in ffserver_parse_config_stream, at the end added:

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-22 Thread Reynaldo H. Verdejo Pinochet
Hi On 10/20/2014 06:57 PM, Lukasz Marek wrote: So far AVCodecContext was created without codec specified. This causes internal data to not be initialized to defaults. This commit postpone context creation until all information are gathered. are/is Partially fixes #1275 --- ffserver.c

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-22 Thread Lukasz Marek
On 22.10.2014 22:05, Reynaldo H. Verdejo Pinochet wrote: Guess you are already considered dropping the explicit initialization code as Reimaer suggested. Looks good otherwise. Feel free to push. I've attached updated patch. To save your time: 1. I updated ffserver_apply_stream_config

[FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-20 Thread Lukasz Marek
So far AVCodecContext was created without codec specified. This causes internal data to not be initialized to defaults. This commit postpone context creation until all information are gathered. Partially fixes #1275 --- ffserver.c| 8 +- ffserver_config.c | 286

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-20 Thread Lukasz Marek
On 20.10.2014 23:57, Lukasz Marek wrote: So far AVCodecContext was created without codec specified. This causes internal data to not be initialized to defaults. This commit postpone context creation until all information are gathered. Partially fixes #1275 --- ffserver.c| 8 +-