Re: [FFmpeg-devel] [PATCH 4/4] lavc/audiotoolboxdec: fix a number of config and timestamp issues

2016-03-25 Thread pon pon
2016-03-25 0:40 GMT+09:00 Rodger Combs : > Fixed with this patch: > > i tested there are some errors patch decoding and encoding. patch error patch -p1 < "audiotoolboxenc_fixed_1_remove unneeded packet metadata.patch" patch unexpectedly ends in middle of line decoding

Re: [FFmpeg-devel] [PATCH 4/4] lavc/audiotoolboxdec: fix a number of config and timestamp issues

2016-03-24 Thread Rodger Combs
> On Mar 24, 2016, at 03:55, Carl Eugen Hoyos wrote: > > Rodger Combs gmail.com> writes: > >> - Channel layouts were never exported >> - Channel mappings were incorrect beyond stereo > > What happens if you don't pass a channel layout? > Does the encoder work? Does it

Re: [FFmpeg-devel] [PATCH 4/4] lavc/audiotoolboxdec: fix a number of config and timestamp issues

2016-03-24 Thread Carl Eugen Hoyos
Rodger Combs gmail.com> writes: > - Channel layouts were never exported > - Channel mappings were incorrect beyond stereo What happens if you don't pass a channel layout? Does the encoder work? Does it return a channel layout? Does the AAC encoder support more than one channel layout for a

[FFmpeg-devel] [PATCH 4/4] lavc/audiotoolboxdec: fix a number of config and timestamp issues

2016-03-24 Thread Rodger Combs
- ADTS-formatted AAC didn't work - Channel layouts were never exported - Channel mappings were incorrect beyond stereo - Channel counts weren't updated after packets were decoded - Timestamps were exported incorrectly --- libavcodec/audiotoolboxdec.c | 248