In the case of most calls to end_ebml_master, the target is within the current
segment, but in this case, it's in the first segment or header file, so if the
context was marked as non-seekable manually (as in segment.c), avio_seek will
ignore that and execute it anyway. This is fine in other
On Sat, Mar 28, 2015 at 07:25:21PM -0600, Rodger Combs wrote:
---
libavformat/matroskaenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 6b2e390..c242a0e 100644
--- a/libavformat/matroskaenc.c
+++
On Sun, Mar 29, 2015 at 11:54:59AM -0600, Rodger Combs wrote:
In the case of most calls to end_ebml_master, the target is within the
current segment, but in this case, it's in the first segment or header file,
so if the context was marked as non-seekable manually (as in segment.c),
On Sun, Mar 29, 2015 at 02:56:00PM -0600, Rodger Combs wrote:
I can see the reasoning here, but as small enough here means 32K,
my concern was that some app might use a single large buffer without
seek function.
32k is too small i agree
I don't think this would be worth doing on a per-muxer
I can see the reasoning here, but as small enough here means 32K, I don't
think this would be worth doing on a per-muxer basis. Maybe if we had a more
general way to tell the muxer about segment boundaries, or if segment.c
provided a single AVIOContext, with a write() function that passes
On Sun, Mar 29, 2015 at 11:08:51PM +0200, Michael Niedermayer wrote:
On Sun, Mar 29, 2015 at 02:56:00PM -0600, Rodger Combs wrote:
I can see the reasoning here, but as small enough here means 32K,
my concern was that some app might use a single large buffer without
seek function.
32k is
---
libavformat/matroskaenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 6b2e390..c242a0e 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -1948,9 +1948,9 @@ static int
