Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-16 Thread Clément Bœsch
On Mon, Mar 16, 2015 at 11:05:12AM +0100, Stefano Sabatini wrote: On date Monday 2015-03-16 11:00:12 +0100, Stefano Sabatini encoded: On date Sunday 2015-03-15 15:15:34 +0100, Clément Bœsch encoded: [...] To elaborate on this, the bug here is referring to an allocation check not done in

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-16 Thread Stefano Sabatini
On date Monday 2015-03-16 11:00:12 +0100, Stefano Sabatini encoded: On date Sunday 2015-03-15 15:15:34 +0100, Clément Bœsch encoded: [...] To elaborate on this, the bug here is referring to an allocation check not done in the caller (there are many currently since I'm just introducing the

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-16 Thread Stefano Sabatini
On date Monday 2015-03-16 11:11:55 +0100, Clément Bœsch encoded: On Mon, Mar 16, 2015 at 11:05:12AM +0100, Stefano Sabatini wrote: On date Monday 2015-03-16 11:00:12 +0100, Stefano Sabatini encoded: On date Sunday 2015-03-15 15:15:34 +0100, Clément Bœsch encoded: [...] To elaborate on

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-16 Thread Stefano Sabatini
On date Sunday 2015-03-15 15:15:34 +0100, Clément Bœsch encoded: On Sun, Mar 15, 2015 at 03:11:14PM +0100, Clément Bœsch wrote: On Sun, Mar 15, 2015 at 03:07:16PM +0100, Stefano Sabatini wrote: On date Sunday 2015-03-15 14:24:29 +0100, Clément Bœsch encoded: ---

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-16 Thread Clément Bœsch
On Mon, Mar 16, 2015 at 01:26:04PM +0100, Stefano Sabatini wrote: On date Monday 2015-03-16 11:11:55 +0100, Clément Bœsch encoded: On Mon, Mar 16, 2015 at 11:05:12AM +0100, Stefano Sabatini wrote: On date Monday 2015-03-16 11:00:12 +0100, Stefano Sabatini encoded: On date Sunday

[FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-15 Thread Clément Bœsch
--- libavfilter/formats.c | 45 - libavfilter/formats.h | 10 +- 2 files changed, 37 insertions(+), 18 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 6393416..4f9773b 100644 --- a/libavfilter/formats.c +++

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-15 Thread Stefano Sabatini
On date Sunday 2015-03-15 14:24:29 +0100, Clément Bœsch encoded: --- libavfilter/formats.c | 45 - libavfilter/formats.h | 10 +- 2 files changed, 37 insertions(+), 18 deletions(-) diff --git a/libavfilter/formats.c

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-15 Thread Clément Bœsch
On Sun, Mar 15, 2015 at 03:11:14PM +0100, Clément Bœsch wrote: On Sun, Mar 15, 2015 at 03:07:16PM +0100, Stefano Sabatini wrote: On date Sunday 2015-03-15 14:24:29 +0100, Clément Bœsch encoded: --- libavfilter/formats.c | 45 -

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-15 Thread Clément Bœsch
On Sun, Mar 15, 2015 at 03:07:16PM +0100, Stefano Sabatini wrote: On date Sunday 2015-03-15 14:24:29 +0100, Clément Bœsch encoded: --- libavfilter/formats.c | 45 - libavfilter/formats.h | 10 +- 2 files changed, 37 insertions(+), 18