Re: [FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-28 Thread Nicolas George
Marton Balint (12019-02-28): > Please use the activate callback of AVFilter context instead. If it is one in, one out, it is not really necessary. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-28 Thread Marton Balint
On Wed, 27 Feb 2019, Mark Thompson wrote: This can be used to add region of interest side data to video frames. --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_addroi.c | 237 +++ 3 files changed, 239 insertions(+)

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-28 Thread Moritz Barsnick
On Thu, Feb 28, 2019 at 01:18:06 +, Mark Thompson wrote: > > Can ROIs not also be defined as x, y, w, h? > > Sure, it would be easy to change if people prefer that. It was just my personal observation (and preference) > This was chosen pretty much entirely because it matches the structure >

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-27 Thread Mark Thompson
On 27/02/2019 23:42, Moritz Barsnick wrote: > On Wed, Feb 27, 2019 at 22:00:23 +, Mark Thompson wrote: >> +static const AVOption addroi_options[] = { >> +{ "top","Region distance from top edge of frame", >> + OFFSET(region_str[TOP]),AV_OPT_TYPE_STRING, { .str = "0" }, >>

Re: [FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-27 Thread Moritz Barsnick
On Wed, Feb 27, 2019 at 22:00:23 +, Mark Thompson wrote: > +static const AVOption addroi_options[] = { > +{ "top","Region distance from top edge of frame", > + OFFSET(region_str[TOP]),AV_OPT_TYPE_STRING, { .str = "0" }, .flags > = FLAGS }, > +{ "bottom", "Region distance

[FFmpeg-devel] [PATCH 5/5] lavfi: addroi filter

2019-02-27 Thread Mark Thompson
This can be used to add region of interest side data to video frames. --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_addroi.c | 237 +++ 3 files changed, 239 insertions(+) create mode 100644 libavfilter/vf_addroi.c