Re: [FFmpeg-devel] [PATCH 5/7] avformat/segafilmenc: Remove redundant checks

2020-02-22 Thread Michael Niedermayer
On Fri, Feb 21, 2020 at 02:10:00PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH 5/7] avformat/segafilmenc: Remove redundant checks

2020-02-21 Thread Paul B Mahol
lgtm On 1/14/20, Andreas Rheinhardt wrote: > If an audio stream is present, the Sega FILM muxer checks for its > compability with the container during init, so that the very same check > needn't be repeated during writing the trailer. > > Essentially the same is true for the presence of a video

Re: [FFmpeg-devel] [PATCH 5/7] avformat/segafilmenc: Remove redundant checks

2020-02-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> If an audio stream is present, the Sega FILM muxer checks for its >> compability with the container during init, so that the very same check >> needn't be repeated during writing the trailer. >> >> Essentially the same is true for the presence of a

Re: [FFmpeg-devel] [PATCH 5/7] avformat/segafilmenc: Remove redundant checks

2020-02-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > If an audio stream is present, the Sega FILM muxer checks for its > compability with the container during init, so that the very same check > needn't be repeated during writing the trailer. > > Essentially the same is true for the presence of a video stream: It has > already

[FFmpeg-devel] [PATCH 5/7] avformat/segafilmenc: Remove redundant checks

2020-01-13 Thread Andreas Rheinhardt
If an audio stream is present, the Sega FILM muxer checks for its compability with the container during init, so that the very same check needn't be repeated during writing the trailer. Essentially the same is true for the presence of a video stream: It has already been checked during init.