Re: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer overflows in
On Sun, Aug 18, 2019 at 11:21:04AM +0200, Michael Niedermayer wrote: > On Sat, Aug 17, 2019 at 03:40:26PM +0200, Moritz Barsnick wrote: > > On Thu, Aug 15, 2019 at 23:49:15 +0200, Michael Niedermayer wrote: > > > Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple > > > integer overflows in > > > > ... in what? Spurious " in"? > > ... overflows in tm2_null_res_block() > > fixed locally will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer overflows in
On Sat, Aug 17, 2019 at 03:40:26PM +0200, Moritz Barsnick wrote: > On Thu, Aug 15, 2019 at 23:49:15 +0200, Michael Niedermayer wrote: > > Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple > > integer overflows in > > ... in what? Spurious " in"? ... overflows in tm2_null_res_block() fixed locally thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer overflows in
On Thu, Aug 15, 2019 at 23:49:15 +0200, Michael Niedermayer wrote: > Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer > overflows in ... in what? Spurious " in"? Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer overflows in
Fixes: signed integer overflow: 1795032576 + 598344192 cannot be represented in
type 'int'
Fixes:
16196/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5636723419119616
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/truemotion2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/truemotion2.c b/libavcodec/truemotion2.c
index 5d6dfc24c3..27c876fd7d 100644
--- a/libavcodec/truemotion2.c
+++ b/libavcodec/truemotion2.c
@@ -619,7 +619,7 @@ static inline void tm2_null_res_block(TM2Context *ctx,
AVFrame *pic, int bx, int
ct = ctx->D[0] + ctx->D[1] + ctx->D[2] + ctx->D[3];
if (bx > 0)
-left = last[-1] - ct;
+left = last[-1] - (unsigned)ct;
else
left = 0;
@@ -630,7 +630,7 @@ static inline void tm2_null_res_block(TM2Context *ctx,
AVFrame *pic, int bx, int
last[2] = right - (diff >> 2);
last[3] = right;
{
-int tp = left;
+unsigned tp = left;
ctx->D[0] = (tp + (ct >> 2)) - left;
left += ctx->D[0];
--
2.22.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
