Re: [FFmpeg-devel] [PATCH V1] lavf/matroskaenc: Fix memory leak after write trailer

2019-04-04 Thread Hendrik Leppkes
On Thu, Apr 4, 2019 at 3:05 PM Andreas Rheinhardt via ffmpeg-devel wrote: > > And I think that this memleak in mkv_write_trailer() has a twin in > mkv_write_packet(): Audio frames are not written directly, but rather > put into storage in cur_audio_pkt via av_packet_ref(). But if the > preceding a

Re: [FFmpeg-devel] [PATCH V1] lavf/matroskaenc: Fix memory leak after write trailer

2019-04-04 Thread Andreas Rheinhardt via ffmpeg-devel
And I think that this memleak in mkv_write_trailer() has a twin in mkv_write_packet(): Audio frames are not written directly, but rather put into storage in cur_audio_pkt via av_packet_ref(). But if the preceding audio packet was a zero size packet (but possibly with side-data), then the preceding

Re: [FFmpeg-devel] [PATCH V1] lavf/matroskaenc: Fix memory leak after write trailer

2019-04-04 Thread Andreas Rheinhardt via ffmpeg-devel
Hendrik Leppkes: > On Thu, Apr 4, 2019 at 11:25 AM Jun Zhao wrote: >> >> From: Jun Zhao >> >> Fix memory leak after write trailer for #7827 >> >> Signed-off-by: Jun Zhao >> --- >> libavformat/matroskaenc.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH V1] lavf/matroskaenc: Fix memory leak after write trailer

2019-04-04 Thread myp...@gmail.com
On Thu, Apr 4, 2019 at 5:43 PM Hendrik Leppkes wrote: > > On Thu, Apr 4, 2019 at 11:25 AM Jun Zhao wrote: > > > > From: Jun Zhao > > > > Fix memory leak after write trailer for #7827 > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/matroskaenc.c |2 +- > > 1 files changed, 1 inserti

Re: [FFmpeg-devel] [PATCH V1] lavf/matroskaenc: Fix memory leak after write trailer

2019-04-04 Thread Hendrik Leppkes
On Thu, Apr 4, 2019 at 11:25 AM Jun Zhao wrote: > > From: Jun Zhao > > Fix memory leak after write trailer for #7827 > > Signed-off-by: Jun Zhao > --- > libavformat/matroskaenc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavform

[FFmpeg-devel] [PATCH V1] lavf/matroskaenc: Fix memory leak after write trailer

2019-04-04 Thread Jun Zhao
From: Jun Zhao Fix memory leak after write trailer for #7827 Signed-off-by: Jun Zhao --- libavformat/matroskaenc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index b9f99c4..22ba93a 100644 --- a/libavformat/mat