Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-14 Thread myp...@gmail.com
On Tue, Jan 14, 2020 at 8:46 PM Moritz Barsnick wrote: > > On Tue, Jan 14, 2020 at 09:31:56 +0800, myp...@gmail.com wrote: > > > On Sat, Jan 11, 2020 at 12:13:48 +0800, Jun Zhao wrote: > > > > +Same as quality option. And the command accepts the @code{max} same as > > > > the @code{6}. > > > >

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-14 Thread Moritz Barsnick
On Tue, Jan 14, 2020 at 09:31:56 +0800, myp...@gmail.com wrote: > > On Sat, Jan 11, 2020 at 12:13:48 +0800, Jun Zhao wrote: > > > +Same as quality option. And the command accepts the @code{max} same as > > > the @code{6}. > > Are you trying to say that the allowed range for the command(s) is > >

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-13 Thread myp...@gmail.com
On Mon, Jan 13, 2020 at 9:27 PM Moritz Barsnick wrote: > > On Sat, Jan 11, 2020 at 12:13:48 +0800, Jun Zhao wrote: > > +@item level > > +@item quality > > +Same as quality option. And the command accepts the @code{max} same as the > > @code{6}. > > +@end table > > I'm sorry for coming in late,

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-13 Thread Moritz Barsnick
On Sat, Jan 11, 2020 at 12:13:48 +0800, Jun Zhao wrote: > +@item level > +@item quality > +Same as quality option. And the command accepts the @code{max} same as the > @code{6}. > +@end table I'm sorry for coming in late, but this sentence doesn't make much sense to me: And the command

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-12 Thread myp...@gmail.com
On Mon, Jan 13, 2020 at 9:19 AM myp...@gmail.com wrote: > > On Sun, Jan 12, 2020 at 2:50 AM Michael Niedermayer > wrote: > > > > On Sat, Jan 11, 2020 at 12:13:48PM +0800, Jun Zhao wrote: > > > From: Jun Zhao > > > > > > it's stranage to use option "level" in runtime change path but used > > >

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-12 Thread myp...@gmail.com
On Sun, Jan 12, 2020 at 2:50 AM Michael Niedermayer wrote: > > On Sat, Jan 11, 2020 at 12:13:48PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > it's stranage to use option "level" in runtime change path but used > > "quality" in option, add "quality" in runtime change path, it's more > >

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-11 Thread Michael Niedermayer
On Sat, Jan 11, 2020 at 12:13:48PM +0800, Jun Zhao wrote: > From: Jun Zhao > > it's stranage to use option "level" in runtime change path but used > "quality" in option, add "quality" in runtime change path, it's more > intuitive and keep the "level" for compatibility. > > Signed-off-by: Jun

[FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-10 Thread Jun Zhao
From: Jun Zhao it's stranage to use option "level" in runtime change path but used "quality" in option, add "quality" in runtime change path, it's more intuitive and keep the "level" for compatibility. Signed-off-by: Jun Zhao --- doc/filters.texi |9 + libavfilter/vf_spp.c |