Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-02 Thread Tao Zhang
Paul B Mahol 于2019年11月2日周六 下午6:34写道: > > You mixed functional and non-functional changes in single patch. Lesson learned. I'll submit a new patch. Thanks a lot. Today is a good day. > This is big no. > > On 11/2/19, Tao Zhang wrote: > > Good weekend. Is it ok or any more suggestions? > > > > Tao

Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-02 Thread Paul B Mahol
You mixed functional and non-functional changes in single patch. This is big no. On 11/2/19, Tao Zhang wrote: > Good weekend. Is it ok or any more suggestions? > > Tao Zhang 于2019年10月28日周一 下午2:53写道: >> >> ping >> >> leozhang 于2019年10月24日周四 下午5:18写道: >> > >> > Reviewed-by: Paul B Mahol >> >

Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-02 Thread Tao Zhang
Good weekend. Is it ok or any more suggestions? Tao Zhang 于2019年10月28日周一 下午2:53写道: > > ping > > leozhang 于2019年10月24日周四 下午5:18写道: > > > > Reviewed-by: Paul B Mahol > > Reviewed-by: Jun Zhao > > Signed-off-by: leozhang > > --- > > libavfilter/vf_bilateral.c | 57 > >

Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-10-28 Thread Tao Zhang
ping leozhang 于2019年10月24日周四 下午5:18写道: > > Reviewed-by: Paul B Mahol > Reviewed-by: Jun Zhao > Signed-off-by: leozhang > --- > libavfilter/vf_bilateral.c | 57 > ++ > 1 file changed, 43 insertions(+), 14 deletions(-) > > diff --git