Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-11 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Pedro Arthur > Sent: 2021年4月12日 5:12 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Em dom

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-11 Thread Pedro Arthur
Em dom., 11 de abr. de 2021 às 14:53, Nicolas George escreveu: > > Anton Khirnov (12021-04-11): > > We are a generic multimedia framework. "the field" for us is multimedia > > in general, so we should use names meaningful in general multimedia > > context. > > I mostly agree with Lynne, "bounding

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-11 Thread Nicolas George
Anton Khirnov (12021-04-11): > We are a generic multimedia framework. "the field" for us is multimedia > in general, so we should use names meaningful in general multimedia > context. > I mostly agree with Lynne, "bounding box" is confusing and misleading > when this structure is built around

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-11 Thread Anton Khirnov
Quoting Pedro Arthur (2021-04-09 16:35:52) > +1 > > I think it is wise to use the name which is widely used in the field. We are a generic multimedia framework. "the field" for us is multimedia in general, so we should use names meaningful in general multimedia context. I mostly agree with

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: 2021年4月10日 3:20 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 9, 2021

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-10 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: 2021年4月9日 23:16 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 9, 2021

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Lynne
gt; >> >> >> >> >> >> > -Original Message- >> >> > From: ffmpeg-devel On Behalf Of Lynne >> >> > Sent: 2021年4月9日 0:57 >> >> > To: FFmpeg development discussions and patches >> >> > Subject: Re:

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Pedro Arthur
t;> > From: ffmpeg-devel On Behalf Of Lynne > >> > Sent: 2021年4月9日 0:57 > >> > To: FFmpeg development discussions and patches > >> > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > >> > AV_FRAME_DATA_BOUNDING_BOXES > >&g

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Lynne
FFmpeg-devel] [PATCH V7 4/6] lavu: add side data >> AV_FRAME_DATA_BOUNDING_BOXES >> >> >> >> > -Original Message- >> > From: ffmpeg-devel On Behalf Of >> > Lynne >> > Sent: 2021年4月9日 18:03 >> > To: FFmpeg development discussions and patches >&g

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Lynne
o: FFmpeg development discussions and patches >> > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data >> > AV_FRAME_DATA_BOUNDING_BOXES >> > >> >> First of all, thanks for the quick replies, I see, all the >> discussions/comments are to >> mak

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Guo, Yejun > Sent: 2021年4月9日 20:57 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > >

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Pedro Arthur
Em sex., 9 de abr. de 2021 às 01:13, Guo, Yejun escreveu: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Lynne > > Sent: 2021年4月9日 0:57 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-de

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: 2021年4月9日 18:03 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 9, 2021

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-09 Thread Lynne
Apr 9, 2021, 06:12 by yejun@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Lynne >> Sent: 2021年4月9日 0:57 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年4月9日 0:57 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > First of all, thanks for the

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Lynne
Apr 8, 2021, 16:51 by yejun@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Lynne >> Sent: 2021年4月8日 19:35 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: 2021年4月8日 22:54 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Guo, Yejun (1

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Nicolas George
Guo, Yejun (12021-04-08): > I'm afraid that we could not make sure all such filters (including filters in > the > future) to do the rescale. And in the previous discussion, I got to know that > 'many other existing side-data types are invalidated by scaling'. > > So, we need frame_width and

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年4月8日 19:35 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 8, 2021, 07:3

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Lynne
Apr 8, 2021, 07:35 by yejun@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Lynne >> Sent: 2021年4月8日 12:14 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年4月8日 12:14 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 8, 2021, 04:4

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Lynne
Apr 8, 2021, 04:48 by yejun@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Lynne >> Sent: 2021年4月8日 5:04 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年4月8日 5:04 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 7, 2021, 16:1

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年4月8日 0:07 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Guo, Yejun: > &g

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Lynne
Apr 7, 2021, 16:17 by yejun@intel.com: > Signed-off-by: Guo, Yejun > --- > doc/APIchanges | 2 + > libavutil/Makefile | 2 + > libavutil/boundingbox.c | 73 + > libavutil/boundingbox.h | 114 >

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Andreas Rheinhardt
Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2021年4月7日 22:44 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data >> AV_FRAME_DATA

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年4月7日 22:44 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Guo, Yejun: &g

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Nicolas George
Andreas Rheinhardt (12021-04-07): > > +ret->header.bboxes_offset = (char *)>boxes - (char *)>header; > > Using offsetof would be clearer (for this you have to declare a proper > type). I find this version rather clearer. offsetof is good we we do not have a pointer to do the actual

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Andreas Rheinhardt
Guo, Yejun: > Signed-off-by: Guo, Yejun > --- > doc/APIchanges | 2 + > libavutil/Makefile | 2 + > libavutil/boundingbox.c | 73 + > libavutil/boundingbox.h | 114 > libavutil/frame.c | 1 + >

[FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-07 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- doc/APIchanges | 2 + libavutil/Makefile | 2 + libavutil/boundingbox.c | 73 + libavutil/boundingbox.h | 114 libavutil/frame.c | 1 + libavutil/frame.h | 7 +++ 6