Anton Khirnov (12023-04-24):
> I think the point on which we disagree is your notion of "error
> conditions" as being basically interchangeable.
The way everything, FFmpeg and all other sane system work, is that the
caller handles the very few errors it know how to handle (EAGAIN
certainly, maybe
Marton Balint (12023-04-24):
> The API change is that muxers are no longer allowed to return AVERROR_EOF
> for an error condition.
There is no API change because applications are not allowed to write
muxers. At worst, it would be an internal API change.
But it is not even an internal API change,
Quoting Marton Balint (2023-04-24 21:42:26)
>
>
> On Mon, 24 Apr 2023, Anton Khirnov wrote:
>
> > Quoting Marton Balint (2023-04-24 20:41:55)
> >>
> >>
> >> On Mon, 24 Apr 2023, Anton Khirnov wrote:
> >>
> >>> Quoting Marton Balint (2023-04-24 11:09:44)
> The real risk is that they
On Mon, 24 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-24 20:41:55)
On Mon, 24 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-24 11:09:44)
The real risk is that they unintentionally do that, when the error code is
coming from some underlying operation
Quoting Marton Balint (2023-04-24 20:41:55)
>
>
> On Mon, 24 Apr 2023, Anton Khirnov wrote:
>
> > Quoting Marton Balint (2023-04-24 11:09:44)
> >> The real risk is that they unintentionally do that, when the error code is
> >> coming from some underlying operation for example.
> >>
> >> So
On Mon, 24 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-24 11:09:44)
The real risk is that they unintentionally do that, when the error code is
coming from some underlying operation for example.
So previsouly a muxer could return any error code to signal error
condition
Quoting Marton Balint (2023-04-24 11:09:44)
>
>
> On Sun, 23 Apr 2023, Anton Khirnov wrote:
>
> > Quoting Marton Balint (2023-04-23 20:15:13)
> >>
> >>
> >> On Sun, 23 Apr 2023, Anton Khirnov wrote:
> >> I don't understand. A good program propagates back error conditions to the
> >> user, and
Quoting Marton Balint (2023-04-24 11:09:44)
> The real risk is that they unintentionally do that, when the error code is
> coming from some underlying operation for example.
>
> So previsouly a muxer could return any error code to signal error
> condition and reasonably assume that ffmpeg.c
Marton Balint (12023-04-24):
> The change in ffmpeg.c "forces" muxers to check if they ever get AVERROR_EOF
> for some real error condition and map them to e.g. AVERROR(EIO). And that is
> an API change.
Indeed. And the documentation agrees:
* @return < 0 on error, = 0 if OK, 1 if flushed and
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 20:15:13)
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 12:05:51)
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 11:42:48)
On Sun, 23 Apr 2023,
Quoting Marton Balint (2023-04-23 20:15:13)
>
>
> On Sun, 23 Apr 2023, Anton Khirnov wrote:
>
> > Quoting Marton Balint (2023-04-23 12:05:51)
> >>
> >>
> >> On Sun, 23 Apr 2023, Anton Khirnov wrote:
> >>
> >>> Quoting Marton Balint (2023-04-23 11:42:48)
> On Sun, 23 Apr 2023, Anton Khirnov
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 12:05:51)
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 11:42:48)
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 11:12:38)
This seems like yet
Quoting Marton Balint (2023-04-23 12:05:51)
>
>
> On Sun, 23 Apr 2023, Anton Khirnov wrote:
>
> > Quoting Marton Balint (2023-04-23 11:42:48)
> >> On Sun, 23 Apr 2023, Anton Khirnov wrote:
> >>> Quoting Marton Balint (2023-04-23 11:12:38)
> This seems like yet another clash of AVERROR_EOF
Marton Balint (12023-04-23):
> https://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306247.html
Looks like something that sould return AVERORR(EPIPE).
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 11:42:48)
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 11:12:38)
This seems like yet another clash of AVERROR_EOF error codes coming from
different places with different semantics.
Quoting Marton Balint (2023-04-23 11:42:48)
> On Sun, 23 Apr 2023, Anton Khirnov wrote:
> > Quoting Marton Balint (2023-04-23 11:12:38)
> >> This seems like yet another clash of AVERROR_EOF error codes coming from
> >> different places with different semantics. For
> >>
> On Apr 23, 2023, at 17:42, Marton Balint wrote:
>
> On Sun, 23 Apr 2023, Anton Khirnov wrote:
>
>> Quoting Marton Balint (2023-04-23 11:12:38)
>>>
>>>
>>> On Sat, 22 Apr 2023, Anton Khirnov wrote:
>>>
Quoting Zhao Zhili (2023-04-22 14:56:34)
> From: Zhao Zhili
>
> Fix
On Sun, 23 Apr 2023, Anton Khirnov wrote:
Quoting Marton Balint (2023-04-23 11:12:38)
On Sat, 22 Apr 2023, Anton Khirnov wrote:
Quoting Zhao Zhili (2023-04-22 14:56:34)
From: Zhao Zhili
Fix #10327.
Signed-off-by: Zhao Zhili
---
fftools/ffmpeg_mux.c | 12 +---
1 file
Quoting Marton Balint (2023-04-23 11:12:38)
>
>
> On Sat, 22 Apr 2023, Anton Khirnov wrote:
>
> > Quoting Zhao Zhili (2023-04-22 14:56:34)
> >> From: Zhao Zhili
> >>
> >> Fix #10327.
> >>
> >> Signed-off-by: Zhao Zhili
> >> ---
> >> fftools/ffmpeg_mux.c | 12 +---
> >> 1 file
On Sat, 22 Apr 2023, Anton Khirnov wrote:
Quoting Zhao Zhili (2023-04-22 14:56:34)
From: Zhao Zhili
Fix #10327.
Signed-off-by: Zhao Zhili
---
fftools/ffmpeg_mux.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/fftools/ffmpeg_mux.c
Quoting Zhao Zhili (2023-04-22 14:56:34)
> From: Zhao Zhili
>
> Fix #10327.
>
> Signed-off-by: Zhao Zhili
> ---
> fftools/ffmpeg_mux.c | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c
> index
From: Zhao Zhili
Fix #10327.
Signed-off-by: Zhao Zhili
---
fftools/ffmpeg_mux.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c
index a2e8873ad2..0e1a5d7dc5 100644
--- a/fftools/ffmpeg_mux.c
+++
22 matches
Mail list logo
