Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-12-03 Thread Mina
On 11/28/18 11:24 PM, Moritz Barsnick wrote: On Mon, Oct 01, 2018 at 18:09:46 +0200, Mina wrote: Nit: Thanks for your feedback and sorry for late response. +be chosen in the range [1,20] and default value is 1. [...] Not sure what is here. +chosen in the range [0.2,1024.0] and

Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-11-28 Thread Moritz Barsnick
On Mon, Oct 01, 2018 at 18:09:46 +0200, Mina wrote: Nit: > +be chosen in the range [1,20] and default value is 1. [...] > +chosen in the range [0.2,1024.0] and default value = 1. A bit inconsistent here, with "is" vs. "=". > +The max number of iterations for performing the algorithm. Must be

Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-11-28 Thread Thilo Borgmann
>> V2 changes: >> - fixed some spelling mistakes in filters.texi >> - fixed some text format error in filters.texi Will apply soon if there are no further comments. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-10-13 Thread Mina
On 10/01/2018 06:09 PM, Mina wrote: Hi,   This patch was part of GSoC Color Constancy filter. It introduces an improved color constancy filter(weighted_greyedge) based on the already pushed greyedge. I'm sending it again after updating it against latest version of master. V2 changes: -

[FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-10-01 Thread Mina
Hi,   This patch was part of GSoC Color Constancy filter. It introduces an improved color constancy filter(weighted_greyedge) based on the already pushed greyedge. I'm sending it again after updating it against latest version of master. V2 changes: - fixed some spelling mistakes in