Re: [FFmpeg-devel] [PATCH v2] libavcodec/mpegvideo_parser: improve detection of progressive mpeg2

2017-12-12 Thread Aman Gupta 
On Fri, Dec 8, 2017 at 9:10 AM, Michael Niedermayer 
wrote:

> On Thu, Dec 07, 2017 at 04:05:15PM -0800, Aman Gupta wrote:
> > From: Aman Gupta 
> >
> > Previously many progressive mpeg2video samples were detected as
> interlaced
> > by ffmpeg/ffprobe. For example, https://tmm1.s3.amazonaws.com/720p.ts
> >
> > Before:
> >
> > Input #0, mpegts, from 'https://tmm1.s3.amazonaws.com/720p.ts':
> >   Duration: 00:00:08.62, start: 18974.073233, bitrate: 9734 kb/s
> >   Program 2
> >   Stream #0:0[0x12eb]: Video: mpeg2video (Main), yuv420p(tv, bottom
> first), 1280x720 ...
> >
> > After:
> >
> > Input #0, mpegts, from 'https://tmm1.s3.amazonaws.com/720p.ts':
> >   Duration: 00:00:08.62, start: 18974.073233, bitrate: 9734 kb/s
> >   Program 2
> >   Stream #0:0[0x12eb]: Video: mpeg2video (Main), yuv420p(tv,
> progressive), 1280x720 ...
>
> commit message sounds ok
> no more comments from me, please wait a bit with applying so others
> can comment too
>

Applied. Thanks for the review.

Aman


>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The greatest way to live with honor in this world is to be what we pretend
> to be. -- Socrates
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] libavcodec/mpegvideo_parser: improve detection of progressive mpeg2

2017-12-08 Thread Michael Niedermayer 
On Thu, Dec 07, 2017 at 04:05:15PM -0800, Aman Gupta wrote:
> From: Aman Gupta 
> 
> Previously many progressive mpeg2video samples were detected as interlaced
> by ffmpeg/ffprobe. For example, https://tmm1.s3.amazonaws.com/720p.ts
> 
> Before:
> 
> Input #0, mpegts, from 'https://tmm1.s3.amazonaws.com/720p.ts':
>   Duration: 00:00:08.62, start: 18974.073233, bitrate: 9734 kb/s
>   Program 2
>   Stream #0:0[0x12eb]: Video: mpeg2video (Main), yuv420p(tv, bottom 
> first), 1280x720 ...
> 
> After:
> 
> Input #0, mpegts, from 'https://tmm1.s3.amazonaws.com/720p.ts':
>   Duration: 00:00:08.62, start: 18974.073233, bitrate: 9734 kb/s
>   Program 2
>   Stream #0:0[0x12eb]: Video: mpeg2video (Main), yuv420p(tv, 
> progressive), 1280x720 ...

commit message sounds ok
no more comments from me, please wait a bit with applying so others
can comment too

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH v2] libavcodec/mpegvideo_parser: improve detection of progressive mpeg2

2017-12-07 Thread Aman Gupta 
From: Aman Gupta 

Previously many progressive mpeg2video samples were detected as interlaced
by ffmpeg/ffprobe. For example, https://tmm1.s3.amazonaws.com/720p.ts

Before:

Input #0, mpegts, from 'https://tmm1.s3.amazonaws.com/720p.ts':
  Duration: 00:00:08.62, start: 18974.073233, bitrate: 9734 kb/s
  Program 2
Stream #0:0[0x12eb]: Video: mpeg2video (Main), yuv420p(tv, bottom 
first), 1280x720 ...

After:

Input #0, mpegts, from 'https://tmm1.s3.amazonaws.com/720p.ts':
  Duration: 00:00:08.62, start: 18974.073233, bitrate: 9734 kb/s
  Program 2
Stream #0:0[0x12eb]: Video: mpeg2video (Main), yuv420p(tv, 
progressive), 1280x720 ...

Signed-off-by: Michael Niedermayer 
---
 libavcodec/mpegvideo_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c
index de70cd5632..be240b6890 100644
--- a/libavcodec/mpegvideo_parser.c
+++ b/libavcodec/mpegvideo_parser.c
@@ -131,7 +131,7 @@ static void mpegvideo_extract_headers(AVCodecParserContext 
*s,
 }
 }
 
-if (!pc->progressive_sequence) {
+if (!pc->progressive_sequence && !progressive_frame) {
 if (top_field_first)
 s->field_order = AV_FIELD_TT;
 else
-- 
2.14.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel