Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
Thank you for your suggestions. I will push an update to the patch with documentation and will hold off on STT and EIT[0-3] tables for a later patch. On Mon, May 20, 2019 at 7:24 AM Devin Heitmueller < dheitmuel...@kernellabs.com> wrote: > On Mon, May 20, 2019 at 8:36 AM Phil Burr wrote: > > >

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Devin Heitmueller
On Mon, May 20, 2019 at 8:36 AM Phil Burr wrote: > > Thank you for the feedback. I will look into adding documentation for the > atsc metadata. ATSC requires in addition to the tables I've added, the STT > and EIT0-EIT3 tables. I'm thinking of adding support for STT and at least > producing emp

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
Thank you for the feedback. I will look into adding documentation for the atsc metadata. ATSC requires in addition to the tables I've added, the STT and EIT0-EIT3 tables. I'm thinking of adding support for STT and at least producing empty EIT tables so that the stream would be minimally complian

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-19 Thread Devin Heitmueller
Hello Phillip, On Thu, May 16, 2019 at 9:32 AM Phillip Burr wrote: > > Minimal support for ATSC PSIP tables. Does not support STT or > EIT tables and so is not compliant with terrestrial ATSC. > ATSC tables are not created by default, and will only be transmitted > if either "atsc_name" or "atsc

[FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-16 Thread Phillip Burr
Minimal support for ATSC PSIP tables. Does not support STT or EIT tables and so is not compliant with terrestrial ATSC. ATSC tables are not created by default, and will only be transmitted if either "atsc_name" or "atsc_channel" metadata is supplied. Signed-off-by: Phillip Burr --- libavformat/