Re: [FFmpeg-devel] [PATCH v2 03/12] lavc/videotoolboxenc: Require hardware encoding

2016-04-26 Thread Carl Eugen Hoyos
Richard Kern gmail.com> writes: > >> +#if !TARGET_OS_IPHONE > >> +{ "allow_sw", "Allow software encoding", OFFSET(allow_sw), > > > > I have no strong opinion, but shouldn't the option > > always exist (but only work in some cases)? > iOS doesn’t support software encoding, and the

Re: [FFmpeg-devel] [PATCH v2 03/12] lavc/videotoolboxenc: Require hardware encoding

2016-04-25 Thread Richard Kern
> On Apr 23, 2016, at 12:25 PM, Carl Eugen Hoyos wrote: > > Rick Kern gmail.com> writes: > >> +#if !TARGET_OS_IPHONE >> +{ "allow_sw", "Allow software encoding", OFFSET(allow_sw), > > I have no strong opinion, but shouldn't the option > always exist (but only work in

Re: [FFmpeg-devel] [PATCH v2 03/12] lavc/videotoolboxenc: Require hardware encoding

2016-04-23 Thread Carl Eugen Hoyos
Rick Kern gmail.com> writes: > +#if !TARGET_OS_IPHONE > +{ "allow_sw", "Allow software encoding", OFFSET(allow_sw), I have no strong opinion, but shouldn't the option always exist (but only work in some cases)? Carl Eugen ___ ffmpeg-devel

[FFmpeg-devel] [PATCH v2 03/12] lavc/videotoolboxenc: Require hardware encoding

2016-04-22 Thread Rick Kern
Software encoding can be allowed by setting allow_sw to 1. Signed-off-by: Rick Kern --- libavcodec/videotoolboxenc.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/libavcodec/videotoolboxenc.c