Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-30 Thread Matthias Troffaes
Dear Mark, On Thu, Nov 30, 2017 at 4:53 AM, Mark Reid wrote: > clang give me a warning telling to do this instead > packages[3] = {{0}}; > I assume thats correct as I see thats used throughout the codebase. Ah yes, that's perfect - good catch. Kind regards, Matthias

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-29 Thread Mark Reid
On Wed, Nov 29, 2017 at 8:19 PM, Mark Reid wrote: > > > On Wed, Nov 29, 2017 at 12:56 PM, Matthias Troffaes < > matthias.troff...@gmail.com> wrote: > >> Dear Mark, >> >> On Wed, Nov 29, 2017 at 4:11 AM, Mark Reid wrote: >> > @@ -1445,12 +1463,13 @@ static int >> > mxf_write_header_metadata_sets

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-29 Thread Mark Reid
On Wed, Nov 29, 2017 at 12:56 PM, Matthias Troffaes < matthias.troff...@gmail.com> wrote: > Dear Mark, > > On Wed, Nov 29, 2017 at 4:11 AM, Mark Reid wrote: > > @@ -1445,12 +1463,13 @@ static int > > mxf_write_header_metadata_sets(AVFormatContext > *s) > > AVDictionaryEntry *entry = NULL; >

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-29 Thread Matthias Troffaes
Dear Mark, On Wed, Nov 29, 2017 at 4:11 AM, Mark Reid wrote: > @@ -1445,12 +1463,13 @@ static int > mxf_write_header_metadata_sets(AVFormatContext *s) > AVDictionaryEntry *entry = NULL; > AVStream *st = NULL; > int i; > - > -MXFPackage packages[2] = {}; > +MXFPackage packa

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-29 Thread Tomas Härdin
On 2017-11-29 05:11, Mark Reid wrote: --- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 42 +++--- 2 files changed, 36 insertions(+), 7 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index 2d5b44943b..ffcc429a8b 100644 --- a/libavfor

[FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-28 Thread Mark Reid
--- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 42 +++--- 2 files changed, 36 insertions(+), 7 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index 2d5b44943b..ffcc429a8b 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -47,6