Re: [FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2020-01-14 Thread Gyan
On 14-01-2020 12:33 pm, Gyan wrote: On 09-01-2020 11:31 am, Gyan wrote: Barring further reviews, I'll retest and push the patchset on Monday. Manual and FATE testing passed. Will push patchset in a day. On 06-01-2020 11:44 am, Gyan wrote: Ping for the remainder of patchset. Expression

Re: [FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2020-01-13 Thread Gyan
On 09-01-2020 11:31 am, Gyan wrote: Barring further reviews, I'll retest and push the patchset on Monday. Manual and FATE testing passed. Will push patchset in a day. On 06-01-2020 11:44 am, Gyan wrote: Ping for the remainder of patchset. Expression parsing and backup has been factorized

Re: [FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2020-01-08 Thread Gyan
Barring further reviews, I'll retest and push the patchset on Monday. On 06-01-2020 11:44 am, Gyan wrote: Ping for the remainder of patchset.  Expression parsing and backup has been factorized so code duplication is minimized. On 01-01-2020 01:12 am, Gyan Doshi wrote: Retains parsed

Re: [FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2020-01-05 Thread Gyan
Ping for the remainder of patchset.  Expression parsing and backup has been factorized so code duplication is minimized. On 01-01-2020 01:12 am, Gyan Doshi wrote: Retains parsed expressions which allows for better error-checking and adding animation support. --- First version was rebased

[FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2019-12-31 Thread Gyan Doshi
Retains parsed expressions which allows for better error-checking and adding animation support. --- First version was rebased incorrectly in scale_eval_dimensions libavfilter/scale_eval.c | 69 +- libavfilter/vf_scale.c | 264 +++ 2 files changed,

[FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2019-12-31 Thread Gyan Doshi
Retains parsed expressions which allows for better error-checking and adding animation support. --- libavfilter/scale_eval.c | 69 +- libavfilter/vf_scale.c | 264 +++ 2 files changed, 246 insertions(+), 87 deletions(-) diff --git