Re: [FFmpeg-devel] [PATCH v3] avdevice/xcbgrab: Add select_region option

2020-07-04 Thread Moritz Barsnick
On Wed, Jul 01, 2020 at 11:30:33 +0200, Omar Emara wrote: > { "region_border", "Set the region border thickness.", > OFFSET(region_border), AV_OPT_TYPE_INT, { .i64 = 3 }, 1, 128, D }, > +{ "select_region", "Select the grabbing region graphically using the > pointer.",

Re: [FFmpeg-devel] [PATCH v3] avdevice/xcbgrab: Add select_region option

2020-07-04 Thread Andriy Gelman
On Sat, 04. Jul 21:20, Omar Emara wrote: > > Probably a good idea to check the success of this function (and log error). > > Otherwise, xcb_wait_for_event() will just block and you can't send an > > interrupt > > with ctrl-c because of xcb_grab_server() below. > > Can you elaborate? I am not

Re: [FFmpeg-devel] [PATCH v3] avdevice/xcbgrab: Add select_region option

2020-07-04 Thread Omar Emara
> Probably a good idea to check the success of this function (and log error). > Otherwise, xcb_wait_for_event() will just block and you can't send an > interrupt > with ctrl-c because of xcb_grab_server() below. Can you elaborate? I am not entirely familiar with how logging works. Should I pass

Re: [FFmpeg-devel] [PATCH v3] avdevice/xcbgrab: Add select_region option

2020-07-04 Thread Andriy Gelman
On Wed, 01. Jul 11:30, Omar Emara wrote: > This patch adds a select_region option to the xcbgrab input device. > If set to 1, the user will be prompted to select the grabbing area > graphically by clicking and dragging. A rectangle will be drawn to > mark the grabbing area. A single click with no

[FFmpeg-devel] [PATCH v3] avdevice/xcbgrab: Add select_region option

2020-07-01 Thread Omar Emara
This patch adds a select_region option to the xcbgrab input device. If set to 1, the user will be prompted to select the grabbing area graphically by clicking and dragging. A rectangle will be drawn to mark the grabbing area. A single click with no dragging will select the whole screen. The option