Use "sd_size" instead of "pkt_pal_size".

--
Mats Peterson
http://matsp888.no-ip.org/~mats/
>From ff9a16add48793aa121122c64269cdfdbe6e6c7f Mon Sep 17 00:00:00 2001
From: Mats Peterson <matsp...@yahoo.com>
Date: Sun, 28 Feb 2016 10:55:25 +0100
Subject: [PATCH v4 1/2] lavf/avienc: Add support for palette side data packets

---
 libavformat/avienc.c |   53 +++++++++++++++++++++++++++++---------------------
 1 file changed, 31 insertions(+), 22 deletions(-)

diff --git a/libavformat/avienc.c b/libavformat/avienc.c
index ca505f4..2171674 100644
--- a/libavformat/avienc.c
+++ b/libavformat/avienc.c
@@ -668,39 +668,48 @@ static int avi_write_packet(AVFormatContext *s, AVPacket *pkt)
     if ((ret = write_skip_frames(s, stream_index, pkt->dts)) < 0)
         return ret;
 
-    if (enc->codec_id == AV_CODEC_ID_RAWVIDEO && enc->codec_tag == 0) {
+    if (enc->codec_id == AV_CODEC_ID_RAWVIDEO && enc->codec_tag == 0 && size) {
         int64_t bpc = enc->bits_per_coded_sample != 15 ? enc->bits_per_coded_sample : 16;
         int expected_stride = ((enc->width * bpc + 31) >> 5)*4;
-
+        const uint8_t *pal = NULL;
+        int pal_size = 1 << enc->bits_per_coded_sample;
+        int sd_size, i;
         ret = ff_reshuffle_raw_rgb(s, &pkt, enc, expected_stride);
         if (ret < 0)
             return ret;
-        if (ret) {
-            if (ret == CONTAINS_PAL) {
-                int pc_tag, i;
-                int pal_size = 1 << enc->bits_per_coded_sample;
-                if (!avist->hdr_pal_done) {
-                    int64_t cur_offset = avio_tell(pb);
-                    avio_seek(pb, avist->pal_offset, SEEK_SET);
+        pal = (uint8_t *)av_packet_get_side_data(pkt, AV_PKT_DATA_PALETTE, &sd_size);
+        if (pal && sd_size != AVPALETTE_SIZE) {
+            av_log(s, AV_LOG_ERROR, "Invalid palette side data\n");
+            return AVERROR_INVALIDDATA;
+        }
+        if (!pal && ret == CONTAINS_PAL)
+            pal = data + size - AVPALETTE_SIZE;
+        if (pal) {
+            int pc_tag;
+            if (!avist->hdr_pal_done) {
+                int64_t cur_offset = avio_tell(pb);
+                if (avio_seek(pb, avist->pal_offset, SEEK_SET) >= 0) {
                     for (i = 0; i < pal_size; i++) {
-                        uint32_t v = AV_RL32(data + size - 4*pal_size + 4*i);
+                        uint32_t v = AV_RL32(pal + 4*i);
                         avio_wl32(pb, v & 0xffffff);
                     }
                     avio_seek(pb, cur_offset, SEEK_SET);
-                    avist->hdr_pal_done++;
-                }
-                avi_stream2fourcc(tag, stream_index, enc->codec_type);
-                tag[2] = 'p'; tag[3] = 'c';
-                pc_tag = ff_start_tag(pb, tag);
-                avio_w8(pb, 0);
-                avio_w8(pb, pal_size & 0xFF);
-                avio_wl16(pb, 0); // reserved
-                for (i = 0; i < pal_size; i++) {
-                    uint32_t v = AV_RL32(data + size - 4*pal_size + 4*i);
-                    avio_wb32(pb, v<<8);
                 }
-                ff_end_tag(pb, pc_tag);
+                avist->hdr_pal_done++;
             }
+            avi_stream2fourcc(tag, stream_index, enc->codec_type);
+            tag[2] = 'p'; tag[3] = 'c';
+            pc_tag = ff_start_tag(pb, tag);
+            avio_w8(pb, 0);
+            avio_w8(pb, pal_size & 0xFF);
+            avio_wl16(pb, 0); // reserved
+            for (i = 0; i < pal_size; i++) {
+                uint32_t v = AV_RL32(pal + 4*i);
+                avio_wb32(pb, v<<8);
+            }
+            ff_end_tag(pb, pc_tag);
+        }
+        if (ret) {
             ret = avi_write_packet_internal(s, pkt);
             av_packet_free(&pkt);
             return ret;
-- 
1.7.10.4

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to