Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-27 Thread James Zern
On Wed, Jul 26, 2023 at 2:36 PM Tomas Härdin wrote: > > tis 2023-07-25 klockan 16:18 +0200 skrev Thilo Borgmann: > > Am 25.07.23 um 14:24 schrieb Tomas Härdin: > > > > +// Extremely simplified key frame detection: > > > > +// - the first frame (containing headers) is marked as a key > > >

Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-26 Thread Tomas Härdin
tis 2023-07-25 klockan 16:18 +0200 skrev Thilo Borgmann: > Am 25.07.23 um 14:24 schrieb Tomas Härdin: > > > +    // Extremely simplified key frame detection: > > > +    // - the first frame (containing headers) is marked as a key > > > frame > > > +    // - other frames are marked as non-key

Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-25 Thread James Zern
On Tue, Jul 25, 2023 at 7:18 AM Thilo Borgmann wrote: > > Am 25.07.23 um 14:24 schrieb Tomas Härdin: > >> +// Extremely simplified key frame detection: > >> +// - the first frame (containing headers) is marked as a key > >> frame > >> +// - other frames are marked as non-key frames >

Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-25 Thread Thilo Borgmann
Am 25.07.23 um 14:24 schrieb Tomas Härdin: +    // Extremely simplified key frame detection: +    // - the first frame (containing headers) is marked as a key frame +    // - other frames are marked as non-key frames Is there a more proper way of doing this? All frames (except the ANMF

Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-25 Thread Tomas Härdin
> +    // Extremely simplified key frame detection: > +    // - the first frame (containing headers) is marked as a key > frame > +    // - other frames are marked as non-key frames Is there a more proper way of doing this? Looking briefly at the spec one wonders why they didn't just use regular

[FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-25 Thread Thilo Borgmann
--- libavcodec/webp_parser.c | 130 +++ 1 file changed, 89 insertions(+), 41 deletions(-) diff --git a/libavcodec/webp_parser.c b/libavcodec/webp_parser.c index bd5f94dac5..da853bb1f5 100644 --- a/libavcodec/webp_parser.c +++ b/libavcodec/webp_parser.c @@