Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

Yay, thanks! On 3/16/19 12:04 AM, Michael Niedermayer wrote: > no > will apply > > thx > > [...] > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

On Thu, Mar 14, 2019 at 09:29:49PM +0100, Mathieu Duponchelle wrote: > Hello, is there anything preventing from merging this patch? no will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe your enemies, for they first find out your faults. --

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

Hello, is there anything preventing from merging this patch? On 2/14/19 10:01 PM, Michael Niedermayer wrote: > On Wed, Feb 13, 2019 at 11:49:21PM +0100, Mathieu Duponchelle wrote: >> So, should this go in? :) > if someone checks it against some spec and or tests it against some > decoders,

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

Ping? :) On 2/17/19 1:23 PM, Mathieu Duponchelle wrote: >> It would be better to test against a decoder from a unrelated codebase >> Otherwise its a bit like testing your new language skills by talking with >> yourself. > I have just tested with gstreamer's mpegvideoparse element, it detects the

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

> It would be better to test against a decoder from a unrelated codebase > Otherwise its a bit like testing your new language skills by talking with > yourself. I have just tested with gstreamer's mpegvideoparse element, it detects the closed captions as expected: 0:00:00.602266814 27833  

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

> It would be better to test against a decoder from a unrelated codebase > Otherwise its a bit like testing your new language skills by talking with > yourself. It should be pretty easy to just play the resulting TS in VLC and confirm the captions are present and play correctly. Devin -- Devin

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

On Fri, Feb 15, 2019 at 11:17:38PM +0100, Mathieu Duponchelle wrote: > On 2/14/19 10:01 PM, Michael Niedermayer wrote: > > if someone checks it against some spec and or tests it against some > > decoders, probably yes, > > The relevant part of the spec is section 6.2.3 in >

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

On 2/14/19 10:01 PM, Michael Niedermayer wrote: > if someone checks it against some spec and or tests it against some > decoders, probably yes, The relevant part of the spec is section 6.2.3 in , and I have indeed tested this

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

On Wed, Feb 13, 2019 at 11:49:21PM +0100, Mathieu Duponchelle wrote: > So, should this go in? :) if someone checks it against some spec and or tests it against some decoders, probably yes, also might be a good idea to bump the micro version of libavcodec thanks [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

So, should this go in? :) On 2/8/19 11:10 PM, Mathieu Duponchelle wrote: > --- > doc/encoders.texi | 3 +++ > libavcodec/mpeg12enc.c | 32 > libavcodec/mpegvideo.h | 2 ++ > 3 files changed, 37 insertions(+) > > diff --git a/doc/encoders.texi

[FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 32 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++