Re: [FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-08 Thread Jun Li
On Sat, Jun 8, 2019 at 2:25 AM Nicolas George wrote: > Jun Li (12019-06-07): > > I think a complete validation should be creating a function like > "atodigit" > > , string to digit, instead of using atoi, > > The problem of validation is a common one, and as such it already has a > solution. > >

Re: [FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-08 Thread Nicolas George
Jun Li (12019-06-07): > I think a complete validation should be creating a function like "atodigit" > , string to digit, instead of using atoi, The problem of validation is a common one, and as such it already has a solution. APPLICATION USAGE The atoi() function is subsumed by strtol() but

Re: [FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-07 Thread Jun Li
On Fri, Jun 7, 2019 at 11:54 AM Michael Niedermayer wrote: > On Thu, Jun 06, 2019 at 08:28:15PM -0700, Jun Li wrote: > > Fix #6945 > > Rotate or/and flip frame according to frame's metadata orientation > > --- > > fftools/ffmpeg.c| 5 +++-- > > fftools/ffmpeg.h| 8 > >

Re: [FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-07 Thread Michael Niedermayer
On Thu, Jun 06, 2019 at 08:28:15PM -0700, Jun Li wrote: > Fix #6945 > Rotate or/and flip frame according to frame's metadata orientation > --- > fftools/ffmpeg.c| 5 +++-- > fftools/ffmpeg.h| 8 > fftools/ffmpeg_filter.c | 36 +++- > 3 fil

[FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-06 Thread Jun Li
Fix #6945 Rotate or/and flip frame according to frame's metadata orientation --- fftools/ffmpeg.c| 5 +++-- fftools/ffmpeg.h| 8 fftools/ffmpeg_filter.c | 36 +++- 3 files changed, 42 insertions(+), 7 deletions(-) diff --git a/fftools/ffm