Re: [FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

On Fri, 2015-11-27 at 19:35 -0500, Ganesh Ajjanagadde wrote: >   > @@ -40,6 +39,57 @@ >   * Tables in this file are shared by the AAC decoders and encoder >   */ >   > +#define POW_SF2_ZERO200///< ff_aac_pow2sf_tab index > corresponding to pow(2, 0); Move POW_SF2_ZERO to aac.h, which is

Re: [FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

On Sat, Nov 28, 2015 at 3:38 AM, Rostislav Pehlivanov wrote: > On Fri, 2015-11-27 at 19:35 -0500, Ganesh Ajjanagadde wrote: >> >> @@ -40,6 +39,57 @@ >> * Tables in this file are shared by the AAC decoders and encoder >> */ >> >> +#define POW_SF2_ZERO200///<

Re: [FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

On Sat, Nov 28, 2015 at 10:21 AM, Ganesh Ajjanagadde wrote: > On Sat, Nov 28, 2015 at 10:06 AM, Rostislav Pehlivanov > wrote: >> On Sat, 2015-11-28 at 09:45 -0500, Ganesh Ajjanagadde wrote: >>> >>> Removed the av_cold, did not find a way to cleanly get rid

Re: [FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

On Sat, Nov 28, 2015 at 10:06 AM, Rostislav Pehlivanov wrote: > On Sat, 2015-11-28 at 09:45 -0500, Ganesh Ajjanagadde wrote: >> >> Removed the av_cold, did not find a way to cleanly get rid of the >> inline. I do suggest giving it some thought; it is needless >> executable >>

Re: [FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

On Sat, 2015-11-28 at 09:45 -0500, Ganesh Ajjanagadde wrote: > > Removed the av_cold, did not find a way to cleanly get rid of the > inline. I do suggest giving it some thought; it is needless > executable > bloat since the inline does not help perf. Pushed, thanks. > Hardly a blot as it's

Re: [FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

On Sat, Nov 28, 2015 at 7:50 AM, Ganesh Ajjanagadde wrote: > On Sat, Nov 28, 2015 at 3:38 AM, Rostislav Pehlivanov > wrote: >> On Fri, 2015-11-27 at 19:35 -0500, Ganesh Ajjanagadde wrote: >>> >>> @@ -40,6 +39,57 @@ >>> * Tables in this file are shared by

[FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

Commit 96786a12f6df26990bbe7c0ca4592b3731724469 makes runtime initialization cheap. Tested with FATE, with/without --enable-hardcoded-tables. Reviewed-by: Rostislav Pehlivanov Signed-off-by: Ganesh Ajjanagadde --- libavcodec/Makefile|