Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-16 Thread Zhang Rui
>>> I want to let av_read_frame() tell us (user application) what to do next, >>> by returning limited code, at least limited on special situation >>> which need more handling, including >>> AV_ERROR_EAGIN; >>> AV_ERROR_END_OF_STREAM_YOU_NAME_IT; >>> AV_ERROR_EXIT; // interrupted with interrupt cal

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-16 Thread Zhang Rui
2015-04-15 18:38 GMT+08:00 wm4 : > On Tue, 14 Apr 2015 11:24:23 +0800 > Zhang Rui wrote: > >> 2015-04-14 1:09 GMT+08:00 wm4 : >> > On Mon, 13 Apr 2015 12:02:29 +0800 >> > Zhang Rui wrote: >> > >> >> 2015-04-12 22:45 GMT+08:00 Michael Niedermayer : >> >> > On Sun, Apr 12, 2015 at 12:00:18PM +0800,

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-15 Thread wm4
On Tue, 14 Apr 2015 11:24:23 +0800 Zhang Rui wrote: > 2015-04-14 1:09 GMT+08:00 wm4 : > > On Mon, 13 Apr 2015 12:02:29 +0800 > > Zhang Rui wrote: > > > >> 2015-04-12 22:45 GMT+08:00 Michael Niedermayer : > >> > On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: > >> >> 2015-04-10 22:04 G

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-13 Thread Zhang Rui
2015-04-14 1:09 GMT+08:00 wm4 : > On Mon, 13 Apr 2015 12:02:29 +0800 > Zhang Rui wrote: > >> 2015-04-12 22:45 GMT+08:00 Michael Niedermayer : >> > On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: >> >> 2015-04-10 22:04 GMT+08:00 wm4 : >> >> > On Fri, 10 Apr 2015 21:17:42 +0800 >> >> > Zh

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-13 Thread wm4
On Mon, 13 Apr 2015 12:02:29 +0800 Zhang Rui wrote: > 2015-04-12 22:45 GMT+08:00 Michael Niedermayer : > > On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: > >> 2015-04-10 22:04 GMT+08:00 wm4 : > >> > On Fri, 10 Apr 2015 21:17:42 +0800 > >> > Zhang Rui wrote: > >> >> > >> >> This kind

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-12 Thread Zhang Rui
2015-04-12 22:45 GMT+08:00 Michael Niedermayer : > On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: >> 2015-04-10 22:04 GMT+08:00 wm4 : >> > On Fri, 10 Apr 2015 21:17:42 +0800 >> > Zhang Rui wrote: >> >> >> >> This kind of error handling need some more work in aviobuf.c, >> >> and more a

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-12 Thread Michael Niedermayer
On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: > 2015-04-10 22:04 GMT+08:00 wm4 : > > On Fri, 10 Apr 2015 21:17:42 +0800 > > Zhang Rui wrote: > >> > >> This kind of error handling need some more work in aviobuf.c, > >> and more advises from ffmpeg developers. > >> And i prefer this way

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-11 Thread Zhang Rui
2015-04-10 22:04 GMT+08:00 wm4 : > On Fri, 10 Apr 2015 21:17:42 +0800 > Zhang Rui wrote: >> >> This kind of error handling need some more work in aviobuf.c, >> and more advises from ffmpeg developers. >> And i prefer this way than the patch I posted. > > stdio.h does it this way: FILE has an error

[FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-08 Thread Zhang Rui
avio_feof() and avio_seek() could reset eof_reached to 0, after some silent IO error in avio_r*(). And the reconnection caused by seek makes demuxer to continue read at wrong position. --- libavformat/flvdec.c | 66 1 file changed, 41 insertions