Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-13 Thread Tomas Härdin
On Mon, 2015-10-05 at 14:25 +0200, Tobias Rapp wrote: > On 05.10.2015 09:10, tim nicholson wrote: > > On 04/10/15 13:07, Tomas Härdin wrote: > >> On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: > >>> [...] > >> > >> For me the most important thing is that anything dealing with MXF should >

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-13 Thread Tobias Rapp
On 13.10.2015 08:42, Tomas Härdin wrote: On Mon, 2015-10-05 at 14:25 +0200, Tobias Rapp wrote: On 05.10.2015 09:10, tim nicholson wrote: On 04/10/15 13:07, Tomas Härdin wrote: On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: [...] For me the most important thing is that anything

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-05 Thread tim nicholson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/10/15 13:07, Tomas Härdin wrote: > On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: >> On 19.09.2015 22:49, Tomas Härdin wrote: >>> On Wed, 2015-09-16 at 14:33 +0200, Tobias Rapp wrote: Hi, attached patch fixes ticket #4759

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-05 Thread Tobias Rapp
On 05.10.2015 09:10, tim nicholson wrote: On 04/10/15 13:07, Tomas Härdin wrote: On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: [...] For me the most important thing is that anything dealing with MXF should never write invalid files. +1 for sure. To overstate your point: So it

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-04 Thread Tomas Härdin
On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: > On 19.09.2015 22:49, Tomas Härdin wrote: > > On Wed, 2015-09-16 at 14:33 +0200, Tobias Rapp wrote: > >> Hi, > >> > >> attached patch fixes ticket #4759 but I guess it is a bit too hasty to > >> always abort transcoding if a single frame

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-09-19 Thread Tomas Härdin
On Wed, 2015-09-16 at 14:33 +0200, Tobias Rapp wrote: > Hi, > > attached patch fixes ticket #4759 but I guess it is a bit too hasty to > always abort transcoding if a single frame cannot be written. I guess it > would be better to check for some "exit_on_error" like flag set but > couldn't

[FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-09-16 Thread Tobias Rapp
Hi, attached patch fixes ticket #4759 but I guess it is a bit too hasty to always abort transcoding if a single frame cannot be written. I guess it would be better to check for some "exit_on_error" like flag set but couldn't find out how to achieve that. Any comments would be appreciated.