>On Mon, Dec 26, 2022 at 01:07:51PM +, Wujian(Chin) wrote:
>> The issue has been modified. Please review again, thank you!
>>
>> Signed-off-by: wujian_nanjing
>> ---
>> doc/fftools-common-opts.texi | 11 +++
>> fftools/cmdutils.c | 77
>>
>ffmpeg -h
>segfaults with this patch
My environment test is OK. Details are as follows:
SZV1000266228:/usr1/wujian/build # ffmpeg -h
ffmpeg version N-109445-gcc46f5b Copyright (c) 2000-2022 the FFmpeg developers
built with gcc 7 (GCC)
configuration:
Wujian(Chin) (12022-12-20):
> I think that it's more concise to use code this way.
Concision is not the goal here, maintainability is. Please do not use
gotos.
> I think that it would be better to replace the entire url, so that the code
> implementation is simple.
Then replace the whole
>Marvin Scholz (12022-12-19):
> I agree, but then the docs should probably mention that to not give a
>> false sense of absolute security here. And maybe note that it might
>Indeed, documentation is necessary.
Is it appropriate to describe this document? Please give some suggestions.
Thank
>> @@ -215,13 +249,13 @@ static void prepare_app_arguments(int *argc_ptr, char
>> ***argv_ptr)
>> if (win32_argv_utf8) {
>> *argc_ptr = win32_argc;
>> *argv_ptr = win32_argv_utf8;
>> -return;
>> +goto end;
> We only use goto for error processing.
I
