Re: [FFmpeg-devel] PR new filter gltransition

2017-12-29 Thread Rostislav Pehlivanov 
On 29 December 2017 at 08:24, Paul B Mahol  wrote:

> On 12/29/17, Rostislav Pehlivanov  wrote:
> > On 27 December 2017 at 23:13, Travis Fischer 
> wrote:
> >
> >> Hello,
> >>
> >> This is my first time contributing to ffmpeg, so please go easy on me :)
> >>
> >> I have a git diff here
> >>  which
> add a
> >> new filter to apply a GLSL transition between two video streams.  The
> >> github repo for this patch includes all of the relevant documentation
> and
> >> usage examples.
> >>
> >> (sorry, I'm not sure how to formally define the patch, as I'm used to
> just
> >> submitting PRs on github)
> >>
> >> I created this filter because of my frustration with how difficult and
> >> limited the *transition* possibilities were with current concat filter
> >> chains. Anything aside from basic video cross-fades isn't really
> possible.
> >>
> >> After releasing the filter as a standalone extension and seeing some
> other
> >> devs adopt it, I received a lot of feedback that this functionality
> should
> >> be merged info ffmpeg, so I wanted to get the ball rolling and see what
> >> everyone thinks on this list.
> >>
> >> Thanks!
> >> -- Travis Fischer 
> >> ___
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel@ffmpeg.org
> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >
> > I don't see the point of such a filter. Redundant. We already have a
> > properly implemented OpenCL filter support (and there's a patch to make
> it
> > accept generic kernels). This is a quick hack which requires 2 copies and
> > that's slow and inefficient.
> > Instead, how about a tutorial on how to convert glsl to opencl kernels?
>
> Current OpenCL filters are neither generic nor use framesync.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Which is exactly why I mentioned that in my email. There's a patch which
just needs to be applied.
As for framesync support, the opencl infrastructure is done properly and
init is abstracted enough to be simpler than to use opengl and writing a
filter from scratch.
Not to mention having opengl support in any capacity in lavfi could mess up
any clients using opengl.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] PR new filter gltransition

2017-12-29 Thread Paul B Mahol 
On 12/29/17, Rostislav Pehlivanov  wrote:
> On 27 December 2017 at 23:13, Travis Fischer  wrote:
>
>> Hello,
>>
>> This is my first time contributing to ffmpeg, so please go easy on me :)
>>
>> I have a git diff here
>>  which add a
>> new filter to apply a GLSL transition between two video streams.  The
>> github repo for this patch includes all of the relevant documentation and
>> usage examples.
>>
>> (sorry, I'm not sure how to formally define the patch, as I'm used to just
>> submitting PRs on github)
>>
>> I created this filter because of my frustration with how difficult and
>> limited the *transition* possibilities were with current concat filter
>> chains. Anything aside from basic video cross-fades isn't really possible.
>>
>> After releasing the filter as a standalone extension and seeing some other
>> devs adopt it, I received a lot of feedback that this functionality should
>> be merged info ffmpeg, so I wanted to get the ball rolling and see what
>> everyone thinks on this list.
>>
>> Thanks!
>> -- Travis Fischer 
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
> I don't see the point of such a filter. Redundant. We already have a
> properly implemented OpenCL filter support (and there's a patch to make it
> accept generic kernels). This is a quick hack which requires 2 copies and
> that's slow and inefficient.
> Instead, how about a tutorial on how to convert glsl to opencl kernels?

Current OpenCL filters are neither generic nor use framesync.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] PR new filter gltransition

2017-12-28 Thread Rostislav Pehlivanov 
On 27 December 2017 at 23:13, Travis Fischer  wrote:

> Hello,
>
> This is my first time contributing to ffmpeg, so please go easy on me :)
>
> I have a git diff here
>  which add a
> new filter to apply a GLSL transition between two video streams.  The
> github repo for this patch includes all of the relevant documentation and
> usage examples.
>
> (sorry, I'm not sure how to formally define the patch, as I'm used to just
> submitting PRs on github)
>
> I created this filter because of my frustration with how difficult and
> limited the *transition* possibilities were with current concat filter
> chains. Anything aside from basic video cross-fades isn't really possible.
>
> After releasing the filter as a standalone extension and seeing some other
> devs adopt it, I received a lot of feedback that this functionality should
> be merged info ffmpeg, so I wanted to get the ball rolling and see what
> everyone thinks on this list.
>
> Thanks!
> -- Travis Fischer 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

I don't see the point of such a filter. Redundant. We already have a
properly implemented OpenCL filter support (and there's a patch to make it
accept generic kernels). This is a quick hack which requires 2 copies and
that's slow and inefficient.
Instead, how about a tutorial on how to convert glsl to opencl kernels?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] PR new filter gltransition

2017-12-28 Thread Carl Eugen Hoyos 
2017-12-28 0:13 GMT+01:00 Travis Fischer :

> This is my first time contributing to ffmpeg, so please go easy on me :)
>
> I have a git diff here
> 

The new file needs a license header (please copy it from
another filter) and configure needs to check if the
necessary headers are available.
Commit locally and create a patch with "git format-patch"
and send it as an attachment to this mailing list to get a
review.

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] PR new filter gltransition

2017-12-28 Thread Travis Fischer 
Hello,

This is my first time contributing to ffmpeg, so please go easy on me :)

I have a git diff here
 which add a
new filter to apply a GLSL transition between two video streams.  The
github repo for this patch includes all of the relevant documentation and
usage examples.

(sorry, I'm not sure how to formally define the patch, as I'm used to just
submitting PRs on github)

I created this filter because of my frustration with how difficult and
limited the *transition* possibilities were with current concat filter
chains. Anything aside from basic video cross-fades isn't really possible.

After releasing the filter as a standalone extension and seeing some other
devs adopt it, I received a lot of feedback that this functionality should
be merged info ffmpeg, so I wanted to get the ball rolling and see what
everyone thinks on this list.

Thanks!
-- Travis Fischer 
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel