Re: [FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-04 Thread Peter Cordes
On Wed, Mar 4, 2015 at 9:42 AM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Mar 04, 2015 at 02:24:58PM +0100, Michael Niedermayer wrote: On Wed, Mar 04, 2015 at 02:11:42PM +0100, Michael Niedermayer wrote: On Tue, Mar 03, 2015 at 10:51:01PM -0400, Peter Cordes wrote: [...]

Re: [FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-04 Thread Michael Niedermayer
On Wed, Mar 04, 2015 at 02:19:36PM -0400, Peter Cordes wrote: On Wed, Mar 4, 2015 at 9:42 AM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Mar 04, 2015 at 02:24:58PM +0100, Michael Niedermayer wrote: On Wed, Mar 04, 2015 at 02:11:42PM +0100, Michael Niedermayer wrote: On Tue,

Re: [FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-04 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 10:51:01PM -0400, Peter Cordes wrote: I've made some patches, and am finally getting around to sending them upstream. I'm trying out gmail for dealing with a high-traffic list like this one, instead of my usual mutt. Are the one-line-paragraph long lines it's

Re: [FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-04 Thread Michael Niedermayer
On Wed, Mar 04, 2015 at 02:24:58PM +0100, Michael Niedermayer wrote: On Wed, Mar 04, 2015 at 02:11:42PM +0100, Michael Niedermayer wrote: On Tue, Mar 03, 2015 at 10:51:01PM -0400, Peter Cordes wrote: [...] Anyway, the av_dict change is the one that requires the most review, so I'll make

Re: [FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-04 Thread Michael Niedermayer
On Wed, Mar 04, 2015 at 02:11:42PM +0100, Michael Niedermayer wrote: On Tue, Mar 03, 2015 at 10:51:01PM -0400, Peter Cordes wrote: [...] Anyway, the av_dict change is the one that requires the most review, so I'll make this email focus on that set of changes.

Re: [FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-04 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 10:51:01PM -0400, Peter Cordes wrote: [...] Anyway, the av_dict change is the one that requires the most review, so I'll make this email focus on that set of changes. https://github.com/FFmpeg/FFmpeg/pull/118 pull req #3, patch #1 review -char *ret = out, *end

Re: [FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-04 Thread Michael Niedermayer
On Tue, Mar 03, 2015 at 10:51:01PM -0400, Peter Cordes wrote: I've made some patches, and am finally getting around to sending them upstream. I'm trying out gmail for dealing with a high-traffic list like this one, instead of my usual mutt. Are the one-line-paragraph long lines it's

[FFmpeg-devel] Patch review: av_dict: add support for empty values

2015-03-03 Thread Peter Cordes
I've made some patches, and am finally getting around to sending them upstream. I'm trying out gmail for dealing with a high-traffic list like this one, instead of my usual mutt. Are the one-line-paragraph long lines it's probably going to produce an annoyance for anyone? I didn't notice