Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-16 Thread Martin Vignali
> > You forgot to update color in documentation. > > Patchset OK otherwise. > > Fix doc, and pushed. Thanks Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Paul B Mahol
On 4/15/18, Martin Vignali wrote: >> >> Default white color is good decision ? Better use orange? >> >> Put { in own line like for every function: >> >> void its_me_function() >> {<- have own line >> >> } >> >> Generally follow code style of file. >>

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Martin Vignali
> > Default white color is good decision ? Better use orange? > > Put { in own line like for every function: > > void its_me_function() > {<- have own line > > } > > Generally follow code style of file. > ___ > > New patchs in attach fix

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Paul B Mahol
On 4/15/18, Martin Vignali wrote: > and when there is no silence i get completly empty display + > >> current volume in dB. >> >> > You're right, my previous calc was wrong (doesn't display for level below > -42 db) > > New patchs in attach > > use another calc for the

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-15 Thread Martin Vignali
and when there is no silence i get completly empty display + > current volume in dB. > > You're right, my previous calc was wrong (doesn't display for level below -42 db) New patchs in attach use another calc for the log display : av_clipf(0.21 * log10(max) + 1, 0, 1); for the persistent max

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-14 Thread Paul B Mahol
On 4/14/18, Martin Vignali wrote: >> >> Please use short name for options, max 2 characters. >> >> The log scale shows nothing even thought there is no silence. Perhaps >> use ceil()? >> > Doesn't understand this part. > Do you mean, you think the log scale display

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-14 Thread Martin Vignali
> > Please use short name for options, max 2 characters. > > The log scale shows nothing even thought there is no silence. Perhaps > use ceil()? > Doesn't understand this part. Do you mean, you think the log scale display option is not a good idea ? Or doesn't work in some case ? In my test, the

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-14 Thread Paul B Mahol
On 4/11/18, Martin Vignali wrote: > Hello, > > Thanks for the comments. > > New patchs in attach : > > 001 : Add display_scale volume > Change since prev patch : > - use enum for the value > - move the max_draw calc part to an inline func (avoid code duplication). > >

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-11 Thread Martin Vignali
Hello, Thanks for the comments. New patchs in attach : 001 : Add display_scale volume Change since prev patch : - use enum for the value - move the max_draw calc part to an inline func (avoid code duplication). 002 : Add Persistent max display Change since prev patch - Use only one param

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-10 Thread Michael Niedermayer
On Sat, Mar 31, 2018 at 04:21:36PM +0200, Martin Vignali wrote: > Hello, > > In attach new patchs for showvolume filter > > 001 : Move the clear picture part to a new func, and use it if fade option > == 0. > (no need to calculate it in float) > > 002/003 : Move "height" condition for draw

Re: [FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-04-10 Thread Martin Vignali
2018-03-31 16:21 GMT+02:00 Martin Vignali : > Hello, > > In attach new patchs for showvolume filter > > 001 : Move the clear picture part to a new func, and use it if fade option > == 0. > (no need to calculate it in float) > > 002/003 : Move "height" condition for draw

[FFmpeg-devel] avfilter/showvolume : add new options and minor clean

2018-03-31 Thread Martin Vignali
Hello, In attach new patchs for showvolume filter 001 : Move the clear picture part to a new func, and use it if fade option == 0. (no need to calculate it in float) 002/003 : Move "height" condition for draw volume at the start of the loop and indent 004 : add a new option for choosing the