Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-13 Thread Martin Vignali
> > Tested on linux/mingw 32/64 x86 and linux mips/arm > > > > Thanks for comments and testing Pushed Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-12 Thread Michael Niedermayer
On Mon, Dec 11, 2017 at 11:28:53AM +0100, Martin Vignali wrote: > > > > It doesn't run (the test is skipped) on 32-bit VS 2017 with command: > > configure --enable-gpl --toolchain=msvc && make fate-rsync > > SAMPLES=../fate-suite && make fate SAMPLES=../fate-suite > > > > With exactly the same

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Mateusz
W dniu 11.12.2017 o 11:28, Martin Vignali pisze: >> >> It doesn't run (the test is skipped) on 32-bit VS 2017 with command: >> configure --enable-gpl --toolchain=msvc && make fate-rsync >> SAMPLES=../fate-suite && make fate SAMPLES=../fate-suite >> >> With exactly the same command it runs on

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Martin Vignali
> > It doesn't run (the test is skipped) on 32-bit VS 2017 with command: > configure --enable-gpl --toolchain=msvc && make fate-rsync > SAMPLES=../fate-suite && make fate SAMPLES=../fate-suite > > With exactly the same command it runs on 64-bit VS 2017. > With similar command line (without

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Mateusz
W dniu 11.12.2017 o 11:00, Martin Vignali pisze: > 2017-12-11 10:49 GMT+01:00 Mateusz : > >> W dniu 11.12.2017 o 00:51, Mateusz pisze: >>> W dniu 10.12.2017 o 21:13, Martin Vignali pisze: > > For me there is no "src + (width - 1) * step" in >>

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Martin Vignali
2017-12-11 10:49 GMT+01:00 Mateusz : > W dniu 11.12.2017 o 00:51, Mateusz pisze: > > W dniu 10.12.2017 o 21:13, Martin Vignali pisze: > >>> > >>> For me there is no "src + (width - 1) * step" in > tests/checkasm/vf_hflip.c > >>> > >>> You pass start of the src buffer but

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-11 Thread Mateusz
W dniu 11.12.2017 o 00:51, Mateusz pisze: > W dniu 10.12.2017 o 21:13, Martin Vignali pisze: >>> >>> For me there is no "src + (width - 1) * step" in tests/checkasm/vf_hflip.c >>> >>> You pass start of the src buffer but you should pass end of the buffer. >>> >>> >>> >>> Thanks ! >> >> New patch

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-10 Thread Mateusz
W dniu 10.12.2017 o 21:13, Martin Vignali pisze: >> >> For me there is no "src + (width - 1) * step" in tests/checkasm/vf_hflip.c >> >> You pass start of the src buffer but you should pass end of the buffer. >> >> >> >> Thanks ! > > New patch in attach. Now it is OK in my system (mingw

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-10 Thread Martin Vignali
> > For me there is no "src + (width - 1) * step" in tests/checkasm/vf_hflip.c > > You pass start of the src buffer but you should pass end of the buffer. > > > > Thanks ! New patch in attach. Martin 0001-avfilter-vf_hflip-move-context-func-init-in.patch Description: Binary data

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-10 Thread Mateusz
W dniu 09.12.2017 o 15:46, Martin Vignali pisze: >> >>> Do you test on X86_32 or x86_64 ? >> >> failure occurs on both >> >> >>> Nasm or Yasm ? >> >> NASM version 2.10.09 compiled on Dec 29 2013 >> >> >> >> I try to compile with the same nasm version (on os X, X86_64) > using

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-09 Thread Martin Vignali
> > > Do you test on X86_32 or x86_64 ? > > failure occurs on both > > > > Nasm or Yasm ? > > NASM version 2.10.09 compiled on Dec 29 2013 > > > > I try to compile with the same nasm version (on os X, X86_64) using --x86asmexe=nasm_exe_path2.10rc9 in the configure And the checkasm also pass

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-08 Thread Michael Niedermayer
On Fri, Dec 08, 2017 at 06:05:27PM +0100, Martin Vignali wrote: > > > > issue still happens with both reverted > > > > checkasm: using random seed 1616253308 > > SSSE3: > >hflip_byte_ssse3 (vf_hflip.c:63) > > - vf_hflip.hflip_byte [FAILED] > >hflip_short_ssse3 (vf_hflip.c:63) > > -

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-08 Thread Martin Vignali
> > issue still happens with both reverted > > checkasm: using random seed 1616253308 > SSSE3: >hflip_byte_ssse3 (vf_hflip.c:63) > - vf_hflip.hflip_byte [FAILED] >hflip_short_ssse3 (vf_hflip.c:63) > - vf_hflip.hflip_short [FAILED] > checkasm: 2 of 2 tests have failed > > Thanks for

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-08 Thread Michael Niedermayer
On Fri, Dec 08, 2017 at 12:34:07PM +0100, Martin Vignali wrote: > > > > maybe iam missing something > > but my box doesnt like your test: > > > > > > Is there a link to these recent commit : > https://github.com/FFmpeg/FFmpeg/commit/dc33fe1d0080e932faa9fe3c7fb4850dfde161a8 >

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-08 Thread Martin Vignali
> > maybe iam missing something > but my box doesnt like your test: > > > Is there a link to these recent commit : https://github.com/FFmpeg/FFmpeg/commit/dc33fe1d0080e932faa9fe3c7fb4850dfde161a8 https://github.com/FFmpeg/FFmpeg/commit/f2aa0ce5a059cf02ee4cbd68111dd2ad622edc85 ? Martin

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-08 Thread Michael Niedermayer
On Thu, Dec 07, 2017 at 09:40:41PM +0100, Martin Vignali wrote: > Hello, > > Patch in attach add a checkasm test for vf_hflip (byte and short) > > Martin > hflip.h|1 + > vf_hflip.c | 14 ++ > 2 files changed, 11 insertions(+), 4 deletions(-) >

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-07 Thread Paul B Mahol
On 12/7/17, Martin Vignali wrote: > Hello, > > Patch in attach add a checkasm test for vf_hflip (byte and short) > > Martin > probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-07 Thread Martin Vignali
Hello, Patch in attach add a checkasm test for vf_hflip (byte and short) Martin 0001-avfilter-vf_hflip-move-context-func-init-in.patch Description: Binary data 0002-checkasm-vf_hflip-add-test-for-vf_hflip-byte-and-sho.patch Description: Binary data