Re: [FFmpeg-devel] h264: fix RTSP stream decoding

2018-01-03 Thread Michael Niedermayer
On Wed, Jan 03, 2018 at 12:54:03PM +0300, ser...@gavrushkin.com wrote: > > The error code returned by decode_extradata_ps() is inconsistent after this > > its not "if any failed" it is returning an error if the last failed > > Sorry, I don't get how it is supposed to work. I just found the

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

2018-01-03 Thread sergey
> The error code returned by decode_extradata_ps() is inconsistent after this > its not "if any failed" it is returning an error if the last failed Sorry, I don't get how it is supposed to work. I just found the previous implementation and checked which commit broke it. The other possible

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

2017-12-30 Thread Michael Niedermayer
On Sat, Dec 30, 2017 at 12:48:19AM +0300, ser...@gavrushkin.com wrote: > > Please add "Fixes ticket #6422" to the commit message. > > > > And maybe remove "rtsp" from the commit title, the issue > > is reproducible with files. > > Done. > > Please feel free to edit commit title/message as you

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

2017-12-29 Thread ser...@gavrushkin.com
> Please add "Fixes ticket #6422" to the commit message. > > And maybe remove "rtsp" from the commit title, the issue > is reproducible with files. Done. Please feel free to edit commit title/message as you wish for merge. Thank you, Sergey - From

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

2017-12-29 Thread Carl Eugen Hoyos
2017-12-29 18:43 GMT+01:00 ser...@gavrushkin.com : > From e90ef7b56d4147ff6555468f0154321b55596846 Mon Sep 17 00:00:00 2001 > From: Sergey Gavrushkin > Date: Fri, 29 Dec 2017 20:03:50 +0300 > Subject: [PATCH] h264: fix RTSP stream decoding > > It is

Re: [FFmpeg-devel] h264: fix RTSP stream decoding

2017-12-29 Thread Tristan Matthews
Hi, On Fri, Dec 29, 2017 at 12:43 PM, ser...@gavrushkin.com wrote: > Hello, > > FFmpeg stop working with the latest model of camera that I work now. I've > investigated it and found that "bad" commit is > 98c97994c5b90bdae02accb155eeceeb5224b8ef. There was additional

[FFmpeg-devel] h264: fix RTSP stream decoding

2017-12-29 Thread ser...@gavrushkin.com
Hello, FFmpeg stop working with the latest model of camera that I work now. I've investigated it and found that "bad" commit is 98c97994c5b90bdae02accb155eeceeb5224b8ef. There was additional check for ret value and err_recognition, that was ignored while refactoring to h264_parse.c function.