Re: [FFmpeg-devel] linker error
Le 20 octobre 2022 10:29:47 GMT+03:00, "Helmut K. C. Tessarek" a écrit : >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA512 > >On 2022-10-20 02:48, Nicolas George wrote: >> Possibly. But between a library and a final program, the one who is at >> fault when a non-namespaced symbol conflicts is the library. > >In theory I agree with you. However, libass has been using the same >non-static read_file function for many, many years. > >Cheers, > K. C. > >- -- >regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 >Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944 > >/* > Thou shalt not follow the NULL pointer for chaos and madness > await thee at its end. >*/ >-BEGIN PGP SIGNATURE- > >iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmNQ+OsACgkQvgmFNJ1E >3QAOLQ/9F8d7myiHryjRti5U2+29vx8ExZM79JLM8wuz8U2Ba+EcszHec5FNFFAL >Fs7r9zqTy4CcOO6/mTmnZGXOrCNQDSnCD/Z7mDpTCGyPfjcJ+SVvwvugvazuduig >7PQ7pAj1rOGzcaRvRrY5gvS5WP/g58uxZNtxNp6t2sGfHmdx9RCSz3rDgp01jDzj >5KJSbP8JAz7/jQnlhRMP3ol3nf0AQpbdZKQ9FfBJLKpCEd4C7qLNI9wQ77c5f4F6 >uJiZKFcg8KY4IWTYVVggH7eLqTOeoFCwuCfvut0v5izBFFvY0JILHWqe8HofwHwq >IcffmHA5lI/18w9zG0jgzToA90WiCrAYQbii0RHfm0yqXvpyDlqOvugfN08fMqUd >R9j7s4FR3GZy6DhLvSeI+z9/1sk8XbtKGEZ06riD22NaXIdZkb40hcCeKoUH1iqK >M8ADf90Zt8iVmw56uStVW33j30TsE8CHlTORo1Fjzl7pViyqwuue31Ty5ipHFY7l >JchFRTRIpvPS9rE62LWnE9sDORL4oYZKfPDjgTR7byc8OL2q1Jh/S5wFhW23g+g7 >1yV2/1KIIHtB315sRm9Tk4nLJxsmlGjKC/TIt0l/QNyXIeWC/dRnwQoRqnTVaIk1 >NUtXLIjAZX/xDyyd0nIX4Spx3lIWU6+9u9WngIsXLzObYhOv82g= >=JFAH >-END PGP SIGNATURE- >___ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > Hi, However long libass has been doing this, it is wrong. If anything you are lucky that your setup detects the bug early on, during the build. In other setups, duplicate symbols won't cause a build time errors. This bug will cause a program symbol to be overridden silently and trigger really weird and hard to debug side effects. AFAICT, the question is not how long libass has been doing this. The question is why couldn't you fix your libass instance, and would you need to put a kludge into FFmpeg. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] linker error
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2022-10-20 02:48, Nicolas George wrote: > Possibly. But between a library and a final program, the one who is at > fault when a non-namespaced symbol conflicts is the library. In theory I agree with you. However, libass has been using the same non-static read_file function for many, many years. Cheers, K. C. - -- regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944 /* Thou shalt not follow the NULL pointer for chaos and madness await thee at its end. */ -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmNQ+OsACgkQvgmFNJ1E 3QAOLQ/9F8d7myiHryjRti5U2+29vx8ExZM79JLM8wuz8U2Ba+EcszHec5FNFFAL Fs7r9zqTy4CcOO6/mTmnZGXOrCNQDSnCD/Z7mDpTCGyPfjcJ+SVvwvugvazuduig 7PQ7pAj1rOGzcaRvRrY5gvS5WP/g58uxZNtxNp6t2sGfHmdx9RCSz3rDgp01jDzj 5KJSbP8JAz7/jQnlhRMP3ol3nf0AQpbdZKQ9FfBJLKpCEd4C7qLNI9wQ77c5f4F6 uJiZKFcg8KY4IWTYVVggH7eLqTOeoFCwuCfvut0v5izBFFvY0JILHWqe8HofwHwq IcffmHA5lI/18w9zG0jgzToA90WiCrAYQbii0RHfm0yqXvpyDlqOvugfN08fMqUd R9j7s4FR3GZy6DhLvSeI+z9/1sk8XbtKGEZ06riD22NaXIdZkb40hcCeKoUH1iqK M8ADf90Zt8iVmw56uStVW33j30TsE8CHlTORo1Fjzl7pViyqwuue31Ty5ipHFY7l JchFRTRIpvPS9rE62LWnE9sDORL4oYZKfPDjgTR7byc8OL2q1Jh/S5wFhW23g+g7 1yV2/1KIIHtB315sRm9Tk4nLJxsmlGjKC/TIt0l/QNyXIeWC/dRnwQoRqnTVaIk1 NUtXLIjAZX/xDyyd0nIX4Spx3lIWU6+9u9WngIsXLzObYhOv82g= =JFAH -END PGP SIGNATURE- ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] linker error
Nicolas George: > Helmut K. C. Tessarek (12022-10-20): >> I compile the static ffmpeg binaries for macOS and I have noticed just now >> the following error: >> >> duplicate symbol '_read_file' in: >> fftools/ffmpeg_opt.o >> /Users/Shared/ffmpeg/sw/lib/libass.a(ass.o) >> ld: 1 duplicate symbol for architecture x86_64 >> clang: error: linker command failed with exit code 1 (use -v to see >> invocation >> ) >> make: *** [ffmpeg_g] Error 1 >> >> I believe it has something to do with commit >> 18d6c07267994398f99b2241f577f8e7118af099 >> fftools/ffmpeg_opt: move opening output files into a new file > > Possibly. But between a library and a final program, the one who is at > fault when a non-namespaced symbol conflicts is the library. > > So please report this to libass before considering a mitigation in > FFmpeg. > Someone already did: https://github.com/libass/libass/issues/654 - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] linker error
Helmut K. C. Tessarek (12022-10-20): > I compile the static ffmpeg binaries for macOS and I have noticed just now > the following error: > > duplicate symbol '_read_file' in: > fftools/ffmpeg_opt.o > /Users/Shared/ffmpeg/sw/lib/libass.a(ass.o) > ld: 1 duplicate symbol for architecture x86_64 > clang: error: linker command failed with exit code 1 (use -v to see invocation > ) > make: *** [ffmpeg_g] Error 1 > > I believe it has something to do with commit > 18d6c07267994398f99b2241f577f8e7118af099 > fftools/ffmpeg_opt: move opening output files into a new file Possibly. But between a library and a final program, the one who is at fault when a non-namespaced symbol conflicts is the library. So please report this to libass before considering a mitigation in FFmpeg. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] linker error
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I compile the static ffmpeg binaries for macOS and I have noticed just now the following error: duplicate symbol '_read_file' in: fftools/ffmpeg_opt.o /Users/Shared/ffmpeg/sw/lib/libass.a(ass.o) ld: 1 duplicate symbol for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation ) make: *** [ffmpeg_g] Error 1 I believe it has something to do with commit 18d6c07267994398f99b2241f577f8e7118af099 fftools/ffmpeg_opt: move opening output files into a new file Cheers, K. C. - -- regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944 /* Thou shalt not follow the NULL pointer for chaos and madness await thee at its end. */ -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmNQz30ACgkQvgmFNJ1E 3QBXaQ//cihF3S1R5ruPOgOr7eR+sCdo1uoJEncezKJmoF/3IrsEgB05YHiU4nSz H9Qwm1eE8QNDBoYZNZ9gc/bRB7S4u+kUPKAQiE3ZyfYteK2Ez/zy9v/OCXX639pv cuCinQGmIcBAMnHo9Ue3v+E2T89x/fzGyew+3jbfkiG9Gl2aTV/u1k+x/IRzfRCE HuooGGaZUpQhQ0us46CfEHUjHte3QWCDUxKy9tkowVVFgHSyBZMcWfJb7VyN9rSJ CDh0uImRkJ6tR5NtpcpDEG+AJ5HK+olMEaZHEZ8WrlJOrC6AGK1d5N/tGaRfIxiO 7h9K9Disu/HEoGPcA0ULGlkN1axCLPJL0mEKRJVQBEe9Nh7OGFceA3uf/2a0TaBU bevCijy0gNHJi9BNPjK8+vvIgMhsfbkCqmnOKqnntHhUEyEfgm5CT7oBwC8DNZFO aXempSZAqUnCECv/Ry8GU66C/x97FQgvHTYFMrb5gfdAk7mSMu5vge0hkzqM IC7b3MNzSkjEOj4/cZCpzayZjqf2PJ3OIzaZ2na8jT7x7gm4neY9GvIzyF72xoka 4woquOWq3n4F2KpFK4Y5wBxlJYVd1slf7jf5A+r5MVNl+pfiJ2UfVGbgcBdUgH/J JnHAjO+nCQ8NAJGZ/jgRL3vy6BoG03u3WmfdjVqzUMBFuwvxEHE= =CZog -END PGP SIGNATURE- ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".