Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-02-01 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Wednesday, February 1, 2017 3:53 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] mov: support for mu

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-02-01 Thread Michael Niedermayer
On Tue, Jan 31, 2017 at 06:20:24PM +, Eran Kornblau wrote: > > On Tue, Jan 31, 2017 at 06:28:16PM +0100, Michael Niedermayer wrote: > > > On Mon, Jan 30, 2017 at 10:51:00AM -0800, Sasi Inguva wrote: > > > > patch looks good to me. > > > > > > applied > > > > maybe i asked already but it seems

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-31 Thread Eran Kornblau
> On Tue, Jan 31, 2017 at 06:28:16PM +0100, Michael Niedermayer wrote: > > On Mon, Jan 30, 2017 at 10:51:00AM -0800, Sasi Inguva wrote: > > > patch looks good to me. > > > > applied > > maybe i asked already but it seems the Author field of your commits is > inconsistet in git > > some say: > A

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-31 Thread Michael Niedermayer
On Tue, Jan 31, 2017 at 06:28:16PM +0100, Michael Niedermayer wrote: > On Mon, Jan 30, 2017 at 10:51:00AM -0800, Sasi Inguva wrote: > > patch looks good to me. > > applied maybe i asked already but it seems the Author field of your commits is inconsistet in git some say: Author: erankor some s

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-31 Thread Michael Niedermayer
On Mon, Jan 30, 2017 at 10:51:00AM -0800, Sasi Inguva wrote: > patch looks good to me. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Soc

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Sasi Inguva
> > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > Behalf Of Sasi Inguva > > > > Sent: Wednesday, January 18, 2017 3:30 AM > > > > To: FFmpeg development discussions and patches < > ffmpeg-devel@ffmpeg.org> > > > >

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Michael Niedermayer
; > > Sent: Wednesday, January 18, 2017 3:30 AM > > > To: FFmpeg development discussions and patches > > > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and cenc > > > decryption > > > > > > Can you add a fate test ? Rest looks

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Michael Niedermayer
sions and patches > > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and cenc > > decryption > > > > Can you add a fate test ? Rest looks fine to me. > > > Attached: > 1. Fate test > 2. The original patch > 3. Sample file - needs to be uplo

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Eran Kornblau
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sasi > Inguva > Sent: Wednesday, January 18, 2017 3:30 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-17 Thread Sasi Inguva
pkt->size); > if (ret) { > return ret; > } > @@ -6248,7 +6334,7 @@ static int mov_seek_stream(AVFormatContext *s, > AVStream *st, int64_t timestamp, > sample = 0; > if (sample < 0) /* not sure what to do */ >

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-12 Thread Eran Kornblau
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sasi > Inguva > Sent: Friday, January 6, 2017 8:25 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-05 Thread Sasi Inguva
I agree . #4 makes the most sense. On Thu, Jan 5, 2017 at 12:38 PM, Eran Kornblau wrote: > Hi all, > > We found today that this change: > https://github.com/FFmpeg/FFmpeg/commit/ca6cae73db207f17a0d5507609de12 > 842d8f0ca3 > can break the decryption of MP4s encrypted with common encryption. > > I

[FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-05 Thread Eran Kornblau
Hi all, We found today that this change: https://github.com/FFmpeg/FFmpeg/commit/ca6cae73db207f17a0d5507609de12842d8f0ca3 can break the decryption of MP4s encrypted with common encryption. I would like to submit a patch for that, but wanted to consult first about the best approach. The problem