Re: [FFmpeg-devel] [PATCH] libavformat/rtsp.c: Avoids duplicated slashes in the RTSP URL Signed-off-by: Frederic Pillonel

2019-01-24 Thread Michael Niedermayer
On Wed, Jan 23, 2019 at 08:11:48AM +, f...@gmx.ch wrote: > From: Frederic Pillonel > > --- > libavformat/rtsp.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index ceb770a..3cc9012f 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-24 Thread Michael Niedermayer
On Thu, Jan 24, 2019 at 06:08:57PM -0300, James Almer wrote: > On 1/24/2019 5:53 PM, Rostislav Pehlivanov wrote: > > On Thu, 24 Jan 2019 at 20:38, Marton Balint wrote: > > > >> Signed-off-by: Marton Balint > >> --- > >> doc/APIchanges | 3 +++ > >> libavutil/attributes.h | 8 >

[FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-24 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/attributes.h | 8 libavutil/version.h| 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index a39a3ff2ba..38b5b980a6 100644 --- a/doc/APIchanges +++

[FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-01-24 Thread Marton Balint
discard_pid can be quite expensive, so let's cache it and recalculate it on every packet start. ffmpeg -y -i samples/MPEG-VOB/sdtv/RAI.ts -c copy -map 0:v:0 -map 0:a:0 -f mpegts /dev/null Before: 1685 decicycles in handle_packet, 523483 runs,805 skips After: 883 decicycles in

Re: [FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-24 Thread Derek Buitenhuis
On 24/01/2019 20:53, Rostislav Pehlivanov wrote: > NAK, NAK, NAK. Seconded. Please, please, no. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/5] lavc/qsvdec: add function ff_qsv_map_picstruct()

2019-01-24 Thread Rogozhkin, Dmitry V
On Mon, 2019-01-21 at 20:41 +0800, Zhong Li wrote: > Signed-off-by: Zhong Li > --- >  libavcodec/qsv.c  | 18 ++ >  libavcodec/qsv_internal.h |  2 ++ >  2 files changed, 20 insertions(+) > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > index bb0d795..224bc00 100644 >

Re: [FFmpeg-devel] [PATCH 4/5] lavc/qsvdec: Add mjpeg decoder support

2019-01-24 Thread Rogozhkin, Dmitry V
On Mon, 2019-01-21 at 20:41 +0800, Zhong Li wrote: > Signed-off-by: Zhong Li > --- >  Changelog |  1 + >  configure |  1 + >  libavcodec/Makefile   |  1 + >  libavcodec/allcodecs.c|  1 + >  libavcodec/qsvdec_other.c | 28 +++- >  5

Re: [FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-24 Thread Marton Balint
On Thu, 24 Jan 2019, James Almer wrote: On 1/24/2019 5:53 PM, Rostislav Pehlivanov wrote: On Thu, 24 Jan 2019 at 20:38, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/attributes.h | 8 libavutil/version.h| 2 +- 3 files

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: remove duplicate function

2019-01-24 Thread Michael Niedermayer
On Thu, Jan 24, 2019 at 10:23:33PM +0100, Marton Balint wrote: > > > On Sun, 20 Jan 2019, Michael Niedermayer wrote: > > >On Sun, Jan 20, 2019 at 07:35:18PM +0100, Marton Balint wrote: > >> > >> > >>On Sun, 20 Jan 2019, Michael Niedermayer wrote: > >> > >>>On Sat, Jan 19, 2019 at 11:48:39PM

[FFmpeg-devel] [PATCH 3/3] avformat/mpegts: use av_unlikely for detecting unknown streams

2019-01-24 Thread Marton Balint
Strangely the previous commit caused a slowdown in overall performance and this fixes it. I used gcc 7.3.1. Does anybody else see this? time ffprobe -show_packets samples/ffmpeg-bugs/trac/ticket6132/Samsung_HDR_-_Chasing_the_Light.ts > /dev/null Before: real0m2,010s user0m1,413s sys

Re: [FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-24 Thread Rostislav Pehlivanov
On Thu, 24 Jan 2019 at 20:38, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > libavutil/attributes.h | 8 > libavutil/version.h| 2 +- > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: remove duplicate function

2019-01-24 Thread Marton Balint
On Sun, 20 Jan 2019, Michael Niedermayer wrote: On Sun, Jan 20, 2019 at 07:35:18PM +0100, Marton Balint wrote: On Sun, 20 Jan 2019, Michael Niedermayer wrote: On Sat, Jan 19, 2019 at 11:48:39PM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- libavcodec/motion_est.c

Re: [FFmpeg-devel] [PATCH 2/5] lavc/qsvdec: Replace current parser with MFXVideoDECODE_DecodeHeader()

2019-01-24 Thread Rogozhkin, Dmitry V
On Thu, 2019-01-24 at 21:43 +, Rogozhkin, Dmitry V wrote: > On Mon, 2019-01-21 at 20:41 +0800, Zhong Li wrote: > > Using MSDK parser can improve qsv decoder pass rate in some cases > > (E.g: > > sps declares a wrong level_idc, smaller than it should be). > > And it is necessary for adding new

[FFmpeg-devel] [PATCH] vf_showinfo: Fix timecode display

2019-01-24 Thread Kieran Kunhya
$subj - Indexing is wrong, off by one Kieran 0001-vf_showinfo-Fix-timecode-display.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-24 Thread James Almer
On 1/24/2019 5:53 PM, Rostislav Pehlivanov wrote: > On Thu, 24 Jan 2019 at 20:38, Marton Balint wrote: > >> Signed-off-by: Marton Balint >> --- >> doc/APIchanges | 3 +++ >> libavutil/attributes.h | 8 >> libavutil/version.h| 2 +- >> 3 files changed, 12 insertions(+), 1

Re: [FFmpeg-devel] [PATCH 2/5] lavc/qsvdec: Replace current parser with MFXVideoDECODE_DecodeHeader()

2019-01-24 Thread Rogozhkin, Dmitry V
On Mon, 2019-01-21 at 20:41 +0800, Zhong Li wrote: > Using MSDK parser can improve qsv decoder pass rate in some cases > (E.g: > sps declares a wrong level_idc, smaller than it should be). > And it is necessary for adding new qsv decoders such as MJPEG and VP9 > since current parser can't provide

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mpegts: use av_unlikely for detecting unknown streams

2019-01-24 Thread Carl Eugen Hoyos
2019-01-24 21:38 GMT+01:00, Marton Balint : > Strangely the previous commit caused a slowdown in overall performance > and this fixes it. I used gcc 7.3.1. Does anybody else see this? No, but since this command exists nearly immediately for me I see a 5% deviation even without your patch. Carl

Re: [FFmpeg-devel] [PATCH v2 2/3] lavc/libxavs2: use upper layer qp parameters first

2019-01-24 Thread Liu Steven
> 在 2019年1月24日,下午11:16,hwrenx 写道: > > Signed-off-by: hwrenx > --- > libavcodec/libxavs2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c > index 2d29427..d5c4557 100644 > --- a/libavcodec/libxavs2.c > +++

Re: [FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-24 Thread Hendrik Leppkes
On Thu, Jan 24, 2019 at 11:06 PM Michael Niedermayer wrote: > > On Thu, Jan 24, 2019 at 06:08:57PM -0300, James Almer wrote: > > On 1/24/2019 5:53 PM, Rostislav Pehlivanov wrote: > > > On Thu, 24 Jan 2019 at 20:38, Marton Balint wrote: > > > > > >> Signed-off-by: Marton Balint > > >> --- > > >>

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: cache PID discard values

2019-01-24 Thread Carl Eugen Hoyos
2019-01-24 21:38 GMT+01:00, Marton Balint : > discard_pid can be quite expensive, so let's cache it and recalculate it on > every packet start. > > ffmpeg -y -i samples/MPEG-VOB/sdtv/RAI.ts -c copy -map 0:v:0 -map 0:a:0 > -f mpegts /dev/null I can reproduce a 30% overall speedup for this command

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mpegts: use av_unlikely for detecting unknown streams

2019-01-24 Thread Marton Balint
On Fri, 25 Jan 2019, Carl Eugen Hoyos wrote: 2019-01-24 21:38 GMT+01:00, Marton Balint : Strangely the previous commit caused a slowdown in overall performance and this fixes it. I used gcc 7.3.1. Does anybody else see this? No, but since this command exists nearly immediately for me I see

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mpegts: use av_unlikely for detecting unknown streams

2019-01-24 Thread Carl Eugen Hoyos
2019-01-25 2:03 GMT+01:00, Marton Balint : > > On Fri, 25 Jan 2019, Carl Eugen Hoyos wrote: > >> 2019-01-24 21:38 GMT+01:00, Marton Balint : >>> Strangely the previous commit caused a slowdown in overall performance >>> and this fixes it. I used gcc 7.3.1. Does anybody else see this? >> >> No, but

Re: [FFmpeg-devel] [PATCH] avfilter/acrossfade: allow skipping fade on inputs

2019-01-24 Thread Gyan
On 23-01-2019 11:49 PM, Paul B Mahol wrote: On 1/23/19, Gyan wrote: On 23-01-2019 07:40 PM, Paul B Mahol wrote: On 1/23/19, Gyan wrote: On 23-01-2019 03:00 PM, Paul B Mahol wrote: On 1/23/19, Gyan wrote: Why? afade needs change too. If a user doesn't want to apply fade, then they can

Re: [FFmpeg-devel] [PATCH]lavf/subviewerdec: Skip leading BOM

2019-01-24 Thread Carl Eugen Hoyos
2019-01-24 0:29 GMT+01:00, Carl Eugen Hoyos : > Attached patch fixes ticket #7661 for me. > +if (avio_rb24(s->pb) != MKBETAG(0, 0xef, 0xbb, 0xbf)) Changed locally to: +if (avio_rb24(s->pb) != 0xefbbbf) Carl Eugen ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] support rtmp_listen with rtmps

2019-01-24 Thread Chen Fisher
Signed-off-by: Chen Fisher --- libavformat/rtmpproto.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index b741e421af..82b3688658 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -129,6

[FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Paweł Wegner
Signed-off-by: Paweł Wegner --- libavfilter/af_atempo.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index bfdad7d76b..1245eae8c1 100644 --- a/libavfilter/af_atempo.c +++ b/libavfilter/af_atempo.c @@ -147,6 +147,8 @@ typedef

Re: [FFmpeg-devel] [PATCH 1/1] libavdevice/v4l2enc: support additional v4l2 output formats

2019-01-24 Thread Carl Eugen Hoyos
2019-01-24 3:55 GMT+01:00, james.hillia...@gmail.com : > From: James Hilliard > > Signed-off-by: James Hilliard > --- > libavdevice/v4l2enc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavdevice/v4l2enc.c b/libavdevice/v4l2enc.c > index faf6e07..f778208

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/movenc: Mention video_track_timescale as option to fix the timescale.

2019-01-24 Thread Carl Eugen Hoyos
2019-01-24 14:13 GMT+01:00, Gyan : > Or better, a viable timescale ceiling can be printed. Yes, this is exactly the reason why nothing was committed for several years. (Although printing the current scale is a very good idea that wasn't suggested so far.) > 3) If the offending track is audio,

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/movenc: Mention video_track_timescale as option to fix the timescale.

2019-01-24 Thread Gyan
On 24-01-2019 05:25 PM, Carl Eugen Hoyos wrote: ffmpeg | branch: master | Carl Eugen Hoyos | Thu Jan 24 12:52:50 2019 +0100| [406f8d9c9a10267299d6eefd0672bd4f4c9342b4] | committer: Carl Eugen Hoyos lavf/movenc: Mention video_track_timescale as option to fix the timescale. Smarter

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/movenc: Mention video_track_timescale as option to fix the timescale.

2019-01-24 Thread Gyan
On 24-01-2019 07:05 PM, Carl Eugen Hoyos wrote: 2019-01-24 14:13 GMT+01:00, Gyan : Or better, a viable timescale ceiling can be printed. Yes, this is exactly the reason why nothing was committed for several years. (Although printing the current scale is a very good idea that wasn't suggested

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/movenc: Mention video_track_timescale as option to fix the timescale.

2019-01-24 Thread Carl Eugen Hoyos
2019-01-24 15:17 GMT+01:00, Gyan : [...] >>> 3) If the offending track is audio, then nothing can be done, the >>> message should reflect that (and the muxer should quit). >> >> Please provide an example. > > I don't follow. The error msg only suggests to modify the timescale of > video tracks.

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Paweł Wegner
On Thu, Jan 24, 2019 at 3:43 PM Pavel Koshevoy wrote: > On Thu, Jan 24, 2019 at 5:49 AM Paweł Wegner > wrote: > > > > Signed-off-by: Paweł Wegner > > --- > > libavfilter/af_atempo.c | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/libavfilter/af_atempo.c

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Gyan
On 24-01-2019 08:18 PM, Paweł Wegner wrote: This fixes seeking when I have video playback sped up in ffplay like this: ffplay -vf "setpts=0.5 * PTS" -af "atempo=2" input The better way to run this is ffplay -vf "setpts=0.5 * (PTS - STARTPTS)" -af "atempo=2" input Gyan

[FFmpeg-devel] [PATCH v2 3/3] lavc/libdavs2: fix parameter setting error

2019-01-24 Thread hwrenx
Signed-off-by: hwrenx --- libavcodec/libdavs2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c index cf75656..0808721 100644 --- a/libavcodec/libdavs2.c +++ b/libavcodec/libdavs2.c @@ -45,9 +45,9 @@ static av_cold int

[FFmpeg-devel] [PATCH v2 2/3] lavc/libxavs2: use upper layer qp parameters first

2019-01-24 Thread hwrenx
Signed-off-by: hwrenx --- libavcodec/libxavs2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 2d29427..d5c4557 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -109,8 +109,8 @@ static av_cold int

[FFmpeg-devel] [PATCH v2 1/3] lavc/libxavs2: remove unused context parameter

2019-01-24 Thread hwrenx
Signed-off-by: hwrenx --- libavcodec/libxavs2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 52c50a1..2d29427 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -46,7 +46,6 @@ typedef struct XAVS2EContext { int min_qp;

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Paul B Mahol
On 1/24/19, Paweł Wegner wrote: > Signed-off-by: Paweł Wegner > --- > libavfilter/af_atempo.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index bfdad7d76b..1245eae8c1 100644 > --- a/libavfilter/af_atempo.c > +++

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Pavel Koshevoy
On Thu, Jan 24, 2019 at 5:49 AM Paweł Wegner wrote: > > Signed-off-by: Paweł Wegner > --- > libavfilter/af_atempo.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index bfdad7d76b..1245eae8c1 100644 > ---

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/movenc: Mention video_track_timescale as option to fix the timescale.

2019-01-24 Thread Gyan
On 24-01-2019 08:11 PM, Carl Eugen Hoyos wrote: So you did test a command line that triggered the error message for audio? Not till now :) Ok, mostly not a problem (in terms of raising attention via the log), But exit code is shown as 0. And your modified message *is* shown for crafted

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Pavel Koshevoy
On Thu, Jan 24, 2019 at 8:01 AM Gyan wrote: > > > > On 24-01-2019 08:18 PM, Paweł Wegner wrote: > > > > This fixes seeking when I have video playback sped up in ffplay like this: > > ffplay -vf "setpts=0.5 * PTS" -af "atempo=2" input > > The better way to run this is > > ffplay -vf

Re: [FFmpeg-devel] [PATCH 6/7] cbs: Add a function to make content of a unit writable

2019-01-24 Thread Andreas Rheinhardt
From a macro point of view, I like your general approach using tables. It really simplifies everything a lot. (Rereading my old approach I don't know why I totally forgot that there is a generic way to know the size of the internal buffers (namely size of the AVBufferRefs). Not thinking of this,

Re: [FFmpeg-devel] [PATCH 5/7] cbs_h265: Use table-based alloc/free

2019-01-24 Thread Andreas Rheinhardt
Mark Thompson: > +CBS_UNIT_TYPE_POD(H264_NAL_AUD, H265RawAUD), Typo. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/acrossfade: allow skipping fade on inputs

2019-01-24 Thread Gyan
On 24-01-2019 02:22 PM, Gyan wrote: On 23-01-2019 11:49 PM, Paul B Mahol wrote: On 1/23/19, Gyan wrote: On 23-01-2019 07:40 PM, Paul B Mahol wrote: On 1/23/19, Gyan wrote: On 23-01-2019 03:00 PM, Paul B Mahol wrote: On 1/23/19, Gyan wrote: Why? afade needs change too. If a user

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Paweł Wegner
On Thu, Jan 24, 2019 at 4:01 PM Gyan wrote: > > > On 24-01-2019 08:18 PM, Paweł Wegner wrote: > > > > This fixes seeking when I have video playback sped up in ffplay like > this: > > ffplay -vf "setpts=0.5 * PTS" -af "atempo=2" input > > The better way to run this is > > ffplay -vf

[FFmpeg-devel] [CLT2019] FFmpeg at Chemnitzer Linux-Tage

2019-01-24 Thread Thilo Borgmann
Hi, FFmpeg has been accepted for CLT 2019 in Chemnitz, Germany! This "Chemnitzer Linux Tage" will take place on 16th and 17th of March. You can find more details on their homepage: https://chemnitzer.linux-tage.de/2019/en/ We will man a booth with our staff and are happily waiting for our users