Re: [FFmpeg-devel] [PATCH] Add NVENC encoder

2014-11-28 Thread Philip Langdale
On Wed, 26 Nov 2014 11:21:26 +0100 Timo Rothenpieler t...@rothenpieler.org wrote: This patch adds support for encoding with Nvidia NVENC on Windows and Linux. I'm not sure if this needs to be flagged as nonfree. As far as I'm aware, it should not affect how the resulting binaries can be

Re: [FFmpeg-devel] [PATCH] Add NVENC encoder

2014-11-28 Thread Philip Langdale
On Sat, 29 Nov 2014 00:51:21 +0100 Michael Niedermayer michae...@gmx.at wrote: For what it's worth, some engineers at Nvidia are also working on an nvenc implementation for ffmpeg. That initial work is here: https://github.com/agathah/ffmpeg_libnvenc whats the difference in

Re: [FFmpeg-devel] [PATCH] Add NVENC encoder

2014-11-29 Thread Philip Langdale
On 29 Nov 2014 03:13, Timo Rothenpieler t...@rothenpieler.org wrote: I've spent a lot more time looking at the nvidia patch, but from a quick look through Timo's version, I'd say the following: * Timo's is more concise but not as feature complete. * nvidia one has windows support

Re: [FFmpeg-devel] [PATCH] Add NVENC encoder

2014-11-29 Thread Philip Langdale
On Sat, 29 Nov 2014 19:00:02 +0100 Timo Rothenpieler t...@rothenpieler.org wrote: does supporting these additional features need the extra complexity that the nvidia version has ? or could these features be added into your version while keeping its simplicity ? (note do not copy any code

Re: [FFmpeg-devel] [PATCH] Add NVENC encoder

2014-11-29 Thread Philip Langdale
On Sun, 30 Nov 2014 00:04:37 +0100 Timo Rothenpieler t...@rothenpieler.org wrote: Did some refactoring, now using a dynamic ring-buffer for both the surface lists as well as the timestamp list. There should be no thread safety problem anymore, as there are no non-constant static global

Re: [FFmpeg-devel] [PATCH] Add NVENC encoder

2014-11-29 Thread Philip Langdale
On Sat, 29 Nov 2014 15:52:00 -0800 Philip Langdale phil...@overt.org wrote: On Sun, 30 Nov 2014 00:04:37 +0100 Timo Rothenpieler t...@rothenpieler.org wrote: Did some refactoring, now using a dynamic ring-buffer for both the surface lists as well as the timestamp list. There should

Re: [FFmpeg-devel] [PATCH] Add NVENC encoder

2014-12-10 Thread Philip Langdale
On 2014-12-10 15:17, Michael Niedermayer wrote: On Sat, Nov 29, 2014 at 10:29:50AM -0800, Philip Langdale wrote: [...] Hopefully, they will respond positively on Monday and will get engaged here, and sort out their licensing so that we can all work on a single implementation. monday passed

Re: [FFmpeg-devel] ffmpeg nvenc

2014-12-17 Thread Philip Langdale
On 2014-12-17 01:34, Agatha Hu wrote: Repost -Original Message- From: Agatha Hu Sent: 2014年12月17日 15:49 To: 'Philip Langdale'; 'ffmpeg-devel@ffmpeg.org' Cc: Abhijit Patait; Eric Young; Jaime Ieong; Andrew Fear; Stephen Warren; Andy Ritger Subject: RE: ffmpeg nvenc Hi Phil, We've

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Philip Langdale
On 2015-01-23 01:54, Timo Rothenpieler wrote: +ctx-encode_config.encodeCodecConfig.h264Config.maxNumRefFrames = avctx-refs; avctx-refs should propably be checked for = 0. I'm not sure if maxNumRefFrames means the exact same thing as avctx-refs, but the comment in the nvenc header isn't

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
On Sat, 24 Jan 2015 20:28:30 +0100 Michael Niedermayer michae...@gmx.at wrote: On Sat, Jan 24, 2015 at 10:11:21AM -0800, Philip Langdale wrote: On Sat, 24 Jan 2015 13:02:01 +0100 Michael Niedermayer michae...@gmx.at wrote: On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-03 Thread Philip Langdale
:53 -0800 Philip Langdale phil...@overt.org wrote: For reasons we are not privy to, nvidia decided that the nvenc encoder should apply aspect ratio compensation to 'DVD like' content, assuming that the content is not bt.601 compliant, but needs to be bt.601 compliant. In this context, that means

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-16 Thread Philip Langdale
On 2015-01-15 23:48, Nicolas George wrote: Le septidi 27 nivôse, an CCXXIII, Timo Rothenpieler a écrit : +av_reduce(dw, dh, avctx-sample_aspect_ratio.num, avctx-sample_aspect_ratio.den, 4096); +ctx-init_encode_params.darHeight = dw; +ctx-init_encode_params.darWidth =

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-21 Thread Philip Langdale
On Thu, 22 Jan 2015 12:15:44 +0800 Agatha Hu a...@nvidia.com wrote: We will fix the issue in driver, overscan compensation will be applied to input DAR *only* if the DAR is 4:3 or 16:9, otherwise won't unnecessarily modify the aspect ratio for resolutions like 720x480 and 720x576. The fix

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Philip Langdale
On Sat, 17 Jan 2015 19:27:17 + Kieran Kunhya kier...@obe.tv wrote: On 17 January 2015 at 18:14, Nicolas George geo...@nsup.org wrote: Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : On Fri, 16 Jan 2015 22:17:56 +0100 Nicolas George geo...@nsup.org wrote: Ok. I did

[FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Philip Langdale
There is a long sad story behind all this, but it's somewhat ambiguous as to whether DVD content should be treated as 720 pixels wide or 704 pixels, with 16 pixels cut off. If you decide is should be 704 pixels wide, you need to adjust the sample aspect ratio to keep the final display aspect ratio

[FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Philip Langdale
There is a long sad story behind all this, but it's somewhat ambiguous as to whether DVD content should be treated as 720 pixels wide or 704 pixels, with 16 pixels cut off. If you decide is should be 704 pixels wide, you need to adjust the sample aspect ratio to keep the final display aspect ratio

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-27 Thread Philip Langdale
On 2015-01-26 04:28, t...@rothenpieler.org wrote: From: Timo Rothenpieler t...@rothenpieler.org --- libavcodec/nvenc.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 2431c09..2cfc06a 100644 ---

[FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-01-28 Thread Philip Langdale
this compensation mechanism optional in a future release of the nvenc SDK. At that point, we can adapt accordingly. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/nvenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 2cfc06a

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-24 Thread Philip Langdale
On Sat, 24 Jan 2015 13:02:01 +0100 Michael Niedermayer michae...@gmx.at wrote: On Fri, Jan 23, 2015 at 09:41:23PM -0800, Philip Langdale wrote: Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/nvenc.c | 5 + 1 file changed, 5 insertions(+) Applying: nvenc

[FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Philip Langdale
Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/nvenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index c52beb7..e68bbe9 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -614,6 +614,11 @@ static av_cold int

[FFmpeg-devel] [PATCH 4/4] nvenc: Try and do interlaced encoding.

2015-01-05 Thread Philip Langdale
Doesn't work. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/libnvenc.c | 7 +++ libavcodec/libnvenc.h | 3 +++ libavcodec/nvencoder.c | 6 -- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/libavcodec/libnvenc.c b/libavcodec/libnvenc.c index 3c64234

[FFmpeg-devel] [PATCH 2/4] Set bdirect mode

2015-01-05 Thread Philip Langdale
Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/libnvenc.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavcodec/libnvenc.c b/libavcodec/libnvenc.c index 6ba150e..3c64234 100644 --- a/libavcodec/libnvenc.c +++ b/libavcodec/libnvenc.c @@ -208,6 +208,23

[FFmpeg-devel] [PATCH 3/4] Implement b frame support.

2015-01-05 Thread Philip Langdale
, it's a small enough quantity that static allocation and a poor man's circular queue are sufficient. Note that we need to aggressively fetch output frames on every iteration to avoid falling behind - as every b frame will have delayed output. Signed-off-by: Philip Langdale phil...@overt.org

[FFmpeg-devel] [PATCH 0/4] Improvements the nvidia's nvenc implementation

2015-01-05 Thread Philip Langdale
As promised, here are my current stack of improvements over the base implementation. The interlacing one is probably pointless as the hardware doesn't seem to support it, but you'll know better than me. And hopefully you can explain the black magic in the DAR calculation. Philip Langdale (4

[FFmpeg-devel] [PATCH 1/4] Correctly set Display Aspect Ratio in nvenc.

2015-01-05 Thread Philip Langdale
The encoder writes the display aspect ratio into the output frames, which a good player will respect, so let's make sure it's correct. The 1.02 scale factor is black magic, but produces correct results. I don't know what nvenc is doing. Signed-off-by: Philip Langdale phil...@overt.org

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

2015-02-04 Thread Philip Langdale
On Wed, 04 Feb 2015 21:13:57 +0100 Timo Rothenpieler t...@rothenpieler.org wrote: Could I get a proper review on this? I'd like to believe that we have a consensus that, independent of whether we think there's merit in this compensation logic, it shouldn't exist in a single encoder, out

Re: [FFmpeg-devel] [PATCH 1/4] Correctly set Display Aspect Ratio in nvenc.

2015-01-07 Thread Philip Langdale
On Wed, 7 Jan 2015 12:13:25 +0100 Nicolas George geo...@nsup.org wrote: Can you explain the 1024? Anyway, I would suggest to use lavu's rational functions: AVRational dar = av_mul_q(avctx-sample_aspect_ratio, av_make_q(avctx-width, avctx-height));

Re: [FFmpeg-devel] [PATCH 1/4] Correctly set Display Aspect Ratio in nvenc.

2015-01-07 Thread Philip Langdale
On Wed, 7 Jan 2015 10:46:47 -0800 Philip Langdale phil...@overt.org wrote: Honestly, I don't understand what the encoder is doing at this point. The 1.02 seems to be the 'correct' scale factor for a PAL DVD, but is incorrect for anything else. I used 1024 to avoid the floating point problem

Re: [FFmpeg-devel] [PATCH] 3GPP TS 26.245 Timed Text decoder: decode rich formatting in sample modifier boxes

2015-03-17 Thread Philip Langdale
On Tue, 17 Mar 2015 21:12:43 -0700 Wes root...@gmail.com wrote: My cover letter was sent in a separate email, apologies! No need to apologise. That's how git send-email works, and it's to be expected. --phil ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] 3GPP TS 26.245 Timed Text decoder: decode rich formatting in sample modifier boxes

2015-03-17 Thread Philip Langdale
On Tue, 17 Mar 2015 21:09:44 -0700 Wesley Castro root...@gmail.com wrote: Bold, italic, and underlined type will be converted to their equivilent ASS styles when encountered in a text style sample modifier box. Signed-off-by: Wesley Castro root...@gmail.com --- Hi Wesley, Thanks for

Re: [FFmpeg-devel] GSoC Unmentored Project Question

2015-03-12 Thread Philip Langdale
On Thu, 12 Mar 2015 23:17:54 +0100 Nicolas George geo...@nsup.org wrote: Le duodi 22 ventôse, an CCXXIII, Wes a écrit : I'm interested in participating in GSoC this year and the Subtitles project sounds very interesting. However, I noticed this project idea doesn't have a mentor currently,

Re: [FFmpeg-devel] [PATCH] HDMV PGS subtitles-Ticket #2622

2015-03-24 Thread Philip Langdale
On Wed, 25 Mar 2015 00:11:26 +0530 Niklesh Lalwani lalwani1...@gmail.com wrote: Hi Everyone, This is the fix for issue #2622 https://trac.ffmpeg.org/ticket/2622. These changes enables to remux m2ts file so that the new file has playable subtitles. Thanks, Niklesh Lalwani Hi Niklesh,

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Add support for H.265 encoding

2015-03-24 Thread Philip Langdale
On Tue, 24 Mar 2015 09:54:13 +0100 Timo Rothenpieler t...@rothenpieler.org wrote: Yes, I did exactly that in my implementation: https://github.com/BtbN/FFmpeg/commits/nvenc The code i wrote there is completely untested(Except that h264 still works), because i don't have any compatible

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Add support for H.265 encoding

2015-03-25 Thread Philip Langdale
On Wed, 25 Mar 2015 21:52:54 + (UTC) Ali KIZIL aliki...@gmail.com wrote: The update broken the general usage: ./ffmpeg -loglevel info -re -i /root/bunny.mp4 -vcodec nvenc -preset hp -fflags +genpts -vb 24000k -minrate 24000k -maxrate 24000k -bufsize 48000k -muxrate 26000k -cbr 1

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Add support for H.265 encoding

2015-03-26 Thread Philip Langdale
On 2015-03-26 04:30, Ali KIZIL wrote: It works fine now Phil. One more comment: I have a GTX 980. It can encode upto 30-33 fps for 4K 60fps YUV Raw input file using nvenc_h265 avcodec with FFmpeg. First a side, It looked to me like lack of performance of card. However; after I split the

Re: [FFmpeg-devel] Fix Patch for Ticket #2622- Remuxing of hdmv pgs subtitles

2015-03-23 Thread Philip Langdale
Hi Niklesh, On Mon, 23 Mar 2015 12:52:16 +0530 Niklesh Lalwani lalwani1...@gmail.com wrote: Hi everyone, I have fixed the issue #2622 https://trac.ffmpeg.org/ticket/2622 through this pull request https://github.com/FFmpeg/FFmpeg/pull/125. These changes enables to remux m2ts file so that the

[FFmpeg-devel] [PATCH] avcodec/nvenc: Add support for H.265 encoding

2015-03-23 Thread Philip Langdale
without, but such is life. Note that this feature requires the 5.0 SDK or newer to compile. I'm not sure what we gain from supporting the older SDKs, so I'm inclined to make this unconditional and remove the 5 support that currently exists. Signed-off-by: Philip Langdale phil...@overt.org

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fix profile parameter handling

2015-04-01 Thread Philip Langdale
On Thu, 2 Apr 2015 00:04:07 +0200 Timo Rothenpieler t...@rothenpieler.org wrote: It was not possible to set a profile before, the builtin profile parameter does not seem to work propperly. To be compatible with libx264, this overlays it with a local parameter that expects a string, instead

Re: [FFmpeg-devel] [PATCH 2/2] Using dynamic arrays for multiple style records

2015-04-13 Thread Philip Langdale
On 2015-04-13 07:57, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch attempts to use dynamic arrays to support multiple style records. However, I am unable to get proper output with using av_dynamic_array(). It seems I am not using this function properly. Can anyone

Re: [FFmpeg-devel] [PATCH 1/2] Decoding of Bold Italic and Underlined styles for 3GPP timed text subtitles

2015-04-13 Thread Philip Langdale
On 2015-04-13 07:56, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch is a part of my qualification task to implement support for Bold, Italic, and Underlined style records for 3GPP timed text subtitles. I am continuing Wesley's work. This patch supports decoding of no

Re: [FFmpeg-devel] [PATCH] Using struct for StyleRecords and implementing support for large boxes(32 bit) for 3gpp timed text

2015-04-25 Thread Philip Langdale
On Sun, 26 Apr 2015 05:04:07 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sun, Apr 26, 2015 at 08:22:56AM +0530, Niklesh Lalwani wrote: On Sun, Apr 26, 2015 at 6:56 AM, Michael Niedermayer michae...@gmx.at wrote: +struct __attribute__((__packed__)) StyleRecord {

Re: [FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

2015-04-22 Thread Philip Langdale
On 2015-04-22 03:10, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch supports decoding of Bold, Italic, Underlined styles for 3gpp timed text. While the code can be improved upon to make it more clean and well structured, this works for now, even for multiple style

Re: [FFmpeg-devel] Anybody already working on VDPAU / HEVC support?

2015-05-16 Thread Philip Langdale
On Thu, 30 Apr 2015 21:24:06 +0200 Christian König christian.koe...@amd.com wrote: I already talked to José Hiram Soltren from NVidia and it unfortunately doesn't look like they will do it this time. I'm not aware of anyone else; given the hardware requirements, I wouldn't be surprised

Re: [FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-17 Thread Philip Langdale
On Sun, 17 May 2015 21:36:42 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Hi all, This patch fixes some movtext crashes caused due to incorrect 'while' loop condition. I will post several other patches to improve upon the code and null

Re: [FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-17 Thread Philip Langdale
On Sun, 17 May 2015 09:56:10 -0700 Philip Langdale phil...@overt.org wrote: tsmb += 4; tsmb_type = AV_RB32(tsmb); @@ -176,6 +177,7 @@ static int mov_text_decode_frame(AVCodecContext *avctx, av_freep(style_end); av_freep(style_flags

Re: [FFmpeg-devel] [PATCH 1/2] Support for large boxes(32 bit) for 3gpp timed text

2015-05-17 Thread Philip Langdale
On Mon, 27 Apr 2015 04:53:26 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-18 Thread Philip Langdale
On Tue, 19 May 2015 03:47:50 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Updated patch. -Niklesh +while (tracksize + 8 = avpkt-size) { +// A box is a minimum of 8 bytes. +tsmb = ptr + tracksize - 2; tsmb_size = AV_RB32(tsmb);

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-13 Thread Philip Langdale
On 2015-04-13 03:39, Petri Hintukainen wrote: I don't know if it is a good idea to use HDMV stream types without HDMV program registration descriptor. If this is fixed incrementally, fixing should be started from the opposite direction: - Using HDMV stream type requires HDMV registration

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-11 Thread Philip Langdale
On Sun, 12 Apr 2015 00:16:45 + (UTC) Carl Eugen Hoyos ceho...@ag.or.at wrote: Timothy Gu timothygu99 at gmail.com writes: From: Niklesh Lalwani lalwani1994 at gmail.com Fixes #2622. Which sample did you use for testing? I don't think we have a sample in FATE that has subtitles.

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Add options for level and tier

2015-04-03 Thread Philip Langdale
On Fri, 3 Apr 2015 18:23:05 +0200 Timo Rothenpieler t...@rothenpieler.org wrote: --- libavcodec/nvenc.c | 111 - 1 file changed, 110 insertions(+), 1 deletion(-) Needs a changelog description but otherwise looks fine. --phil

Re: [FFmpeg-devel] [PATCH] Fix 'while' loop condition to prevent movtext crashes by tracking packet size

2015-05-19 Thread Philip Langdale
On Tue, 19 May 2015 18:35:09 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Thanks Philip. Updated. -Niklesh Looks good. I'll commit it later today. --phil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-20 Thread Philip Langdale
On 2015-05-20 13:13, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/libavcodec/movtextdec.c

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-20 Thread Philip Langdale
On 2015-05-20 07:40, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch is to be applied over the previous patch to fix movtext crashes (which is yet to be committed) Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 11 ++- 1 file

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-20 Thread Philip Langdale
included in tsmb_size, so you'll end up failing the avpkt-size check even if the track is valid. On 20-May-2015 11:17 PM, Philip Langdale phil...@overt.org wrote: On 2015-05-20 07:40, Niklesh Lalwani wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch is to be applied over the previous

[FFmpeg-devel] [PATCH] avcodec/allcodecs: Re-order nvenc encoders below x264/5.

2015-06-06 Thread Philip Langdale
We shouldn't pick nvenc by default. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/allcodecs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index 159d842..6a91d64 100644 --- a/libavcodec/allcodecs.c

Re: [FFmpeg-devel] FFmpeg 2.7

2015-06-06 Thread Philip Langdale
On Sat, 6 Jun 2015 14:34:11 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sat, Jun 06, 2015 at 02:16:14PM +0200, Timo Rothenpieler wrote: Hi all Its time again for another release (its about 3 months since 2.6) so if theres anything you want in it, or you want something

Re: [FFmpeg-devel] [PATCH] avcodec/allcodecs: Re-order nvenc encoders below x264/5.

2015-06-06 Thread Philip Langdale
On Sun, 7 Jun 2015 00:12:18 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sat, Jun 06, 2015 at 01:22:45PM -0700, Philip Langdale wrote: We shouldn't pick nvenc by default. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/allcodecs.c | 6 +++--- 1 file changed

[FFmpeg-devel] [PATCH 4/5] Revert Merge commit 'b08caa87c35a768ec0abb16b1e99c3a85f1df28e'

2015-06-06 Thread Philip Langdale
This reverts commit d8bbb99c51af08c76dd0a66588fecc5c0106844d, reversing changes made to d0d0913702358c61dfb9c5ac8b141cd203524869. Signed-off-by: Philip Langdale phil...@overt.org --- Changelog |1 - configure | 21 +- libavcodec/Makefile |3

[FFmpeg-devel] [PATCH 0/5] Remove nvenc_b

2015-06-06 Thread Philip Langdale
. Philip Langdale (5): Revert Changelog: Drop duplicate NVENC entry Revert avcodec/Makefile: fix checkheaders for nvenc_b Revert nvenc: remove cuda.h requirement for nvenc_a Revert Merge commit 'b08caa87c35a768ec0abb16b1e99c3a85f1df28e' Revert avcodec: Rename nvenc.c to nvenc_a.c, to avoid

[FFmpeg-devel] [PATCH 1/5] Revert Changelog: Drop duplicate NVENC entry

2015-06-06 Thread Philip Langdale
This reverts commit 440fa7758b687bbb0007f85497eed8bb9aec96bd. Signed-off-by: Philip Langdale phil...@overt.org --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index c73f1dd..193ca43 100644 --- a/Changelog +++ b/Changelog @@ -24,6 +24,7 @@ version next

[FFmpeg-devel] [PATCH 2/5] Revert avcodec/Makefile: fix checkheaders for nvenc_b

2015-06-06 Thread Philip Langdale
This reverts commit 3be811a528461816063059377fcb2ac60eabfa77. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index b018a67..f89ed36 100644 --- a/libavcodec/Makefile +++ b

[FFmpeg-devel] [PATCH 5/5] Revert avcodec: Rename nvenc.c to nvenc_a.c, to avoid conflict with the other implementation

2015-06-06 Thread Philip Langdale
This reverts commit d0d0913702358c61dfb9c5ac8b141cd203524869. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/Makefile |2 +- libavcodec/nvenc.c | 1452 ++ libavcodec/nvenc_a.c | 1452

[FFmpeg-devel] [PATCH 3/5] Revert nvenc: remove cuda.h requirement for nvenc_a

2015-06-06 Thread Philip Langdale
This reverts commit f10497042f092d56f82f536276d5998d7fd1e4c4. Signed-off-by: Philip Langdale phil...@overt.org --- configure | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 8168edc..6fdf816 100755 --- a/configure +++ b/configure @@ -1673,7

Re: [FFmpeg-devel] [PATCH 1/5] Revert Changelog: Drop duplicate NVENC entry

2015-06-06 Thread Philip Langdale
On Sat, 06 Jun 2015 15:10:40 -0300 James Almer jamr...@gmail.com wrote: On 06/06/15 2:51 PM, Philip Langdale wrote: This reverts commit 440fa7758b687bbb0007f85497eed8bb9aec96bd. Signed-off-by: Philip Langdale phil...@overt.org --- Changelog | 1 + 1 file changed, 1 insertion

[FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Rename nvenc_h265 to nvenc_hevc

2015-06-06 Thread Philip Langdale
For the sake of compatibility, and because pretty much everything else in the codebase calls it HEVC. Signed-off-by: Philip Langdale phil...@overt.org --- Changelog | 2 +- configure | 2 +- libavcodec/allcodecs.c | 2 +- libavcodec/nvenc.c | 18

[FFmpeg-devel] [PATCH 2/2] avcodec/nvenc: Add 'nvenc_h264' as an alternative name for 'nvenc'

2015-06-06 Thread Philip Langdale
This allows us to offer the same codec name that libav uses. We don't have a special way to do aliases, so it's all a bit more verbose than you'd want but such is life. Signed-off-by: Philip Langdale phil...@overt.org --- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-23 Thread Philip Langdale
On Tue, 23 Jun 2015 11:14:36 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: On 6/23/15, Philip Langdale phil...@overt.org wrote: I got a bunch of warnings when I compiled it. Please fix. Thanks. -- CC libavcodec

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-23 Thread Philip Langdale
On Tue, 23 Jun 2015 16:54:08 +0200 wm4 nfx...@googlemail.com wrote: In my opinion these warnings should either be silenced, or an av_bprint function taking void* should be added and used. While the warning is indeed a false positive here, they can obscure interesting warnings. A fair point.

Re: [FFmpeg-devel] [PATCH] avcodec/vdpau: Support for VDPAU accelerated HEVC decoding

2015-06-25 Thread Philip Langdale
On Thu, 25 Jun 2015 19:15:40 +0200 Michael Niedermayer michae...@gmx.at wrote: On Wed, Jun 24, 2015 at 07:54:52PM -0700, Philip Langdale wrote: Ping? the indention depth seems inconsistent should be ok if it works otherwise but iam no VDPAU devel Fixed and pushed. Thanks, --phil

Re: [FFmpeg-devel] [PATCH] avcodec/vdpau: Support for VDPAU accelerated HEVC decoding

2015-06-24 Thread Philip Langdale
Ping? On Sat, 20 Jun 2015 11:45:01 -0700 Philip Langdale phil...@overt.org wrote: This change introduces basic support for HEVC decoding through vdpau. Right now, there are problems with the nvidia driver/library implementation that mean that frames are incorrectly laid out in memory when

Re: [FFmpeg-devel] [PATCH 1/2] movtextdec.c: Improve upon dynarrays and text_to_ass

2015-06-20 Thread Philip Langdale
On Thu, 18 Jun 2015 22:26:52 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Updated patch attached. On 18-Jun-2015 2:52 PM, Clément Bœsch u...@pkh.me wrote: av_dynarray_add(style_flags, index, flag); +s_temp-style_flag = AV_RB8(tsmb); +

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-20 Thread Philip Langdale
On Thu, 18 Jun 2015 22:20:05 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Updated patch. Thanks, Niklesh From faae5cbec4772b81f124c09326010ddafc7aa780 Mon Sep 17 00:00:00 2001 From: Niklesh niklesh.lalw...@iitb.ac.in Date: Thu, 18 Jun 2015 22:04:54 +0530 Subject: [PATCH 2/2]

[FFmpeg-devel] [PATCH] avcodec/vdpau: Support for VDPAU accelerated HEVC decoding

2015-06-20 Thread Philip Langdale
to display correctly, but there are still samples with glitches that are related to LTRs. In terms of real world files, both x265 and nvenc only use short term refs from this list. The divx encoder seems similar. Signed-off-by: Philip Langdale phil...@overt.org --- configure

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-22 Thread Philip Langdale
On Mon, 22 Jun 2015 19:58:09 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Updated patch. Thanks, Niklesh I got a bunch of warnings when I compiled it. Please fix. Thanks. -- CC libavcodec/movtextenc.o

Re: [FFmpeg-devel] [PATCH 1/2] movtextdec.c: Improve upon dynarrays and text_to_ass

2015-06-22 Thread Philip Langdale
On Mon, 22 Jun 2015 19:56:06 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Updated patch. Thanks, Niklesh Pushed. Thanks. --phil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec: Add flag for experimental HWAccels and use it for VDPAU/HEVC

2015-06-26 Thread Philip Langdale
This HWAccel isn't really usable right now due to an nvidia driver bug, so we don't want it selected by default. HWAccels have a capabilities field and there's a comment about flags, but no flags exist today, so let's add one for experimental hwaccels. Signed-off-by: Philip Langdale phil

Re: [FFmpeg-devel] [PATCH] avcodec: Add flag for experimental HWAccels and use it for VDPAU/HEVC

2015-06-26 Thread Philip Langdale
On 2015-06-26 09:09, wm4 wrote: diff --git a/libavcodec/version.h b/libavcodec/version.h index eff8820..1073588 100644 --- a/libavcodec/version.h +++ b/libavcodec/version.h @@ -29,7 +29,7 @@ #include libavutil/version.h #define LIBAVCODEC_VERSION_MAJOR 56 -#define LIBAVCODEC_VERSION_MINOR 45

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-23 Thread Philip Langdale
On Tue, 23 Jun 2015 22:09:20 +0200 Michael Niedermayer michae...@gmx.at wrote: On Wed, Jun 24, 2015 at 01:25:53AM +0530, Niklesh Lalwani wrote: Updated patch. Compiles without any warnings. Tested too. this changes the fate checksum --- ./tests/ref/fate/binsub-movtextenc 2015-06-23

Re: [FFmpeg-devel] [PATCH 2/2] movtextenc.c: Support for Bold, Italic and Underlined styles

2015-06-26 Thread Philip Langdale
On 2015-06-26 09:48, Niklesh Lalwani wrote: The output produced here was actually different from the expected. Hence the test failed. I produced ASS file for both the original file and the encoded file. The ass file produced from the encoded mp4 file seemed to be dropping all text after \N

Re: [FFmpeg-devel] [PATCH] avcodec: Add flag for experimental HWAccels and use it for VDPAU/HEVC

2015-06-26 Thread Philip Langdale
On Fri, 26 Jun 2015 23:10:43 +0200 Michael Niedermayer michae...@gmx.at wrote: On Fri, Jun 26, 2015 at 08:45:09AM -0700, Philip Langdale wrote: This HWAccel isn't really usable right now due to an nvidia driver bug, so we don't want it selected by default. HWAccels have a capabilities

[FFmpeg-devel] Code review tools

2015-06-16 Thread Philip Langdale
Hi all, I've been thinking about whether we'd benefit from using a code review tool like reviewboard (www.reviewboard.org). I use reviewboard at work and it offers a lot of features that make email based reviews seem very crude by comparison. For me, the stand out features are a very good diff

Re: [FFmpeg-devel] [PATCH] avcodec/hevc: Track long and short term RPS size for VDPAU

2015-06-13 Thread Philip Langdale
On Sat, 13 Jun 2015 22:49:58 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sat, Jun 13, 2015 at 09:43:49AM -0700, Philip Langdale wrote: Today, we track the short term RPS size for DXVA, but only if the SliceHeader RPS is being used. Otherwise it's left uninitialized. NVIDIA's

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Enable YV12 input format

2015-06-13 Thread Philip Langdale
On Sat, 13 Jun 2015 22:21:54 +0200 Timo Rothenpieler t...@rothenpieler.org wrote: This has been enabled by recent nvidia driver releases. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/nvenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] Set subtitle track dimensions for mov_text to display the subtitles properly

2015-06-11 Thread Philip Langdale
On Fri, 12 Jun 2015 00:11:24 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Ok so it goes like this. We first find out the height and width of the video stream from the header box. The dimensions of the text track (subtitle track) is then set (in pixels). Here, we have used the

Re: [FFmpeg-devel] [PATCH 2/2] Encoding of styles - Bold, Italic, Underlined for timed-text subttiles

2015-06-11 Thread Philip Langdale
On Thu, 11 Jun 2015 10:18:53 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Encoding of bold, Italic, underlined styles for 3gpp timed text subtitles. All the formatting information is appended into the buffer after the text, unlike other

[FFmpeg-devel] [PATCH] avcodec/nvenc: Enable YV12 input format

2015-06-13 Thread Philip Langdale
This has been enabled by recent nvidia driver releases. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/nvenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 87ce6f3..a5652c5 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] nvenc: remove cuda.h requirement for nvenc_a

2015-05-31 Thread Philip Langdale
On Mon, 1 Jun 2015 00:53:54 -0300 James Almer jamr...@gmail.com wrote: Untested. Signed-off-by: James Almer jamr...@gmail.com --- configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 748b626..f691655 100755 --- a/configure

[FFmpeg-devel] [PATCH] avcodec/nvenc: Add support for H.264 High 444 Predictive encoding

2015-07-01 Thread Philip Langdale
by generating a baseline sample with testsrc converted to raw yuv444p, then encoded the sample with nvenc, then did a framemd5 comparision of both the raw video and the nvenc encode. The framemd5 reports were identical. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/nvenc.c | 31

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for highlight and hilightcolor box

2015-07-05 Thread Philip Langdale
On Sun, 5 Jul 2015 15:53:32 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in This patch adds support for decoding of Highlight and hilightcolor box as defined by 3GPP standards. The code is also reorganised to make it easier to maintain and

Re: [FFmpeg-devel] [PATCH 1/2] Set subtitle track dimensions for mov_text to display the subtitles properly

2015-06-11 Thread Philip Langdale
On 2015-06-11 00:42, Nicolas George wrote: Le tridi 23 prairial, an CCXXIII, Niklesh Lalwani a écrit : From: Niklesh niklesh.lalw...@iitb.ac.in This patch mostly replicates the concept patch posted by Philip https://ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140299.html. This sets the

Re: [FFmpeg-devel] [PATCH] Improve upon dynamic arrays- movtext subtitles

2015-05-25 Thread Philip Langdale
On Mon, 25 May 2015 00:37:03 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 32 1 file changed, 16 insertions(+), 16

Re: [FFmpeg-devel] [PATCH] Improve upon dynamic arrays- movtext subtitles

2015-05-25 Thread Philip Langdale
On Mon, 25 May 2015 21:51:36 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Updated Patch. Thanks, Niklesh use return AVERROR(ENOMEM); On Mon, May 25, 2015 at 9:10 PM, Philip Langdale phil...@overt.org wrote: On Mon, 25 May 2015 00:37:03 +0530 Niklesh Lalwani

[FFmpeg-devel] [PATCH] avcodec/vdpau: Don't leak h264.h into all VDPAU codecs

2015-05-25 Thread Philip Langdale
h264.h and hevc.h are mutually exclusive due to defining some of the same names. As such, we need to avoid forcing h264.h to be included if we want hevc decode acceleration to be possible. Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/vc1dec.c | 1 + libavcodec

Re: [FFmpeg-devel] [PATCH] avcodec/vdpau: Don't leak h264.h into all VDPAU codecs

2015-05-25 Thread Philip Langdale
On Mon, 25 May 2015 20:34:34 +0200 Michael Niedermayer michae...@gmx.at wrote: On Mon, May 25, 2015 at 09:46:14AM -0700, Philip Langdale wrote: h264.h and hevc.h are mutually exclusive due to defining some of the same names. As such, we need to avoid forcing h264.h to be included if we

[FFmpeg-devel] [PATCH] avcodec/vdpau: Re-factor pre-hwaccel helper functions into separate header

2015-05-25 Thread Philip Langdale
the declaration of all those helpers to a separate header which we will exclude for the hevc support (which will be hwaccel-only). Signed-off-by: Philip Langdale phil...@overt.org --- libavcodec/h263dec.c| 2 +- libavcodec/h264.c | 2 +- libavcodec/h264_picture.c | 2 +- libavcodec

Re: [FFmpeg-devel] [PATCH] avcodec/vdpau: Don't leak h264.h into all VDPAU codecs

2015-05-25 Thread Philip Langdale
On Mon, 25 May 2015 13:14:05 -0700 Philip Langdale phil...@overt.org wrote: On Mon, 25 May 2015 20:34:34 +0200 Michael Niedermayer michae...@gmx.at wrote: On Mon, May 25, 2015 at 09:46:14AM -0700, Philip Langdale wrote: h264.h and hevc.h are mutually exclusive due to defining some

Re: [FFmpeg-devel] [PATCH] avcodec/vdpau: Re-factor pre-hwaccel helper functions into separate header

2015-05-25 Thread Philip Langdale
On Tue, 26 May 2015 02:21:43 +0200 Michael Niedermayer michae...@gmx.at wrote: On Mon, May 25, 2015 at 04:29:12PM -0700, Philip Langdale wrote: h264.h and hevc.h are mutually exclusive due to defining some of the same names. As such, we need to avoid forcing h264.h to be included if we

Re: [FFmpeg-devel] [PATCH] Improve upon dynamic arrays- movtext subtitles

2015-05-23 Thread Philip Langdale
On Fri, 22 May 2015 22:52:24 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in Using char** for style_start and style_end, and using uint8_t** for style_entries. This seems to be the least messy way. Signed-off-by: Niklesh

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-21 Thread Philip Langdale
On Thu, 21 May 2015 18:51:20 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: Do you mean using a variable equal to tracksize + 10/18? That wouldn't be of much use imo. No, a variable equal to 10 or 18, depending. Then you don't need code that does one check if it's a large box and

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(32 bit)

2015-05-22 Thread Philip Langdale
On Thu, 21 May 2015 21:45:52 +0530 Niklesh Lalwani lalwani1...@gmail.com wrote: Updated patch. Thanks, Niklesh Pushed. Thanks. --phil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

  1   2   3   4   5   >