Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: fix leaking fdsp for mp3on4float

2017-02-16 Thread Andreas Cadhalpun
On 16.02.2017 03:12, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:39:17AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/mpegaudiodec_template.c | 3 +++ >> 1 file changed, 3 insertions(+) > > should be ok

Re: [FFmpeg-devel] [PATCH] wmaprodec: fix leaking fdsp on init failure

2017-02-16 Thread Andreas Cadhalpun
On 16.02.2017 03:04, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:56:38AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/wmaprodec.c | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(-) > > should

Re: [FFmpeg-devel] [PATCH] tiff: fix leaking yuv_line

2017-02-16 Thread Andreas Cadhalpun
On 16.02.2017 03:15, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:23:28AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/tiff.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/tiff.c

[FFmpeg-devel] [PATCH] fate/source: Check for cases that could use av_clip_uintp2() and av_clip_intp2()

2017-02-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tests/fate/source-check.sh | 14 ++ tests/ref/fate/source | 2 ++ 2 files changed, 16 insertions(+) diff --git a/tests/fate/source-check.sh b/tests/fate/source-check.sh index ac2878d9f7..72e1511f0d 100755 ---

Re: [FFmpeg-devel] [PATCH] vaapi_vp8: Use VP8_MAX_QUANT instead of magic number

2017-02-16 Thread Mark Thompson
On 16/02/17 23:46, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 08:45:33PM +, Mark Thompson wrote: >> --- >> On 16/02/17 20:15, Michael Niedermayer wrote: >>> On Thu, Feb 16, 2017 at 05:11:54PM +, Mark Thompson wrote: On 16/02/17 16:20, Michael Niedermayer wrote: > Its

Re: [FFmpeg-devel] [PATCH]lavc/avpacket: Initialize a variable in error path

2017-02-16 Thread Michael Niedermayer
On Fri, Feb 17, 2017 at 12:49:05AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch is said to fix undefined behaviour, see ticket #6153, I cannot > reproduce. > > Please comment, Carl Eugen patch is ok the issue described is real but a bit hypothetical and probably has no real world

[FFmpeg-devel] [PATCH]lavc/avpacket: Initialize a variable in error path

2017-02-16 Thread Carl Eugen Hoyos
Hi! Attached patch is said to fix undefined behaviour, see ticket #6153, I cannot reproduce. Please comment, Carl Eugen From 8bbd58c465deb28737586c9292d57ab75e3de32c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 17 Feb 2017 00:46:14 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] aacdec: When ignoring a PCE restore the previous config

2017-02-16 Thread Carl Eugen Hoyos
2017-02-16 22:13 GMT+01:00 Alex Converse : > This is related to, but doesn't solve ticker 6152. > --- > libavcodec/aacdec_template.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c > index

Re: [FFmpeg-devel] [PATCH]doc: correct-order-of-options-for-channelmap-filter

2017-02-16 Thread Lou Logan
On Fri, 17 Feb 2017 00:34:59 +0530, Mulvya V wrote: > From fb16f34c7894d407be856e31081a750ab9426e1e Mon Sep 17 00:00:00 2001 > From: Mulvya > Date: Fri, 17 Feb 2017 00:27:32 +0530 > Subject: [PATCH] doc: correct order of options for channelmap filter > > Signed-off-by: Mulvya

Re: [FFmpeg-devel] [PATCH] vaapi_vp8: Use VP8_MAX_QUANT instead of magic number

2017-02-16 Thread Michael Niedermayer
On Thu, Feb 16, 2017 at 08:45:33PM +, Mark Thompson wrote: > --- > On 16/02/17 20:15, Michael Niedermayer wrote: > > On Thu, Feb 16, 2017 at 05:11:54PM +, Mark Thompson wrote: > >> On 16/02/17 16:20, Michael Niedermayer wrote: > >>> Its used elsewhere for 2^p-1 cliping > >>> > >>>

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp8: Use av_clip_uintp2()

2017-02-16 Thread Michael Niedermayer
On Thu, Feb 16, 2017 at 05:50:58PM -0300, James Almer wrote: > On 2/16/2017 5:15 PM, Michael Niedermayer wrote: > > On Thu, Feb 16, 2017 at 05:11:54PM +, Mark Thompson wrote: > >> On 16/02/17 16:20, Michael Niedermayer wrote: > >>> Its used elsewhere for 2^p-1 cliping > >>> > >>>

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolbox: cosmetic change to simplify code with early return

2017-02-16 Thread wm4
On Thu, 16 Feb 2017 10:29:37 -0800 Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/videotoolbox.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > index

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/videotoolbox: restart decompression session on bad data errors

2017-02-16 Thread wm4
On Thu, 16 Feb 2017 10:29:38 -0800 Aman Gupta wrote: > From: Aman Gupta > > On some platforms (observed on macOS Sierra with 12" macbook), the VT > decoder will start returning errors when encountering an SPS change in > the h264 bitstream. With this patch, the

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-02-16 Thread wm4
On Thu, 16 Feb 2017 10:29:36 -0800 Aman Gupta wrote: > From: Aman Gupta > > This fixes playback of h264 streams with SPS changes. One such sample > is available at http://tmm1.s3.amazonaws.com/videotoolbox/spschange.ts. > It switches mid-stream from level 4.0 to

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-02-16 Thread wm4
On Thu, 16 Feb 2017 19:46:08 + Mark Thompson wrote: > On 16/02/17 18:29, Aman Gupta wrote: > > From: Aman Gupta > > > > This fixes playback of h264 streams with SPS changes. One such sample > > is available at

[FFmpeg-devel] [PATCH] avutil/tests/lfg.c: added proper normality test

2017-02-16 Thread Thomas Turner
The Chen-Shapiro(CS) test was used to test normality for Lagged Fibonacci PRNG. Normality Hypothesis Test: The null hypothesis formally tests if the population the sample represents is normally-distributed. For CS, when the normality hypothesis is True, the distribution of QH will have a mean

Re: [FFmpeg-devel] [PATCH v2 0/5] A native Opus encoder

2017-02-16 Thread Moritz Barsnick
On Tue, Feb 14, 2017 at 06:37:16 +, Rostislav Pehlivanov wrote: > Applied! > Thanks for all the people who commented on it This deserves a Changelog entry. (I missed that during the review process.) Moritz ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/4] avcodec/x86: deduplicate PASS8ROWS macro

2017-02-16 Thread James Darnley
--- libavcodec/x86/h264_deblock.asm | 5 - libavcodec/x86/h264_deblock_10bit.asm | 5 - libavcodec/x86/hevc_deblock.asm | 5 - libavutil/x86/x86util.asm | 5 + 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/libavcodec/x86/h264_deblock.asm

[FFmpeg-devel] [PATCH 2/4] avcodec/h264: add named parameters to x86 function

2017-02-16 Thread James Darnley
--- libavcodec/x86/h264_deblock.asm | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/x86/h264_deblock.asm b/libavcodec/x86/h264_deblock.asm index 435c8be..509a0db 100644 --- a/libavcodec/x86/h264_deblock.asm +++

Re: [FFmpeg-devel] [PATCH 3/4] x86util: import MOVHL macro

2017-02-16 Thread Paul B Mahol
On 2/16/17, James Darnley wrote: > Originally committed to x264 in 1637239a by Henrik Gramner who has > agreed to re-license it as LGPL. Original commit message follows. > > x86: Avoid some bypass delays and false dependencies > > A bypass delay of 1-3 clock cycles may

[FFmpeg-devel] [PATCH 4/4] avcodec/h264: sse2, avx h luma mbaff deblock/loop filter

2017-02-16 Thread James Darnley
x86-64 only Yorkfield: - sse2: ~2.17x (434 vs. 200 cycles) Nehalem: - sse2: ~2.94x (409 vs. 139 cycles) Skylake: - sse2: ~3.10x (370 vs. 119 cycles) - avx: ~3.29x (370 vs. 112 cycles) --- libavcodec/x86/h264_deblock.asm | 89 +

Re: [FFmpeg-devel] [PATCH] lavc/vda_h264_dec.c Fix NULL pointer dereference

2017-02-16 Thread Michael Niedermayer
On Wed, Feb 15, 2017 at 10:05:56AM -0700, Pavel Koshevoy wrote: > On Thu, Feb 9, 2017 at 8:20 PM, wrote: > > From: Pavel Koshevoy > > > > ps.sps_list entries may be NULL, so check before dereferencing > > --- > > libavcodec/vda_h264_dec.c | 2 +- > > 1

Re: [FFmpeg-devel] [PATCH] avformat/mpl2dec: skip BOM when probing

2017-02-16 Thread Paul B Mahol
On 2/15/17, Paul B Mahol wrote: > Fixes #5442. > > Signed-off-by: Paul B Mahol > --- > libavformat/mpl2dec.c | 8 > 1 file changed, 8 insertions(+) > Will apply this shortly. ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp8: Use av_clip_uintp2()

2017-02-16 Thread Michael Niedermayer
Its used elsewhere for 2^p-1 cliping Signed-off-by: Michael Niedermayer --- libavcodec/vaapi_encode_vp8.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vaapi_encode_vp8.c b/libavcodec/vaapi_encode_vp8.c index 4a1c85e66c..3d3831c46d

[FFmpeg-devel] [PATCH v1 2/2] rtp: rawvideo: add handler for YCbCr-4:2:2

2017-02-16 Thread Damien Riegel
This adds partial support for the RFC 4175 (raw video over RTP). The only supported formats are the YCbCr-4:2:2 8 bit because it's natively supported by FFmpeg with pixel format UYVY, and 10 bit which requires the vrawdepay codec to convert the payload in a format handled by FFmpeg.

[FFmpeg-devel] [PATCH v1 0/2] Add support for raw video over RTP

2017-02-16 Thread Damien Riegel
This patchset adds support for the RFC 4175: RTP Payload Format for Uncompressed Video. [1] It only supports progressive YCbCr 4:2:2 video format, with 8-bit and 10-bit samples. [1] https://tools.ietf.org/html/rfc4175 Damien Riegel (2): codec: vrawdepay: add decoder for RFC4175 rtp:

[FFmpeg-devel] [PATCH v1 1/2] codec: vrawdepay: add decoder for RFC4175

2017-02-16 Thread Damien Riegel
Add a codec capable of decoding some formats of the RFC4175. For now it's only capable of handling YCbCr-4:2:2 with 8-bit or 10-bit depth. For 8-bit it's a simple pass-through, for 10-bit it depacks the stream in the AV_PIX_FMT_YUV422P10 pixel format. Change-Id:

Re: [FFmpeg-devel] [PATCH v1 1/2] codec: vrawdepay: add decoder for RFC4175

2017-02-16 Thread Rostislav Pehlivanov
On 16 February 2017 at 17:43, Damien Riegel < damien.rie...@savoirfairelinux.com> wrote: > Add a codec capable of decoding some formats of the RFC4175. For now > it's only capable of handling YCbCr-4:2:2 with 8-bit or 10-bit depth. > > For 8-bit it's a simple pass-through, for 10-bit it depacks

Re: [FFmpeg-devel] [PATCH v1 1/2] codec: vrawdepay: add decoder for RFC4175

2017-02-16 Thread Rostislav Pehlivanov
On 16 February 2017 at 18:18, Rostislav Pehlivanov wrote: > > > On 16 February 2017 at 17:43, Damien Riegel savoirfairelinux.com> wrote: > >> Add a codec capable of decoding some formats of the RFC4175. For now >> it's only capable of handling YCbCr-4:2:2

[FFmpeg-devel] [PATCH 2/3] avcodec/videotoolbox: cosmetic change to simplify code with early return

2017-02-16 Thread Aman Gupta
From: Aman Gupta --- libavcodec/videotoolbox.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 1288aa5..9be7bee 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c

[FFmpeg-devel] [PATCH 3/3] avcodec/videotoolbox: restart decompression session on bad data errors

2017-02-16 Thread Aman Gupta
From: Aman Gupta On some platforms (observed on macOS Sierra with 12" macbook), the VT decoder will start returning errors when encountering an SPS change in the h264 bitstream. With this patch, the kVTVideoDecoderBadDataErr response from the decoder is caught and the

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-16 Thread Aaron Colwell
On Thu, Feb 16, 2017 at 11:09 AM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Wed, Feb 15, 2017 at 2:54 PM, Aaron Colwell > wrote: > > Hi Vittorio, > > > > This may not be a blocker for this patch, but one issue with converting > the > > bounds to pixels like

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-02-16 Thread Mark Thompson
On 16/02/17 18:29, Aman Gupta wrote: > From: Aman Gupta > > This fixes playback of h264 streams with SPS changes. One such sample > is available at http://tmm1.s3.amazonaws.com/videotoolbox/spschange.ts. > It switches mid-stream from level 4.0 to level 3.2. > > Previously,

Re: [FFmpeg-devel] [PATCH v1 0/2] Add support for raw video over RTP

2017-02-16 Thread Carl Eugen Hoyos
2017-02-16 18:43 GMT+01:00 Damien Riegel : > This patchset adds support for the RFC 4175: RTP Payload Format for > Uncompressed Video. [1] > > It only supports progressive YCbCr 4:2:2 video format, with 8-bit and > 10-bit samples. How is the 10-bit payload

Re: [FFmpeg-devel] aac_latm: SSR is not implemented

2017-02-16 Thread Aman Gupta
On Wed, Feb 1, 2017 at 9:12 AM Carl Eugen Hoyos wrote: > 2017-02-01 5:06 GMT+01:00 Aman Gupta : > > I have a mpegts file with a HE-AAC audio track that cannot be decoded by > > ffmpeg. I have uploaded a sample at the link below, as requested by the > >

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp8: Use av_clip_uintp2()

2017-02-16 Thread Mark Thompson
On 16/02/17 16:20, Michael Niedermayer wrote: > Its used elsewhere for 2^p-1 cliping > > Signed-off-by: Michael Niedermayer > --- > libavcodec/vaapi_encode_vp8.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/vaapi_encode_vp8.c

Re: [FFmpeg-devel] [PATCH v2 0/5] A native Opus encoder

2017-02-16 Thread Rostislav Pehlivanov
On 16 February 2017 at 13:08, Moritz Barsnick wrote: > On Tue, Feb 14, 2017 at 06:37:16 +, Rostislav Pehlivanov wrote: > > Applied! > > Thanks for all the people who commented on it > > This deserves a Changelog entry. (I missed that during the review > process.) > > Moritz

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp8: Use av_clip_uintp2()

2017-02-16 Thread Michael Niedermayer
On Thu, Feb 16, 2017 at 05:11:54PM +, Mark Thompson wrote: > On 16/02/17 16:20, Michael Niedermayer wrote: > > Its used elsewhere for 2^p-1 cliping > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vaapi_encode_vp8.c | 6 +++--- > > 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] libopus: decode ambisonics with non-diegetic sources

2017-02-16 Thread Felicia Lim
Hi all, Just wanted to follow up this patch which allows decoding opus ambisonics with an additional stereo stream at the end. Please let me know if there are any changes I should make to it? Thanks, Felicia On Fri, Feb 10, 2017 at 10:42 AM Felicia Lim wrote: > Hi all, > >

Re: [FFmpeg-devel] [PATCH 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-16 Thread Vittorio Giovara
On Wed, Feb 15, 2017 at 2:54 PM, Aaron Colwell wrote: > Hi Vittorio, > > This may not be a blocker for this patch, but one issue with converting the > bounds to pixels like you do here is that resizing a video could result in > incorrect metadata being generated when muxing.

Re: [FFmpeg-devel] TR-03 implementation

2017-02-16 Thread Éloi Bail
Hi, In november, we wrote on the mailing list about implementing support for TR-03 in ffmpeg [1]. There were some doubts in the ffmpeg community about whether or not ffmpeg could handle demuxing 3gbps of RTP input without significantly modifying the RTP demuxer and/or doing kernel bypassing.

Re: [FFmpeg-devel] [FFmpeg-user] ffmpeg engineer

2017-02-16 Thread Reuben Martin
Well, I’m U.S. citizen, so visa stuff isn’t an issue, but I’ve never been impressed with JVM/JRE enough to take time to learn it. Just FYI, for DASH, you will probably want somebody proficient in C who is somewhat familiar with the ffmpeg code base who can also develop patches for ffmpeg. The