Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_ssim: fix temp size calculation

2017-08-03 Thread Tobias Rapp
On 03.08.2017 03:03, Muhammad Faiz wrote: Also use av_mallocz_array. Fix Ticket6519. Signed-off-by: Muhammad Faiz --- libavfilter/vf_ssim.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_ssim.c b/libavfilter/vf_ssim.c index

[FFmpeg-devel] [PATCH v5 2/3] speedhq: add FATE tests

2017-08-03 Thread Steinar H. Gunderson
Also add simple FATE tests, based on output produced by the NDI SDK. --- tests/Makefile | 1 + tests/fate/speedhq.mak | 9 + tests/ref/fate/speedhq-422 | 6 ++ tests/ref/fate/speedhq-422-singlefield | 6 ++ 4 files changed, 22

[FFmpeg-devel] [PATCH v5 1/3] speedhq: fix behavior of single-field decoding

2017-08-03 Thread Steinar H. Gunderson
The height convention for decoding frames with only a single field made sense for compatibility with legacy decoders, but doesn't really match the convention used by NDI, which is the primary (only?) user. Thus, change it to simply assuming that if the two fields overlap, the frame is meant to be

[FFmpeg-devel] [PATCH v5 3/3] Add myself as speedhq maintainer, per request.

2017-08-03 Thread Steinar H. Gunderson
--- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ae0e08d121..ce5e1dae08 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -233,6 +233,7 @@ Codecs: smvjpegdec.c Ash Hughes snow* Michael

Re: [FFmpeg-devel] [PATCH v4 2/3] speedhq: add FATE tests

2017-08-03 Thread Steinar H. Gunderson
On Thu, Aug 03, 2017 at 02:24:17AM +0200, Michael Niedermayer wrote: > doesnt work > make -j12 fate-speedhq > make: *** No rule to make target `fate-speedhq-422', needed by > `fate-speedhq'. Stop. > > make fate-speedhq-422-singlefield > make: *** No rule to make target

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-08-03 Thread Steinar H. Gunderson
On Thu, Aug 03, 2017 at 08:21:09AM +0300, Maksym Veremeyenko wrote: >> You should reject bottom field first formats, as NDI explicitly >> disallows them. > even if it disallowed, why to drop? may be warning message would be enough? FWIW, the documentation may say that formats are always TFF, but

Re: [FFmpeg-devel] [PATCHv2 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-03 Thread Jorge Ramirez
On 08/03/2017 11:22 AM, Nicolas George wrote: I still hope you can be convinced to understand proper design principles. But if that cannot be achieved,then authority it is. if it is ok with you, let's move on. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCHv2 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-03 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXV, Jorge Ramirez a écrit : > how can I propose that "every single application duplicate headers" without > knowing their use cases? that sort of generalization seems silly to me. > there is no silver bullet to these kind of problems as you probably know. You said

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXV, Tomas Härdin a écrit : > Posting this to both [ffmpeg-devel] and [Freetel-codec2] in hopes of > maximum feedback. > > I've been spending the last few days getting codec2 (http://freedv.org/ > ) hooked up in libavcodec, and a set of muxers and demuxers for both >

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Tomas Härdin
On Thu, 2017-08-03 at 01:07 +0200, Carl Eugen Hoyos wrote: > 2017-08-03 0:40 GMT+02:00 Tomas Härdin : > > > > > Decoding a .c2 file is straightforward however, thanks to the > > header: > > > >   ffmpeg -i report2074.c2 out.wav > The probe score is too high. > I suspect you

Re: [FFmpeg-devel] [PATCH] swscale/utils.c: Fix incorrect error when calling sws_setColorspaceDetails

2017-08-03 Thread Mark Boorer
I can confirm that range works as expected, but I couldn't actually see any difference when setting brightness, contrast or saturation. It looks as though all of those calculations only take place inside the yuv2rgb lookup table, so when converting from yuv->yuv they won't get applied. In my case

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-08-03 Thread Steinar H. Gunderson
On Thu, Aug 03, 2017 at 08:21:09AM +0300, Maksym Veremeyenko wrote: >> You should reject bottom field first formats, as NDI explicitly >> disallows them. > even if it disallowed, why to drop? may be warning message would be enough? FWIW, the documentation may say that formats are always TFF, but

Re: [FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-03 Thread Jorge Ramirez
On 08/03/2017 01:53 AM, Mark Thompson wrote: On 02/08/17 08:32, Jorge Ramirez-Ortiz wrote: ... diff --git a/compat/v4l2/v4l2-common.h b/compat/v4l2/v4l2-common.h diff --git a/compat/v4l2/videodev2.h b/compat/v4l2/videodev2.h These are discussed in other threads. I don't really have any

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Hendrik Leppkes
On Thu, Aug 3, 2017 at 5:45 PM, Tomas Härdin wrote: >> > +} else { >> > +if (avctx->extradata_size != sizeof(avpriv_codec2_header)) >> > { >> > +av_log(avctx, AV_LOG_ERROR, "must have exactly %zu >> > bytes of extradata (got %i)\n", >> > +

[FFmpeg-devel] [PATCH] JPEG2000 encoding with variable codeblock size

2017-08-03 Thread francesco
From: Francesco Cuzzocrea Hi to all I've made some simple changes tha allow encoding with variable codeblock size. Default value are the same as previous (16X16) but now setting them to 64x128 make generated codestream compatible with Analog Devices ADV212 video codec.

[FFmpeg-devel] [PATCH v2] swscale: fix gbrap16 alpha channel issues

2017-08-03 Thread James Cowgill
Fixes filter-pixfmts-scale test failing on big-endian systems due to alpSrc not being cast to (const int32_t**). Also fixes distortions in the output alpha channel values by copying the alpha channel code from the rgba64 case found elsewhere in output.c. Fixes ticket 6555. Signed-off-by: James

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Tomas Härdin
On Thu, 2017-08-03 at 13:00 +0200, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXV, Tomas Härdin a écrit : > > With both the raw demuxer and the encoder you need to specify the > > desired mode, like this: > The encoder could default to one the two. Default on-the-air is 1300 (aka

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix memory leak in avformat_free_context

2017-08-03 Thread Steven Siloti
On Mon, Jul 31, 2017 at 11:08 AM, Steven Siloti wrote: > The pointer to the packet queue is stored in the internal structure > so the queue needs to be flushed before internal is freed. > > Signed-off-by: Steven Siloti > --- > libavformat/utils.c

Re: [FFmpeg-devel] [PATCH] swscale: fix gbrap16 alpha channel issues

2017-08-03 Thread James Cowgill
Hi, On 02/08/17 23:21, Michael Niedermayer wrote: > On Wed, Aug 02, 2017 at 03:32:04PM +0100, James Cowgill wrote: >> Hi, >> >> On 02/08/17 14:18, Michael Niedermayer wrote: >>> On Tue, Aug 01, 2017 at 02:46:22PM +0100, James Cowgill wrote: Fixes filter-pixfmts-scale test failing on

Re: [FFmpeg-devel] [PATCH] JPEG2000 encoding with variable codeblock size

2017-08-03 Thread Aaron Boxer
On Aug 3, 2017 9:58 AM, wrote: From: Francesco Cuzzocrea Hi to all I've made some simple changes tha allow encoding with variable codeblock size. Default value are the same as previous (16X16) but now setting them to 64x128 make generated

Re: [FFmpeg-devel] [PATCH v5 3/3] Add myself as speedhq maintainer, per request.

2017-08-03 Thread James Almer
On 8/3/2017 4:31 AM, Steinar H. Gunderson wrote: > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ae0e08d121..ce5e1dae08 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -233,6 +233,7 @@ Codecs: >smvjpegdec.c

Re: [FFmpeg-devel] [PATCH v5 2/3] speedhq: add FATE tests

2017-08-03 Thread James Almer
On 8/3/2017 4:31 AM, Steinar H. Gunderson wrote: > Also add simple FATE tests, based on output produced by the NDI SDK. > --- > tests/Makefile | 1 + > tests/fate/speedhq.mak | 9 + > tests/ref/fate/speedhq-422 | 6 ++ >

Re: [FFmpeg-devel] [PATCH v5 1/3] speedhq: fix behavior of single-field decoding

2017-08-03 Thread James Almer
On 8/3/2017 4:22 AM, Steinar H. Gunderson wrote: > The height convention for decoding frames with only a single field made sense > for compatibility with legacy decoders, but doesn't really match the > convention > used by NDI, which is the primary (only?) user. Thus, change it to simply >

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Reimar Döffinger
On Thu, Aug 03, 2017 at 12:40:04AM +0200, Tomas Härdin wrote: > +//statically assert the size of avpriv_codec2_header > +//putting it here because all codec2 things depend on codec2utils > +switch(0) { > +case 0: > +case sizeof(avpriv_codec2_header) == 7: //if false then the

Re: [FFmpeg-devel] [PATCH] swscale/utils.c: Fix incorrect error when calling sws_setColorspaceDetails

2017-08-03 Thread Michael Niedermayer
On Thu, Aug 03, 2017 at 12:06:34PM +0100, Mark Boorer wrote: > I can confirm that range works as expected, but I couldn't actually see any > difference when setting brightness, contrast or saturation. It looks as > though all of those calculations only take place inside the yuv2rgb lookup > table,

Re: [FFmpeg-devel] [DISCUSSION] Motion Estimation API/Library

2017-08-03 Thread Ronald S. Bultje
Hi, On Thu, Aug 3, 2017 at 5:32 PM, Davinder Singh wrote: > On Tue, Aug 1, 2017 at 7:40 AM Davinder Singh wrote: > > > [...] > > > > Keeping where the code lives, aside, > > main thing is API, so we need to talk about it. You're assuming that we know

[FFmpeg-devel] [PATCH 1/2] avcodec/h264_slice: Fix overflow in slice offset

2017-08-03 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 1610612736 * 2 cannot be represented in type 'int' Fixes: 2817/clusterfuzz-testcase-minimized-5289691240726528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 2/2] avcodec/aacdec_fixed: fix invalid shift in predict()

2017-08-03 Thread Michael Niedermayer
Fixes: runtime error: shift exponent -2 is negative Fixes: 2818/clusterfuzz-testcase-minimized-5062943676825600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [DISCUSSION] Motion Estimation API/Library

2017-08-03 Thread Davinder Singh
On Tue, Aug 1, 2017 at 7:40 AM Davinder Singh wrote: > [...] > Keeping where the code lives, aside, main thing is API, so we need to talk about it. -- Davinder Singh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [Patch] nvenc : Add P016 support

2017-08-03 Thread Philip Langdale
On Wed, 26 Jul 2017 09:14:04 + Philip Langdale wrote: > On 2017-07-25 08:33, Yogender Gupta wrote: > >>> I can push, but to answer Timo's question: I did not add P016 to > >>> nvenc because it is technically not correct to pass 12bit content > >>> through a 10bit surface

Re: [FFmpeg-devel] [PATCH] hwupload_cuda : Add 10/16 bit format support

2017-08-03 Thread Philip Langdale
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 19 Jul 2017 17:46:30 +0200 Michael Niedermayer wrote: > On Tue, Jul 18, 2017 at 10:34:20AM +, Yogender Gupta wrote: > > Added 10/16bit formats to hwupload_cuda. > > > > Thanks, > > Yogender > > > >

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_ssim: fix temp size calculation

2017-08-03 Thread Muhammad Faiz
On Thu, Aug 3, 2017 at 1:53 PM, Tobias Rapp wrote: > On 03.08.2017 03:03, Muhammad Faiz wrote: >> >> Also use av_mallocz_array. >> Fix Ticket6519. >> >> Signed-off-by: Muhammad Faiz >> --- >> libavfilter/vf_ssim.c | 8 +--- >> 1 file changed, 5

Re: [FFmpeg-devel] [PATCH]v6 Opus Pyramid Vector Quantization Search in x86 SIMD asm

2017-08-03 Thread Ivan Kalvachev
On 8/2/17, Henrik Gramner wrote: > On Tue, Aug 1, 2017 at 11:46 PM, Ivan Kalvachev > wrote: >> On 7/31/17, Henrik Gramner wrote: >>> Use rN instead of rNq for numbered registers (q suffix is used for >>> named args only due to

Re: [FFmpeg-devel] [PATCH] JPEG2000 encoding with variable codeblock size

2017-08-03 Thread Michael Niedermayer
On Thu, Aug 03, 2017 at 03:58:22PM +0200, france...@bltitalia.com wrote: > From: Francesco Cuzzocrea > > Hi to all > I've made some simple changes tha allow encoding with variable codeblock > size. Default value are the same as previous (16X16) but now setting them > to

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264idct_template: Fix integer overflow in ff_h264_idct_add()

2017-08-03 Thread Michael Niedermayer
On Wed, Aug 02, 2017 at 01:28:17AM +0200, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 26215360 + 2121330944 cannot > be represented in type 'int' > Fixes: 2809/clusterfuzz-testcase-minimized-4785181833560064 > > Found-by: continuous fuzzing process >