Re: [FFmpeg-devel] [PATCH] configure: call flatten_extralibs in a subshell

applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

>On 11/16/17, 4:43 PM, "Nicolas George" wrote: Thanks for the reply. >I think that would work, thanks. > >But I see that in the other patches you call ffio_geturlcontext() >without checking its return value. That is not good at all, and that >would make Coverity squirm. > >If

Re: [FFmpeg-devel] FFmpeg 3.4.1

On Thu, Nov 16, 2017 at 01:04:27AM +0100, Carl Eugen Hoyos wrote: > 2017-11-15 13:34 GMT+01:00 Michael Niedermayer : > > Hi all > > > > I intend to make 3.4.1 very soon > > Shouldn't we first decide on how to proceed with #6775? This would be ideal. IIUC this is a

[FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is done by libklvanc. Libklvanc can be found at:

[FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Signed-off-by: Devin Heitmueller --- libavcodec/avcodec.h | 6 ++

[FFmpeg-devel] [PATCHv2 0/2] Add support for EIA-708/AFD on decklink output

This patch series hooks in the libklvanc library to provide support of output for EIA-708 and AFD packets over SDI output. Patch 1 reflects feedback from Marton Balint Devin Heitmueller (2): libavdevice/decklink: Add support for EIA-708 output over SDI decklink: Add support

Re: [FFmpeg-devel] [PATCH] configure: use subarch instead of arch to create .def files on mingw

On 11/15/2017 11:09 PM, James Almer wrote: > arch is "x86" regardless of target being x86_32 or x86_64, and if > configuring with asm disabled it's "c" instead. > Using subarch (Always either "x86_32" or "x86_64") and adapting > makedef makes sure the symbols are always detected correctly on >

[FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

This corrects a few values in the Image Description for v210 and v410 in mov. Apple defines what the depth value for these uncompressed formats should be in https://developer.apple.com/library/content/technotes/tn2162/_index.html

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

On Thu, Nov 16, 2017 at 06:26:06AM -0500, Ronald S. Bultje wrote: > Hi, > > On Wed, Nov 15, 2017 at 10:15 PM, Carl Eugen Hoyos > wrote: > > > 2017-11-16 4:06 GMT+01:00 Ronald S. Bultje : > > > > > So, commit it without the error message? I really don't

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

> On Nov 16, 2017, at 11:30 AM, Dave Rice wrote: > >> On Jul 9, 2017, at 7:26 PM, Dave Rice wrote: >> >>> On Jul 7, 2017, at 7:06 PM, Derek Buitenhuis >>> wrote: >>> >>> On 7/7/2017 10:13 PM, James Almer wrote: Isn't this

[FFmpeg-devel] [PATCH] avcodec: Implement mpeg2 nvdec hwaccel

This is mostly straight-forward. The weird part is that it should just work for mpeg1, but I see corruption in my test cases, so I'm going to try and fix that separately. Signed-off-by: Philip Langdale --- Changelog | 2 +- configure | 2 +

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

> On Jul 9, 2017, at 7:26 PM, Dave Rice wrote: > > >> On Jul 7, 2017, at 7:06 PM, Derek Buitenhuis >> wrote: >> >> On 7/7/2017 10:13 PM, James Almer wrote: >>> Isn't this necessary only for files with raw video? As is, this box >>> would be

Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling warning

> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling warning > > 2017-11-15 10:04 GMT+01:00 Zhong Li : > > fix the compiling warning of "ignoring return value" > > >

Re: [FFmpeg-devel] [PATCH]lavf/mxfenc: Support 60fps output

2017-10-31 0:22 GMT+01:00 Carl Eugen Hoyos : > Hi! > > Kasper Folman has reported that FFmpeg does not write 60fps > mxf output and has provided a 60fps mxf file on -users. > > Attached patch allows 60fps output. This was successfully tested so I will push if there are no

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-16 13:47 GMT+01:00 Richard Ling : > I created a new patch based on the feedback from Nicolas, but I was > not able to get Gmail to send it back to me without mangling it. > According to the answer at the bottom of >

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

On 24 October 2017 at 07:26, Paul B Mahol wrote: > On 9/14/17, Richard Ling wrote: >> Hi, >> >> This patch adds a filter to normalize (contrast stretch) RGB video. >> Comments welcome. >> >> R. > > What's status of this? I created a new patch based on the

Re: [FFmpeg-devel] FFmpeg 3.4.1

2017-11-16 13:44 GMT+01:00 Michael Niedermayer : > On Thu, Nov 16, 2017 at 01:04:27AM +0100, Carl Eugen Hoyos wrote: >> 2017-11-15 13:34 GMT+01:00 Michael Niedermayer : >> > Hi all >> > >> > I intend to make 3.4.1 very soon >> >> Shouldn't we first

Re: [FFmpeg-devel] [PATCH 09/11] avformat/swfenc: use FFABS to instead of abs

On Wed, Nov 15, 2017 at 03:45:03PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/swfenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its

Re: [FFmpeg-devel] [PATCH]lavf/mxfenc: Support 60fps output

On 11/16/2017 1:27 PM, Carl Eugen Hoyos wrote: > This was successfully tested so I will push if there are no objections. Seems harmless enough if it isn't violating some spec (it is MXF after all...) If someone had objections, they would have responded by now, probably. - Derek

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: checking return value of avio_open_dyn_buf

On 11/16/2017 2:53 AM, Steven Liu wrote: > fix CID: 1421196 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Should be OK if it passes valgrind. - Derek ___

Re: [FFmpeg-devel] [PATCH 04/11] avformat/mov: use FFABS to instead of fabs

On Wed, Nov 15, 2017 at 03:44:11PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Iam not sure FFABS should be used with floats the multiple evaluation in it can lead to interresting

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

Hello, > Maybe there's some other way to send a patch (base64, attached zip file, > ???) > > > https://ffmpeg.org/git-howto.html#Preparing-a-patchset try git format-patch origin/master and put in attach the file(s) Martin

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

On 11/16/17, Carl Eugen Hoyos wrote: > 2017-11-16 13:47 GMT+01:00 Richard Ling : > >> I created a new patch based on the feedback from Nicolas, but I was >> not able to get Gmail to send it back to me without mangling it. > >> According to the answer at the

Re: [FFmpeg-devel] [PATCH 07/11] avformat/mxf: use FFABS to instead of abs

On Wed, Nov 15, 2017 at 03:44:39PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/mxf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich

Re: [FFmpeg-devel] [PATCH 05/11] avformat/mp3dec: use FFABS to instead of abs

On Wed, Nov 15, 2017 at 03:44:17PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/mp3dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

Hi, On Thu, Nov 16, 2017 at 11:50 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Thu, Nov 16, 2017 at 06:26:06AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Nov 15, 2017 at 10:15 PM, Carl Eugen Hoyos > > wrote: > > > > > 2017-11-16 4:06 GMT+01:00

[FFmpeg-devel] [PATCH 3/6] Preserve AFD side data when going from AVPacket to AVFrame

This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c

[FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo pair per audio language). To support the existing

[FFmpeg-devel] [PATCH 6/6] decklink: Add support for SCTE-104 to decklink capture

Make use of libklvanc to parse SCTE-104 packets and announce them as a new stream. Right now we just pass the payload straight through, but once this is hoooked into libklscte35 we'll be able to generate SCTE-35 messages in the MPEG TS stream. Note that this feature needs to be explicitly

[FFmpeg-devel] [RFC PATCH 0/6] Decklink capture VANC improvements and AFD in libx264

The following patch series extends the decklink capture module to use libklvanc for EIA-708, AFD, and SCTE-104 VANC messages. It also introduces support for generating multiple streams of audio, one for each SDI pair. The ffmpeg glue for libx264 has been improved to support encoding of Active

[FFmpeg-devel] [PATCH 1/6] decklink: Fix case where return value wasn't being set before checked for errors

I missed an assignement which cauesd the error case to not ever be properly checked. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_enc.cpp

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 6:41 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos

[FFmpeg-devel] avcodec/hapdec : use gray8 for HapAlphaOnly decoding instead of RGB0

Hello, Following previous discussion patch in attach change pix_fmt for hap alpha only decoding to use gray8 instead of RGB0 0005-avcodec-texturedsp-add-rgtc1u-gray-decoding.patch add rgtc1u_gray func in order to decode in a gray8 picture

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-16 9:07 GMT+01:00 Jerome Martinez : > On 12/11/2017 03:12, Carl Eugen Hoyos wrote: >> >> The matroska spec says blockduration == 0 means the frame is not a >> keyframe. Since all subtitles are "keyframes", 0 blockduration should >> not be written. > > > The issue is

Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

> On Nov 16, 2017, at 6:08 PM, Carl Eugen Hoyos wrote: > > 2017-11-16 17:54 GMT+01:00 Dave Rice : > >> +if (track->mode == MODE_MOV && track->par->codec_id == AV_CODEC_ID_V410) >> +avio_wb16(pb, 0x18); >> +else if (track->mode == MODE_MOV

Re: [FFmpeg-devel] fate/hapdec : add test for hap alpha only

2017-09-28 21:53 GMT+02:00 Martin Vignali : > > > 2017-09-24 11:53 GMT+02:00 Michael Niedermayer : > >> On Sat, Sep 23, 2017 at 09:53:45PM +0200, Martin Vignali wrote: >> > Hello, >> > >> > sample can be found here : >> > https://we.tl/cP0pW9IfBJ

Re: [FFmpeg-devel] fate/hapdec : add test for hap alpha only

> > New patch in attach (use gray8 pix_fmt) > Need to be apply after patch in discussion > avcodec/hapdec : use gray8 for HapAlphaOnly decoding instead of RGB0 > > Martin > With the attachment 0007-fate-hapAlphaOnly-add-test-for-hap-alpha-only-decodi.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

2017-11-16 17:54 GMT+01:00 Dave Rice : > +if (track->mode == MODE_MOV && track->par->codec_id == AV_CODEC_ID_V410) > +avio_wb16(pb, 0x18); > +else if (track->mode == MODE_MOV && track->par->codec_id == > AV_CODEC_ID_V210) > +avio_wb16(pb, 0x18); It

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

On Thu, Nov 16, 2017 at 12:41:32PM -0800, Nick Lewycky wrote: > I initially discovered a signed integer overflow on this line. Since > this value is updated in multiple threads, I use an atomic update and > as it happens atomic addition is defined to wrap around. However, > there's still a

Re: [FFmpeg-devel] [PATCH]lavf/mxfenc: Support 60fps output

2017-11-16 15:08 GMT+01:00 Derek Buitenhuis : > On 11/16/2017 1:27 PM, Carl Eugen Hoyos wrote: >> This was successfully tested so I will push if there are no objections. > > Seems harmless enough if it isn't violating some spec (it is MXF after all...) > > If someone

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

Sorry! Let's try an attachment then. On 16 November 2017 at 14:36, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 12:41:32PM -0800, Nick Lewycky wrote: >> I initially discovered a signed integer overflow on this line. Since >> this value is updated in multiple

Re: [FFmpeg-devel] FFmpeg 3.4.1

On Thu, Nov 16, 2017 at 01:51:34PM +0100, Carl Eugen Hoyos wrote: > 2017-11-16 13:44 GMT+01:00 Michael Niedermayer : > > On Thu, Nov 16, 2017 at 01:04:27AM +0100, Carl Eugen Hoyos wrote: > >> 2017-11-15 13:34 GMT+01:00 Michael Niedermayer : > >> > Hi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

On 11/16/17, Carl Eugen Hoyos wrote: > 2017-11-16 4:06 GMT+01:00 Ronald S. Bultje : > >> So, commit it without the error message? I really don't see the issue. > > As explained, the issue is that without an error message, it > is impossible to parse any

Re: [FFmpeg-devel] [PATCH] vf_zscale: Add more supported input properties

On 11/15/17, Carl Eugen Hoyos wrote: > 2017-11-15 17:26 GMT+01:00 Vittorio Giovara : > >> There is a stable release with this code, and it's a minor update, >> not sure if it warrants a configure check, but I'll add it if requested. > > Does it

Re: [FFmpeg-devel] [PATCH] configure: call flatten_extralibs in a subshell

will push soon if nobody objects smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: change license to LGPL

On Tue, Nov 14, 2017 at 02:35:39PM -0800, Aman Gupta wrote: [...] > The import into ffmpeg was done by Stefano Sabatini. It was then touched by > the following > contributors, who specifically made changes to the filter. This does not > include > commits which changed this file but were part of

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

Le decadi 20 brumaire, an CCXXVI, nablet developer a écrit : > the idea is to avoid code duplication as much as possible, and try to re-use > existing, well-maintained and well-tested code. > this time I've chosen tcp.c rather udp.c for two reasons: > 1. SRT socket API actually resembles tcp, as

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit : > Thanks for the feedback. I have a relevant condition check so that > only a real URLContext is returned. > Please find the new patch attached. I think that would work, thanks. But I see that in the other patches you call

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

Hi, On Wed, Nov 15, 2017 at 10:15 PM, Carl Eugen Hoyos wrote: > 2017-11-16 4:06 GMT+01:00 Ronald S. Bultje : > > > So, commit it without the error message? I really don't see the issue. > > As explained, the issue is that without an error message, it > is

Re: [FFmpeg-devel] [PATCH] fateserver/log: clean chars in slot, time and log

On Tue, Oct 17, 2017 at 06:12:13PM +0200, Michael Niedermayer wrote: > Fixes: Directory Traversal > > Found-by: Pankaj Jadhav > Signed-off-by: Michael Niedermayer > --- > log.cgi | 4 > 1 file changed, 4 insertions(+) patch applied [...] --

Re: [FFmpeg-devel] [PATCH] fateserver/index: clean chars in sort parameter

On Mon, Oct 16, 2017 at 10:36:04PM +0200, Michael Niedermayer wrote: > Prevents cross site scripting attack > > Found-by: Pankaj Jadhav > Signed-off-by: Michael Niedermayer > --- > index.cgi | 2 ++ > 1 file changed, 2 insertions(+) patch applied

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 14.11.17 um 08:23 schrieb Umair Khan: > Hi, > > On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: >> 2017-11-13 6:41 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos >>> wrote:

[FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Make use of libklvanc from within the decklink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_dec.cpp | 135

[FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

If AFD side data is present, include it in an H.264 SEI payload when encoding with libx264. This is done in the same manner that we currently handle A53 closed captions (where the business logic for constructing the SEI is in libavcodec/utils.c), so it should be portable to the other encoder

[FFmpeg-devel] [PATCH] Download dash content with byte range info

--- libavformat/dashdec.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 0e3afd2..33255f2 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -522,6 +522,22 @@ static enum

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

I initially discovered a signed integer overflow on this line. Since this value is updated in multiple threads, I use an atomic update and as it happens atomic addition is defined to wrap around. However, there's still a potential bug in that the error_count may wrap around and equal zero again

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: change license to LGPL

On Tue, Nov 14, 2017 at 2:35 PM, Aman Gupta wrote: > From: Aman Gupta > > This filter was imported from mplayer's libmpcodecs/vf_cropdetect.c, and > marked as GPL when originally copied over. > > On the mplayer side, it was authored originally by arpi and

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 16, 2017 at 11:50 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Thu, Nov 16, 2017 at 06:26:06AM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Wed, Nov 15, 2017 at 10:15 PM,

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

Am 16.11.17 um 19:24 schrieb Thilo Borgmann: > Am 14.11.17 um 08:23 schrieb Umair Khan: >> Hi, >> >> On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: >>> 2017-11-13 6:41 GMT+01:00 Umair Khan : Hi, On Mon, Nov 13, 2017 at 1:09 AM, Carl

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

On Thu, 16 Nov 2017 at 18:21 Ronald S. Bultje wrote: > We are re-hashing old arguments here. I'm not really interested in that. > > My review comment is and remains: please remove the log msg. Otherwise, the > patch is perfectly fine. > I agree with Ronald's argument. I

Re: [FFmpeg-devel] Check size of STSC allocation

On Wed, Nov 15, 2017 at 05:25:47PM -0800, Fredrik Hubinette wrote: > Fixed indentation. > > > On Wed, Nov 15, 2017 at 3:40 PM, Carl Eugen Hoyos > wrote: > > > 2017-11-16 0:21 GMT+01:00 Fredrik Hubinette > org>: > > > This patch checks that the

Re: [FFmpeg-devel] [PATCH] lavf/movenc: allow writing avc3 sample entry type

On Wed, Nov 15, 2017 at 09:17:39AM -0800, John Stebbins wrote: > The avc3 sample entry type is useful for adaptive streaming. It permits > parameter sets to be written inline in the video stream. > --- > libavformat/movenc.c | 1 + > 1 file changed, 1 insertion(+) will apply thanks [...] --

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

>On 11/16/17, 1:11 AM, "Marton Balint" wrote: Thanks for the reply. >For the first patch, I think you forgot to call ff_decklink_set_configs in >decklink_enc. ff_decklink_set_configs is not doing anything related to decklink_enc In any case I have added the same and have

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

On 12/11/2017 03:12, Carl Eugen Hoyos wrote: The matroska spec says blockduration == 0 means the frame is not a keyframe. Since all subtitles are "keyframes", 0 blockduration should not be written. The issue is in the specifications:

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

On Nov 14, 2017 18:53, "James Zern" wrote: On Mon, Nov 13, 2017 at 6:05 PM, James Zern wrote: > On Mon, Nov 13, 2017 at 4:43 PM, James Almer wrote: >> On 11/13/2017 9:01 PM, James Zern wrote: >>> Signed-off-by: James Zern

Re: [FFmpeg-devel] [PATCH 1/6] decklink: Fix case where return value wasn't being set before checked for errors

On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > I missed an assignement which cauesd the error case to not ever be properly > checked. > > Signed-off-by: Devin Heitmueller > --- > libavdevice/decklink_enc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

> On Nov 16, 2017, at 7:22 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + >> audio_offset; >> +for (int x = 0; x < pkt.size; x += sample_size)

Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

Hello Derek, Thanks for taking the time to review these patches. Comments below. > On Nov 16, 2017, at 7:20 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > >> +/* Active Format Description */ >> +if (x4->afd) {

Re: [FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

On 11/17/2017 12:28 AM, Jacob Trimble wrote: > Signed-off-by: Jacob Trimble > --- > libavformat/mov.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Looks OK. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + > audio_offset; > +for (int x = 0; x < pkt.size; x += sample_size) { I realize this is C++, but I'm not sure if we still try to stick to our C style (aka no

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > Make use of libklvanc from within the decklink capture module, > initially for EIA-708 and AFD. Support for other VANC types will > come in subsequent patches. > > Signed-off-by: Devin Heitmueller > --- >

Re: [FFmpeg-devel] [PATCH 6/6] decklink: Add support for SCTE-104 to decklink capture

On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > --- > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 6 > libavdevice/decklink_common.h | 6 > libavdevice/decklink_common_c.h | 1 + > libavdevice/decklink_dec.cpp| 64 >

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

On 11/16/2017 9:22 PM, Derek Buitenhuis wrote: > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + >> audio_offset; >> +for (int x = 0; x < pkt.size; x += sample_size) { > > I realize this is C++, but I'm not

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

On 11/17/2017 12:32 AM, Devin Heitmueller wrote: > I don’t have strong feelings either way. I’m happy to jam this into a > subsequent cleanup patch if nobody has an objection (it’s just much easier > since I have about 15 commits after this one in my Git tree). Looks like nobody is bothered,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

Hi, On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Nov 16, 2017 at 11:50 AM, Michael Niedermayer < > > mich...@niedermayer.cc> wrote: > > > > > On Thu, Nov 16, 2017

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

Excluded the fix for byte range issue and update some coding style issues. From: Colin NG Sent: November 15, 2017 10:58 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer

[FFmpeg-devel] [PATCH] ffmpeg_filter: use nb_threads=1 on unused filtergraph

Hello, Simple one-line patch to avoid creating threads on a filtergrpah which does not get used during execution. This saves a superfluous thread creation and tear-down cycle. Besides cleanliness, the main driver for this feature is a system I have access to with a large number of cores/threads.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

On Thu, Nov 16, 2017 at 07:47:55PM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer > wrote: > > > On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Thu, Nov 16, 2017 at 11:50 AM,

Re: [FFmpeg-devel] [PATCH 3/6] Preserve AFD side data when going from AVPacket to AVFrame

On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > This is needed to ensure that AFD data continues to work when > capturing V210 video with the Decklink libavdevice input. > > Signed-off-by: Devin Heitmueller > --- > libavcodec/decode.c | 1 + > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > +/* Active Format Description */ > +if (x4->afd) { > +void *sei_data; > +size_t sei_size; > + > +ret = ff_alloc_afd_sei(frame, 0, _data, _size); > +if (ret < 0) { > +

[FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

Signed-off-by: Jacob Trimble --- libavformat/mov.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d49d820d2b..c5f07595df 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6747,6 +6747,7 @@ static

Re: [FFmpeg-devel] [PATCH 6/6] decklink: Add support for SCTE-104 to decklink capture

> On Nov 16, 2017, at 7:35 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> --- >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 6 >> libavdevice/decklink_common.h | 6 >>

Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

On 11/17/2017 12:38 AM, Devin Heitmueller wrote: > For whatever reason, the spec explicitly calls for the country code to be set > to these values. Here’s the specific language from the spec: > > itu_t_t35_country_code – A fixed 8-bit field, the value of which shall be > 0xB5. >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: change license to LGPL

On 11/15/17, Carl Eugen Hoyos wrote: > 2017-11-14 23:35 GMT+01:00 Aman Gupta : >> From: Aman Gupta >> >> This filter was imported from mplayer's libmpcodecs/vf_cropdetect.c, and >> marked as GPL when originally copied over. >> >> On the mplayer

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

On 11/16/2017 3:34 PM, Devin Heitmueller wrote: > Make use of libklvanc from within the decklink capture module, > initially for EIA-708 and AFD. Support for other VANC types will > come in subsequent patches. > > Signed-off-by: Devin Heitmueller > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

On 11/16/2017 10:43 PM, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 07:47:55PM -0500, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer >> wrote: >> >>> On Thu, Nov 16, 2017 at 01:21:19PM -0500, Ronald S. Bultje wrote:

Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling warning

> Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling warning > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > Behalf > > Of Carl Eugen Hoyos > > Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling > > warning > > > > 2017-11-15 10:04

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

> 在 2017年11月16日，17:15，Dixit, Vishwanath 写道： > > >> On 11/16/17, 2:41 PM, "刘歧" wrote: >> >> Patchset LGTM, i will apply these patch after 24 hours if there have no >> objections > Thank you for the approval.. This is an awesome function, it is very

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

> 在 2017年11月16日，17:01，Dixit, Vishwanath 写道： > > > >> On 11/16/17, 12:09 PM, "刘歧" wrote: >> >> FATE test passed: Ubuntu, OS X, qemu+MIPS Linux, wine MingW, qemu+ARM >> Linux, Thanks. >> >> +if (p) { >> +strcpy(extension, p); >>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

>On 11/16/17, 2:41 PM, "刘歧" wrote: > >Patchset LGTM, i will apply these patch after 24 hours if there have no > objections Thank you for the approval.. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

how to use the feature On Thu, Nov 16, 2017 at 5:10 PM, 刘歧 wrote: > > > 在 2017年11月16日，17:01，Dixit, Vishwanath 写道： > > > > > > > >> On 11/16/17, 12:09 PM, "刘歧" wrote: > >> > >> FATE test passed: Ubuntu, OS X, qemu+MIPS Linux,

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

> 在 2017年11月16日，17:28，Bang He 写道： > > how to use the feature 1st, apply the patch into your ffmpeg project, 2nd, use the command looks like bellow: ./ffmpeg -f lavfi -i color=red -f lavfi –I anullsrc -g 25 -r 25 -b:v:0 1000k -b:v:1 256k -b:a:1 64k -b:a:1 32k -map 0:v