[FFmpeg-devel] [PATCH] Ignore libavcodec/tests/mpeg12framerate, a test program

2017-11-17 Thread Jim DeLaHunt
Add to libavcodec/tests/.gitignore an entry for test program libavcodec/tests/mpeg12framerate . Other similar test programs, e.g. jpeg2000dwt and dct, are ignored in a similar way. On initially checking out master, and doing "./configure" and "make clean", "git status" reports no untracked files.

Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 13:35 GMT+01:00 Paul B Mahol : > On 11/17/17, Carl Eugen Hoyos wrote: >> 2017-11-17 12:43 GMT+01:00 Paul B Mahol : >>> On 11/17/17, Carl Eugen Hoyos wrote: I believe attached patch is necessary to fix

Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling warning

2017-11-17 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Friday, November 17, 2017 6:06 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling warning > >

Re: [FFmpeg-devel] FFmpeg 3.4.1

2017-11-17 Thread Hendrik Leppkes
On Fri, Nov 17, 2017 at 5:00 AM, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 01:51:34PM +0100, Carl Eugen Hoyos wrote: >> 2017-11-16 13:44 GMT+01:00 Michael Niedermayer : >> > On Thu, Nov 16, 2017 at 01:04:27AM +0100, Carl Eugen Hoyos

[FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Carl Eugen Hoyos
Hi! I believe attached patch is necessary to fix ticket #6839 and several older bug reports. Missing version bump and APIchanges entry. Please review, Carl Eugen From 3c5966f992c4bf5e64cc1a4196eb90f804b65bf6 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 17 Nov

Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Paul B Mahol
On 11/17/17, Carl Eugen Hoyos wrote: > 2017-11-17 12:43 GMT+01:00 Paul B Mahol : >> On 11/17/17, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> I believe attached patch is necessary to fix ticket #6839 and several >>> older bug reports. >> >> No

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

2017-11-17 Thread Nicolas George
Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit : > I have done the change as suggested. Please find the new patch attached. Sorry, but I still have doubts about it. To begin with, -1 is not an acceptable error code. But what bothers me most is that on the two uses, one has an

Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 12:43 GMT+01:00 Paul B Mahol : > On 11/17/17, Carl Eugen Hoyos wrote: >> Hi! >> >> I believe attached patch is necessary to fix ticket #6839 and several >> older bug reports. > > No it is not neccessary. Because nothing uses it. libavcodec uses it

Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv_vpp: fix compiling warning

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 6:52 GMT+01:00 Li, Zhong : >> > 2017-11-15 10:04 GMT+01:00 Zhong Li : >> > > fix the compiling warning of "ignoring return value" >> > >> > > -ff_formats_ref(in_fmts, >inputs[0]->out_formats); >> > > -ff_formats_ref(out_fmts,

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 1:55 GMT+01:00 Colin NG : > Excluded the fix for byte range issue and update some coding style issues. > +if (pb) av_freep(pb); The if() should be unnecessary. Please avoid adding empty lines in unrelated parts of the file and while there, try to fix "if

[FFmpeg-devel] [PATCH] avformat/hlsenc: remove unused avio_open_dyn_buf call

2017-11-17 Thread Steven Liu
fix CID: 1421196 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index e0cef8b879..d39b65fddd 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1678,7 +1678,6

Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Paul B Mahol
On 11/17/17, Carl Eugen Hoyos wrote: > Hi! > > I believe attached patch is necessary to fix ticket #6839 and several > older bug reports. No it is not neccessary. Because nothing uses it. > > Missing version bump and APIchanges entry. > > Please review, Carl Eugen >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 11:13:27PM -0300, James Almer wrote: > On 11/16/2017 10:43 PM, Michael Niedermayer wrote: > > On Thu, Nov 16, 2017 at 07:47:55PM -0500, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Thu, Nov 16, 2017 at 4:41 PM, Michael Niedermayer > >> >>> wrote:

[FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- doc/APIchanges| 5 + libavresample/utils.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index d336f6ce22..22c7b5a0d0 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6

Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Hendrik Leppkes
On Fri, Nov 17, 2017 at 1:26 PM, Carl Eugen Hoyos wrote: > 2017-11-17 12:43 GMT+01:00 Paul B Mahol : >> On 11/17/17, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> I believe attached patch is necessary to fix ticket #6839 and several >>> older

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Ronald S. Bultje
Hi, On Fri, Nov 17, 2017 at 10:14 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > As a maintainer If a file fails with an error i want to know > what error it is. Why is this so hard or controversal ? Because *it doesn't happen* for real files. But you don't want to listen. You

Re: [FFmpeg-devel] Feature request

2017-11-17 Thread Paul B Mahol
On 11/17/17, Ben Hutchinson wrote: > I would like to be able to deinterlace a video by converting full-height > frames into half-height fields (where each frame of the output represents > one field of the input) at double the frame rate. The way this would work > is it would

[FFmpeg-devel] [PATCH] lavf/mov: don't read outside frag_index bounds

2017-11-17 Thread John Stebbins
Potentially fixes: https://bugs.chromium.org/p/chromium/issues/detail?id=786269#c1 In theory, the crash can be triggered by an invalid stream that has either tfdt or trun outside of the moof --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c

[FFmpeg-devel] [PATCH] Allow "-to" on input files as well

2017-11-17 Thread vi0oss
From: Vitaly _Vi Shukela --- Notes: Second version. Please CC vi0...@gmail.com when replying. Note that added code is a duplicate of the respective output option processing code. I'm not sure if it is worth factoring out. doc/ffmpeg.texi | 4

[FFmpeg-devel] Feature request

2017-11-17 Thread Ben Hutchinson
I would like to be able to deinterlace a video by converting full-height frames into half-height fields (where each frame of the output represents one field of the input) at double the frame rate. The way this would work is it would take the top field (or bottom field) first and export it as the

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/{http, tls}: enable tcp_nodelay

2017-11-17 Thread Aman Gupta
On Wed, Nov 15, 2017 at 6:21 PM, Aman Gupta wrote: > > > On Wed, Nov 15, 2017 at 2:35 AM, Jeyapal, Karthick > wrote: > >> >Hmm, I guess if we want this to propagate down we need to add the option >> to the tls protocol as well, then pass it down when it

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 10:28:49AM -0500, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 17, 2017 at 10:14 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > As a maintainer If a file fails with an error i want to know > > what error it is. Why is this so hard or controversal ? > >

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 03:07:54PM -0800, Nick Lewycky wrote: > Sorry! Let's try an attachment then. > > On 16 November 2017 at 14:36, Michael Niedermayer > wrote: > > On Thu, Nov 16, 2017 at 12:41:32PM -0800, Nick Lewycky wrote: > >> I initially discovered a signed

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

2017-11-17 Thread James Almer
On 11/17/2017 4:16 PM, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 03:07:54PM -0800, Nick Lewycky wrote: >> Sorry! Let's try an attachment then. >> >> On 16 November 2017 at 14:36, Michael Niedermayer >> wrote: >>> On Thu, Nov 16, 2017 at 12:41:32PM -0800, Nick

[FFmpeg-devel] [PATCH] dvenc: Prevent out-of-bounds read

2017-11-17 Thread Derek Buitenhuis
mb_area_start has 5 entries, and 'a' is iterated through from 0 to 3. 'a2' is set to 'a + 1', and mb_area_start[a2 + 1] is accessed, so if a is 3, then we try to access mb_area_start[5]. Signed-off-by: Derek Buitenhuis --- I'm not 100% sure if this fix is /correct/,

Re: [FFmpeg-devel] [PATCH] dvenc: Prevent out-of-bounds read

2017-11-17 Thread Martin Vignali
2017-11-17 17:20 GMT+01:00 Derek Buitenhuis : > mb_area_start has 5 entries, and 'a' is iterated through from 0 to 3. > 'a2' is set to 'a + 1', and mb_area_start[a2 + 1] is accessed, so if > a is 3, then we try to access mb_area_start[5]. > > Signed-off-by: Derek

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread Rostislav Pehlivanov
On 17 November 2017 at 17:51, Carl Eugen Hoyos wrote: > 2017-11-17 16:58 GMT+01:00 Rostislav Pehlivanov : > > > +2017-xx-xx - xxx - lavr 4.0.0 - avresample.h > > + Deprecate the entire library. It was unmaintained and redundant > > + as

Re: [FFmpeg-devel] [PATCH] dvenc: Prevent out-of-bounds read

2017-11-17 Thread Derek Buitenhuis
On 11/17/2017 5:37 PM, Michael Niedermayer wrote: > hmm, i cant really remember this clearly but from looking at the code > it looks like this is the logic: > b->next[k] < 64 > b->next[k] >= mb_area_start[a + 1] implies mb_area_start[a + 1] < 64 > which implies a < 3 > and a2 < 4 on the first

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread James Almer
On 11/17/2017 12:58 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/APIchanges| 5 + > libavresample/utils.c | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/doc/APIchanges b/doc/APIchanges > index

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread Rostislav Pehlivanov
On 17 November 2017 at 17:53, James Almer wrote: > On 11/17/2017 12:58 PM, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > doc/APIchanges| 5 + > > libavresample/utils.c | 3 +++ > > 2 files changed, 8

Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 06:27:38PM -0500, Dave Rice wrote: > > > On Nov 16, 2017, at 6:08 PM, Carl Eugen Hoyos wrote: > > > > 2017-11-16 17:54 GMT+01:00 Dave Rice : > > > >> +if (track->mode == MODE_MOV && track->par->codec_id == > >>

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 16:58 GMT+01:00 Rostislav Pehlivanov : > +2017-xx-xx - xxx - lavr 4.0.0 - avresample.h > + Deprecate the entire library. It was unmaintained and redundant > + as libswresample did everything it did better, faster, with more > + control and with a better,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Nicolas George
Le septidi 27 brumaire, an CCXXVI, Ronald S. Bultje a écrit : > Because *it doesn't happen* for real files. Then why do you want it gone? Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] dvenc: Prevent out-of-bounds read

2017-11-17 Thread Derek Buitenhuis
On 11/17/2017 4:42 PM, Martin Vignali wrote: > doesn't know the dvenc code, > but you seems to test the assert of the next line > > Maybe move the assert (a2 < 4); before the for loop, if it's a theorical > case, > or remove it if this case can really happen. I don't see anything that would

Re: [FFmpeg-devel] fate/hapdec : add test for hap alpha only

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 11:45:41PM +0100, Martin Vignali wrote: > > > > New patch in attach (use gray8 pix_fmt) > > Need to be apply after patch in discussion > > avcodec/hapdec : use gray8 for HapAlphaOnly decoding instead of RGB0 > > > > Martin > > > > With the attachment > fate/video.mak

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowdec: Check for remaining bitstream in decode_blocks()

2017-11-17 Thread Michael Niedermayer
On Wed, Nov 15, 2017 at 09:17:16PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 3142/clusterfuzz-testcase-5007853163118592 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 12:14:30PM -0500, Dave Rice wrote: > > > On Nov 16, 2017, at 11:30 AM, Dave Rice wrote: > > > >> On Jul 9, 2017, at 7:26 PM, Dave Rice wrote: > >> > >>> On Jul 7, 2017, at 7:06 PM, Derek Buitenhuis > >>>

Re: [FFmpeg-devel] [PATCH] Download dash content with byte range info

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 08:33:35PM +, Colin NG wrote: > --- > libavformat/dashdec.c | 32 +--- > 1 file changed, 25 insertions(+), 7 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 0e3afd2..33255f2 100644 > ---

Re: [FFmpeg-devel] [PATCH] dvenc: Prevent out-of-bounds read

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 04:20:55PM +, Derek Buitenhuis wrote: > mb_area_start has 5 entries, and 'a' is iterated through from 0 to 3. > 'a2' is set to 'a + 1', and mb_area_start[a2 + 1] is accessed, so if > a is 3, then we try to access mb_area_start[5]. > > Signed-off-by: Derek Buitenhuis

Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Nicolas George
Le septidi 27 brumaire, an CCXXVI, Carl Eugen Hoyos a écrit : > Hi! > > I believe attached patch is necessary to fix ticket #6839 and several > older bug reports. > > Missing version bump and APIchanges entry. > > Please review, Carl Eugen As is, no, it is just code connected with nothing.

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-17 Thread Dale Curtis
Derp, actually, 2 << 63 doesn't fit in int64_t either, this check should be < 63. Fixed. On Fri, Nov 17, 2017 at 1:38 PM, Dale Curtis wrote: > 2 << (wrap_bits=64 - 1) does not fit in int64_t; apply the check > used in other places that handle wrap bits to ensure the

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

2017-11-17 Thread James Almer
On 11/17/2017 4:20 PM, James Almer wrote: > On 11/17/2017 4:16 PM, Michael Niedermayer wrote: >> On Thu, Nov 16, 2017 at 03:07:54PM -0800, Nick Lewycky wrote: >>> Sorry! Let's try an attachment then. >>> >>> On 16 November 2017 at 14:36, Michael Niedermayer >>> wrote:

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-17 Thread James Zern
On Mon, Nov 13, 2017 at 4:01 PM, James Zern wrote: > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 20 > 2 files changed, 22 insertions(+) > Applied with an additional note in the commit

[FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 4 libavfilter/vf_tile.c | 18 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 5d99437871..7eeeafab8e 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH] lavf/mov: don't read outside frag_index bounds

2017-11-17 Thread Dale Curtis
lgtm, fixes the crash and doesn't regress any of our tests. - dale On Fri, Nov 17, 2017 at 8:21 AM, John Stebbins wrote: > Potentially fixes: > https://bugs.chromium.org/p/chromium/issues/detail?id=786269#c1 > > In theory, the crash can be triggered by an invalid

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 05:10:17PM -0300, James Almer wrote: > On 11/17/2017 4:20 PM, James Almer wrote: > > On 11/17/2017 4:16 PM, Michael Niedermayer wrote: > >> On Thu, Nov 16, 2017 at 03:07:54PM -0800, Nick Lewycky wrote: > >>> Sorry! Let's try an attachment then. > >>> > >>> On 16 November

[FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-17 Thread Dale Curtis
2 << (wrap_bits=64 - 1) does not fit in int64_t; apply the check used in other places that handle wrap bits to ensure the values are <= 63. Signed-off-by: Dale Curtis From c566067623760a24f729ac5197c20531b9e518ae Mon Sep 17 00:00:00 2001 From: Dale Curtis

Re: [FFmpeg-devel] [PATCH]lavfi/buffersrc: Add AVBufferSrcParameters->bits_per_raw_sample parameter.

2017-11-17 Thread Paul B Mahol
On 11/17/17, Carl Eugen Hoyos wrote: > 2017-11-17 13:35 GMT+01:00 Paul B Mahol : >> On 11/17/17, Carl Eugen Hoyos wrote: >>> 2017-11-17 12:43 GMT+01:00 Paul B Mahol : On 11/17/17, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] Download dash content with byte range info

2017-11-17 Thread Colin NG
Fixed the range_val leak problem. From: ffmpeg-devel on behalf of Michael Niedermayer Sent: November 17, 2017 12:15 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-17 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/mov.c| 52 tests/fate/mov.mak | 5 tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ 4 files changed, 63 insertions(+)

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-17 Thread Sasi Inguva
restricted the patch to MPEG based codecs. Also, setting the delay only if it's not set already and capping the max. value to 16. On Wed, Nov 15, 2017 at 5:55 AM, Michael Niedermayer wrote: > On Tue, Nov 14, 2017 at 03:36:49PM -0800, Thierry Foucu wrote: > > On Tue, Nov

Re: [FFmpeg-devel] [PATCH] avcodec/dirac_dwt: Fix integer overflow in COMPOSE_DD137iL0()

2017-11-17 Thread Michael Niedermayer
On Tue, Nov 14, 2017 at 04:20:03AM +0100, Michael Niedermayer wrote: > Fixes: 4035/clusterfuzz-testcase-minimized-6479308925173760 > Fixes: runtime error: signed integer overflow: 9 * 402653183 cannot be > represented in type 'int' > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

2017-11-17 Thread Michael Niedermayer
On Fri, Oct 27, 2017 at 10:09:12PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 3200/clusterfuzz-testcase-5750022136135680 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Check that the buffer is large enough for mvec

2017-11-17 Thread Michael Niedermayer
On Wed, Nov 15, 2017 at 05:29:24PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 4143/clusterfuzz-testcase-4736864637419520 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c index 1eca97a081..36f915a8e5 100644 --- a/libavcodec/libvpx.c +++ b/libavcodec/libvpx.c @@ -40,9 +40,7 @@

[FFmpeg-devel] [PATCH 4/4] libvpxenc: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpxenc.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index fbb842499b..0258396d08 100644 --- a/libavcodec/libvpxenc.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/mlpdsp: Fix undefined shift ff_mlp_pack_output()

2017-11-17 Thread Michael Niedermayer
On Wed, Nov 15, 2017 at 04:25:45AM +0100, Michael Niedermayer wrote: > Fixes: runtime error: left shift of negative value -7862264 > Fixes: 4074/clusterfuzz-testcase-minimized-4516104123711488 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-17 Thread Moritz Barsnick
On Thu, Nov 16, 2017 at 16:28:22 -0800, Jacob Trimble wrote: > -if (mov_read_default(mov, s->pb, (MOVAtom){ AV_RL32("root"), INT64_MAX > }) < 0 || > -avio_feof(s->pb)) > +if ((ret = mov_read_default(mov, s->pb, (MOVAtom){ AV_RL32("root"), > INT64_MAX })) < 0) > +return

[FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpxdec.c | 25 - 1 file changed, 25 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index ad0ea3b02a..2ae29d202a 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvpxdec.c @@

[FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-17 Thread James Zern
this will simplify libvpxenc/dec.c and ensure more stable versions of the codecs are present. Signed-off-by: James Zern --- configure | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/configure b/configure index c8e2e35192..bfb1d9ab3a

Re: [FFmpeg-devel] FFmpeg 3.4.1

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 09:55:47AM +0100, Hendrik Leppkes wrote: > On Fri, Nov 17, 2017 at 5:00 AM, Michael Niedermayer > wrote: > > On Thu, Nov 16, 2017 at 01:51:34PM +0100, Carl Eugen Hoyos wrote: > >> 2017-11-16 13:44 GMT+01:00 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] Ignore libavcodec/tests/mpeg12framerate, a test program

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 01:45:27AM -0800, Jim DeLaHunt wrote: > Add to libavcodec/tests/.gitignore an entry for test > program libavcodec/tests/mpeg12framerate . Other > similar test programs, e.g. jpeg2000dwt and dct, are > ignored in a similar way. > > On initially checking out master, and

Re: [FFmpeg-devel] [PATCH] lavf/mov: don't read outside frag_index bounds

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 12:23:11PM -0800, Dale Curtis wrote: > lgtm, fixes the crash and doesn't regress any of our tests. will apply unless it breaks something in testing thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-17 Thread Michael Niedermayer
On Fri, Nov 17, 2017 at 04:07:42PM -0800, Dale Curtis wrote: > decode_user_data() attempts to create an integer |build| > value with 8 bits of spacing for 3 components. However > each component is an int32_t, so shifting each component > is undefined for values outside of the 8 bit range. > >

Re: [FFmpeg-devel] [PATCH]lavf/tcp: Fix type of argument optlen to getsockopt()

2017-11-17 Thread Michael Niedermayer
On Sun, Nov 12, 2017 at 03:29:21PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a warning on aix here. > > Please comment, Carl Eugen > tcp.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > fa136707423e2f36ee2400c37c2d9fefb027fe80 >

[FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-17 Thread Dale Curtis
decode_user_data() attempts to create an integer |build| value with 8 bits of spacing for 3 components. However each component is an int32_t, so shifting each component is undefined for values outside of the 8 bit range. This patch simply clamps input to 8-bits per component. Signed-off-by: Dale

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-17 Thread Colin NG
Cleaned the code up. From: ffmpeg-devel on behalf of Carl Eugen Hoyos Sent: November 17, 2017 5:24 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [Patch] Fix for ticket 6658

Re: [FFmpeg-devel] ffmpeg for CentOS 7 tutorial is broken

2017-11-17 Thread Douglas Wire
This is using the procedure right off of the webpage tutorial and it does not appear it even created an OPUS.pc anywhere. BEGIN /tmp/ffconf.zdwwNVl9/test.c 1#include 2#include 3long check_lame_set_VBR_quality(void) { return (long) lame_set_VBR_quality; } 4int

Re: [FFmpeg-devel] [PATCH]lavf/tcp: Fix type of argument optlen to getsockopt()

2017-11-17 Thread Carl Eugen Hoyos
2017-11-12 15:29 GMT+01:00 Carl Eugen Hoyos : > Hi! > > Attached patch fixes a warning on aix here. Ping. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/dnxhddata: Improve help output for yuv444p10 and gbrp10

2017-11-17 Thread Carl Eugen Hoyos
2017-11-14 18:19 GMT+01:00 Carl Eugen Hoyos : > Hi! > > Attached patch fixes ticket #6836 here. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] ffmpeg for CentOS 7 tutorial is broken

2017-11-17 Thread grady player
do you have a opus build? on my build system opus.pc is in the root of opus-1.1 if that is the case for your system you should be able to set: export PKG_CONFIG_PATH=/path/to/opus then rebuild if you have multiple paths for pc files you can separate them with a colon `export

[FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000: Dynamically allocate codeblock data

2017-11-17 Thread Michael Niedermayer
Fixes: OOM Fixes: 3541/clusterfuzz-testcase-minimized-6469958596820992 Adds support for decoding codeblock data larger than 8kb Reduces decoder memory consumption Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 1/2] avcodec/hevcdsp_template: Fix invalid shift in put_hevc_epel_bi_w_v()

2017-11-17 Thread Michael Niedermayer
Fixes: runtime error: left shift of negative value -255 Fixes: 4037/clusterfuzz-testcase-minimized-5290998163832832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_cropdetect: don't ignore frames, export crop parameters

2017-11-17 Thread Aman Gupta
From: Aman Gupta --- libavfilter/vf_cropdetect.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_cropdetect.c b/libavfilter/vf_cropdetect.c index 7c7d0b953a..87ecb2a6ec 100644 --- a/libavfilter/vf_cropdetect.c +++

Re: [FFmpeg-devel] ffmpeg for CentOS 7 tutorial is broken

2017-11-17 Thread Douglas Wire
It just moves on to VORBUS for which I have libvorbis compiled. How about I set up a new VM and follow the tutorial exactly as I have 50 times and we work off of that. I can take a snapshot so I can return to a spot with all other prerequisites but no ffmpeg present and can follow along with the

[FFmpeg-devel] [PATCH 3/3] ffmpeg: apply frame cropping between filter graph and encoder

2017-11-17 Thread Aman Gupta
From: Aman Gupta --- fftools/ffmpeg.c | 4 1 file changed, 4 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index babd85f7bc..159b8e0016 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1265,6 +1265,10 @@ static void do_video_out(OutputFile *of,

[FFmpeg-devel] [RFC] changing resolution via video filter

2017-11-17 Thread Aman Gupta
From: Aman Gupta This patchset is not intended to be merged, rather to start a discussion about some limitations of the current filter graph design in ffmpeg.c My goal here is to create preview images for a video stream with ffmpeg, with black bars automatically cropped out.

[FFmpeg-devel] [PATCH 1/3] avcodec/j2kenc: reinitialize state if frame size changes

2017-11-17 Thread Aman Gupta
From: Aman Gupta --- libavcodec/j2kenc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c index 2135ece540..1eb091af3b 100644 --- a/libavcodec/j2kenc.c +++ b/libavcodec/j2kenc.c @@ -995,7 +995,15 @@

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 1:47 GMT+01:00 Ronald S. Bultje : > stop being difficult. Yes please! I have no idea what's driving you but please stop this childish attitude: You haven't answered to a bug report since an eternity, so you simply cannot claim that error messages are unneeded.

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolbox: fix decoding of h264 streams with minor SPS changes

2017-11-17 Thread Aman Gupta
On Wed, Nov 15, 2017 at 1:57 PM, Hendrik Leppkes wrote: > On Wed, Nov 15, 2017 at 10:15 PM, Aman Gupta wrote: > > From: Aman Gupta > > > > Previously the codec kept an entire copy of the SPS, and restarted the > VT decoder > > session

[FFmpeg-devel] [PATCH] Download dash content with byte range info

2017-11-17 Thread Colin NG
--- libavformat/dashdec.c | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 0e3afd2..671ae9d 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -522,6 +522,25 @@ static

[FFmpeg-devel] [mov] Fix leak of frame_duration_buffer in mov_fix_index().

2017-11-17 Thread Dale Curtis
Should be unconditionally freed at the end of mov_fix_index() in case it hasn't been used during the fix up. Signed-off-by: Dale Curtis From bbdf90542a98bb297d4143949e3281500815d0b1 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 17 Nov

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolbox: fix decoding of h264 streams with minor SPS changes

2017-11-17 Thread Hendrik Leppkes
On Fri, Nov 17, 2017 at 11:44 PM, Aman Gupta wrote: > On Wed, Nov 15, 2017 at 1:57 PM, Hendrik Leppkes > wrote: > >> On Wed, Nov 15, 2017 at 10:15 PM, Aman Gupta wrote: >> > From: Aman Gupta >> > >> > Previously the codec

[FFmpeg-devel] ffmpeg for CentOS 7 tutorial is broken

2017-11-17 Thread Douglas Wire
I spent a week or so at one point making a set of one liners to install ffmpeg with a bunch of encoder support and since I need ffmpeg-php support I was compiling as shared. Now nothing I wrote works and if you run the tutorial it fails with pckg-config errors and refuses to compile. Can someone

Re: [FFmpeg-devel] ffmpeg for CentOS 7 tutorial is broken

2017-11-17 Thread grady player
if you post the output of failed build step, someone might have some insight... but just saying everything is broken isn't likely going to go anywhere. if you are having problems with ffmpeg-php you may want to contact their maintainers https://github.com/PHP-FFMpeg/PHP-FFMpeg/issues -grady

Re: [FFmpeg-devel] [PATCH] hwcontext_d3d11va: add missing stdint.h include

2017-11-17 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [mpegaudio] Use ff_thread_once for fixed, float table init.

2017-11-17 Thread Dale Curtis
These tables are static so they should only be initialized once instead of on every call to ff_mpadsp_init(). Signed-off-by: Dale Curtis From 70ffbeb41f0432c72701f6147385e9aa47bf8419 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 17 Nov

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolbox: fix decoding of h264 streams with minor SPS changes

2017-11-17 Thread Aman Gupta
On Fri, Nov 17, 2017 at 3:14 PM Hendrik Leppkes wrote: > On Fri, Nov 17, 2017 at 11:44 PM, Aman Gupta wrote: > > On Wed, Nov 15, 2017 at 1:57 PM, Hendrik Leppkes > > wrote: > > > >> On Wed, Nov 15, 2017 at 10:15 PM, Aman Gupta

Re: [FFmpeg-devel] [PATCH] Allow "-to" on input files as well

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 11:15:11PM +0300, vi0...@gmail.com wrote: > From: Vitaly _Vi Shukela > > --- > > Notes: > Second version. > > Please CC vi0...@gmail.com when replying. > > Note that added code is a duplicate of the respective output option >

Re: [FFmpeg-devel] [PATCH] Allow "-to" on input files as well

2017-11-17 Thread Michael Niedermayer
On Sat, Nov 18, 2017 at 03:54:20AM +0100, Michael Niedermayer wrote: > On Thu, Nov 16, 2017 at 11:15:11PM +0300, vi0...@gmail.com wrote: > > From: Vitaly _Vi Shukela > > > > --- > > > > Notes: > > Second version. > > > > Please CC vi0...@gmail.com when replying. >