[FFmpeg-devel] [PATCH 12/17] vaapi_decode: Ignore the profile when not useful

2017-11-23 Thread Mark Thompson
Enables VP8 decoding - the decoder places the the bitstream version in the profile field, which we want to ignore. --- libavcodec/vaapi_decode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index d36ef906a2..572b3a40ac

[FFmpeg-devel] [PATCH 13/17] lavc/mjpeg: Add profiles for MJPEG using SOF marker codes

2017-11-23 Thread Mark Thompson
This is needed by later hwaccel code to tell which encoding process was used for a particular frame, because hardware decoders may only support a subset of possible methods. --- libavcodec/avcodec.h | 6 ++ libavcodec/mjpegdec.c | 7 +++ 2 files changed, 13 insertions(+) diff --git

[FFmpeg-devel] [PATCH 04/17] lavc: Deprecate av_hwaccel_next() and av_register_hwaccel()

2017-11-23 Thread Mark Thompson
--- doc/APIchanges | 4 libavcodec/avcodec.h | 14 +- libavcodec/utils.c | 16 +--- libavcodec/version.h | 3 +++ 4 files changed, 25 insertions(+), 12 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 704efe1719..a3afa8b2a6 100644 ---

[FFmpeg-devel] [PATCH 01/17] lavc: Add codec metadata to indicate hardware support

2017-11-23 Thread Mark Thompson
--- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 74 libavcodec/hwaccel.h | 18 + libavcodec/utils.c | 12 + 4 files changed, 107 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index

[FFmpeg-devel] [PATCH 05/17] lavc: Remove register mechanism for hwaccels

2017-11-23 Thread Mark Thompson
There is no longer any need for a list of them at runtime, because decoders now carry the pointers to their associated hwaccels internally. The file containing external declarations is now used to make the list of hwaccels for configure. --- configure | 2 +- libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v3 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-23 Thread Karthick J
--- libavformat/hlsenc.c | 238 +++ libavformat/hlsenc.h | 68 +++ 2 files changed, 194 insertions(+), 112 deletions(-) create mode 100644 libavformat/hlsenc.h diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index

Re: [FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-23 Thread Jun Zhao
On 2017/11/24 8:51, Mark Thompson wrote: > Also adds some extra fields to the main context structure that may > be needed by a hwaccel decoder. > --- > The YUVJ formats really mess with this. This patch hacks them out so that > the hwaccel works, suggestions welcome on what to actually do

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-23 Thread Jeyapal, Karthick
I have rebased the below patch for latest master and have sent a new patch v3. Regards, Karthick On 11/22/17, 2:50 PM, "Karthick J" wrote: --- libavformat/hlsenc.c | 237 +++ libavformat/hlsenc.h | 67 +++ 2

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-23 Thread James Almer
On 11/22/2017 7:59 PM, Hendrik Leppkes wrote: > On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos wrote: >> 2017-11-22 21:00 GMT+01:00 Michael Niedermayer : >> >>> diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c >>> index

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-23 Thread 刘歧
> 在 2017年11月24日,11:55,Karthick J 写道: > > --- > libavformat/hlsenc.c | 238 +++ > libavformat/hlsenc.h | 68 +++ > 2 files changed, 194 insertions(+), 112 deletions(-) > create mode 100644 libavformat/hlsenc.h > >

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-23 Thread Jeyapal, Karthick
>On 11/24/17, 9:44 AM, "刘歧" wrote: > > >> 在 2017年11月24日,11:55,Karthick J 写道: >> >> --- >> libavformat/hlsenc.c | 238 >> +++ >> libavformat/hlsenc.h | 68 +++ >> 2 files changed, 194

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

2017-11-23 Thread Tobias Rapp
On 23.11.2017 00:10, Derek Buitenhuis wrote: On 11/22/2017 10:52 PM, Carl Eugen Hoyos wrote: start_line = fields * (i ^ (par->field_order == AV_FIELD_BB || par->field_order == AV_FIELD_BT)); Which are imo less ugly. Can't agree. It's needlessly less readable bit fiddling. +1 It may save

[FFmpeg-devel] [PATCH 09/17] vaapi: Make the decode profile matching more explicit

2017-11-23 Thread Mark Thompson
Also fixes a bug where it could attempt to decode with an unsupported codec if allow-profile-mismatch was set. --- libavcodec/vaapi_decode.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index

[FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-23 Thread Mark Thompson
--- This works nicely on the Intel driver for YUV 4:2:2 (like you usually get from UVC webcams) with ffmpeg via hw_device_ctx, but YUV 4:2:0 requires trickier surface setup because it doesn't work on normal NV12 surfaces. It can be used via hw_frames_ctx by making the right surfaces

[FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-23 Thread Mark Thompson
Also adds some extra fields to the main context structure that may be needed by a hwaccel decoder. --- The YUVJ formats really mess with this. This patch hacks them out so that the hwaccel works, suggestions welcome on what to actually do about them. libavcodec/mjpegdec.c | 70

[FFmpeg-devel] [PATCH 10/17] vp8: Add hwaccel hooks

2017-11-23 Thread Mark Thompson
Also adds some extra fields to the main context structure that may be needed by a hwaccel decoder. The current behaviour of the WebP decoder is maintained by adding an additional field to the VP8 decoder private context to indicate that it is actually being used as WebP (no hwaccel is supported

[FFmpeg-devel] [PATCH 17/17] hwcontext_vaapi: Do not assume that sw_format is transferable

2017-11-23 Thread Mark Thompson
Drivers can support a format for surfaces without also supporting it for images, so we can't assume that sw_format is usable for transfer. This would previously hit an assert in cases where it isn't. --- libavutil/hwcontext_vaapi.c | 21 ++--- 1 file changed, 14 insertions(+), 7

[FFmpeg-devel] [PATCH 16/17] hwcontext_vaapi: Move better-matching surface formats earlier

2017-11-23 Thread Mark Thompson
In particular, avoid selecting YV12/YV16 when I420/422H are available. --- libavutil/hwcontext_vaapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index fcff25dc9b..2f47162a0d 100644 ---

[FFmpeg-devel] [PATCH 03/17] lavc: Use hardware config information in ff_get_format()

2017-11-23 Thread Mark Thompson
This removes the dependency that hardware pixel formats previously had on AVHWAccel instances, meaning only those which actually do something need exist after this patch. Also updates avcodec_default_get_format() to be able to choose hardware formats if either a matching device has been supplied

[FFmpeg-devel] [PATCH 02/17] lavc: Add hardware config metadata for decoders supporting hardware output

2017-11-23 Thread Mark Thompson
This includes a pointer to the associated hwaccel for decoders using hwaccels - these will be used later to implement the hwaccel setup without needing a global list. Also added is a new file listing all hwaccels as external declarations - this will be used later to generate the hwaccel list at

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 8:34 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 13:56 GMT+01:00 Jeyapal, Karthick : >> >> On 11/23/17, 5:33 PM, "Carl Eugen Hoyos" wrote: >> >>>2017-11-23 12:47 GMT+01:00 Jeyapal, Karthick : On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: Refactor an inconsistent variable name

2017-11-23 Thread Jeyapal, Karthick
Thanks for pushing this patchset. Regards, Karthick On 11/22/17, 1:43 PM, "刘歧" wrote: > 在 2017年11月22日,16:08,Karthick J 写道: > > --- > libavformat/hlsenc.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 08/17] ffmpeg: Use codec hardware config to configure hwaccels

2017-11-23 Thread Mark Thompson
Removes specific support for all hwaccels supported by the generic code (DXVA2, D3D11VA, NVDEC, VAAPI, VDPAU and videotoolbox). --- fftools/ffmpeg.c | 77 +++- fftools/ffmpeg.h | 10 +-- fftools/ffmpeg_hw.c | 244 +++

[FFmpeg-devel] [PATCH 11/17] vaapi: Add VP8 decode hwaccel

2017-11-23 Thread Mark Thompson
--- configure | 3 + libavcodec/Makefile| 1 + libavcodec/hwaccels.h | 1 + libavcodec/vaapi_vp8.c | 237 + libavcodec/vp8.c | 6 ++ 5 files changed, 248 insertions(+) create mode 100644 libavcodec/vaapi_vp8.c diff

[FFmpeg-devel] [PATCH 06/17] lavc: Delete all fake hwaccels

2017-11-23 Thread Mark Thompson
They are now unused. --- configure | 32 + libavcodec/cuviddec.c | 6 -- libavcodec/mediacodec.c | 2 +- libavcodec/mediacodecdec_common.c | 42 --- libavcodec/mmaldec.c

[FFmpeg-devel] [PATCH 07/17] lavc: Mark all AVHWAccel structures as const

2017-11-23 Thread Mark Thompson
--- libavcodec/avcodec.h| 2 +- libavcodec/decode.c | 2 +- libavcodec/dxva2_h264.c | 6 +-- libavcodec/dxva2_hevc.c | 6 +-- libavcodec/dxva2_mpeg2.c| 6 +-- libavcodec/dxva2_vc1.c | 12 +++--- libavcodec/dxva2_vp9.c | 6 +-- libavcodec/hwaccels.h

[FFmpeg-devel] [PATCH] hwcontext_d3d11va: properly reset values after release/close

2017-11-23 Thread Jan Ekström
Makes the uninit function re-entrable, which can be a common case when an API user first tries to initialize its context, fails, and then finally unrefs the AVHWDevice. Fixes a crash reported by sm2345 on IRC. --- libavutil/hwcontext_d3d11va.c | 21 - 1 file changed, 16

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-23 Thread Jeyapal, Karthick
On 11/24/17, 5:17 AM, "Carl Eugen Hoyos" wrote: >2017-11-23 22:58 GMT+01:00 Michael Niedermayer : >> On Thu, Nov 23, 2017 at 04:01:06PM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> The (external) encoders may overwrite level and profile because of

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Jeyapal, Karthick
On 11/24/17, 4:31 AM, "Steven Liu" wrote: >Pushed Thanks. > > >Thanks regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2 v2] avformat/flacenc: add flac_init() and flac_deinit()

2017-11-23 Thread James Almer
Signed-off-by: James Almer --- Simpler/smaller diff. libavformat/flacenc.c | 50 +- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 84da54a1df..d5fcf96b6b

[FFmpeg-devel] [PATCH v4 2/2] avformat/dashenc: Option to generate hls playlist as well

2017-11-23 Thread Karthick J
This is to take full advantage of Common Media Application Format. Now server can generate one content and serve both HLS and DASH players. --- doc/muxers.texi | 3 ++ libavformat/Makefile | 2 +- libavformat/dashenc.c | 103 -- 3 files

[FFmpeg-devel] [PATCH v4 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-23 Thread Karthick J
--- libavformat/Makefile | 2 +- libavformat/hlsenc.c | 115 +++ libavformat/hlsplaylist.c | 136 ++ libavformat/hlsplaylist.h | 51 + 4 files changed, 209 insertions(+), 95 deletions(-)

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 9:40 GMT+01:00 Tobias Rapp : > On 22.11.2017 23:52, Carl Eugen Hoyos wrote: >> >> 2017-11-22 16:41 GMT+01:00 Tobias Rapp : >>> >>> Writes one set of field framing information for progressive streams and >>> two sets for interlaced streams.

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-23 Thread Jerome Martinez
On 12/11/2017 03:12, Carl Eugen Hoyos wrote: The matroska spec says blockduration == 0 means the frame is not a keyframe. Since all subtitles are "keyframes", 0 blockduration should not be written. As I understand from discussion on CELLAR mailing-list: - if is not expected to have a frame

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Karthick J
--- doc/muxers.texi | 4 libavformat/hlsenc.c | 17 + 2 files changed, 21 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0bb8ad2..9d9ca31 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -737,6 +737,10 @@ The file specified by

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 6:05 GMT+01:00 Karthick J : > +if (hls->flags & HLS_SPLIT_BY_TIME) { > +// Independent segments cannot be guaranteed when splitting by time > +hls->flags &= ~HLS_INDEPENDENT_SEGMENTS; Shouldn't this show a warning? Carl Eugen

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 2:15 GMT+01:00 Marton Balint : > All your points apply to Nvidia external headers as well The Nvidia driver works on Linux where self-compilation is at least not unusual. Self compiled binaries by Windows users are very rare, the one script that is typically used in

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 12:21 GMT+01:00 Karthick J : > +if (hls->flags & HLS_SPLIT_BY_TIME) { > +// Independent segments cannot be guaranteed when splitting by time > +hls->flags &= ~HLS_INDEPENDENT_SEGMENTS; > +av_log(s, AV_LOG_WARNING, > +

[FFmpeg-devel] [PATCH v3] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Karthick J
--- doc/muxers.texi | 4 libavformat/hlsenc.c | 17 + 2 files changed, 21 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0bb8ad2..9d9ca31 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -737,6 +737,10 @@ The file specified by

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc:addition of #EXT-X-MEDIA tag and AUDIO attribute

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 4:37 GMT+01:00 : > +av_strlcpy(m3U8_rel_name, vs->m3u8_name, m3u8_name_size); > +ret = get_relative_url(hls->master_m3u8_url, vs->m3u8_name, > + m3U8_rel_name, m3u8_name_size); > +if (ret < 0) { > +

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-23 Thread Carl Eugen Hoyos
2017-11-22 23:36 GMT+01:00 Timo Rothenpieler : > Also, I don't see a problem with including this AMD header. It very much > increases the accessibility and maintainability > (no need to watch out for potential breaking upstream changes, however > likely that might be). If

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 4:13 PM, "Carl Eugen Hoyos" wrote: > >2017-11-23 6:05 GMT+01:00 Karthick J : > >> +if (hls->flags & HLS_SPLIT_BY_TIME) { >> +// Independent segments cannot be guaranteed when splitting by time >> +hls->flags &=

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-23 Thread Jeyapal, Karthick
>From: Aman Gupta >On Wed, Nov 22, 2017 at 7:38 PM wrote: >>From: Vishwanath Dixit >> >>Signed-off-by: Karthick J > >LGTM. > >Have you looked at adding HEVC support? Thanks for the reply. From our side, there are no

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 4:37 GMT+01:00 : > +s = x264_encoder_headers(x4->enc, , ); > +if (avctx->profile == FF_PROFILE_UNKNOWN) > +avctx->profile = nal->p_payload[5]; > +if (avctx->level == FF_LEVEL_UNKNOWN) > +avctx->level = nal->p_payload[7]; Why are these

Re: [FFmpeg-devel] [PATCH] Refactor Developer Docs, update dev list section

2017-11-23 Thread Jim DeLaHunt
On 2017-11-22 15:40, Carl Eugen Hoyos wrote: 2017-11-23 0:39 GMT+01:00 Derek Buitenhuis : On 11/22/2017 11:34 PM, Carl Eugen Hoyos wrote: Please understand I am against removing the paragraph from the documentation because I believe it is a good idea if developers

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 4:37 GMT+01:00 : > From: Vishwanath Dixit > > Signed-off-by: Karthick J > --- > libavformat/hlsenc.c | 67 > +++- > 1 file changed, 66 insertions(+), 1 deletion(-) > > diff

[FFmpeg-devel] [PATCH]ffmpeg: Improve warnings if av_buffersrc_add_frame*() fail

2017-11-23 Thread Carl Eugen Hoyos
Hi! Attached patch implements more verbose warnings as suggested by Nicolas. Please comment, Carl Eugen From 5ec3b8bdb776d9c14127017cd9e3077503be2bea Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 23 Nov 2017 12:05:51 +0100 Subject: [PATCH] ffmpeg: Improve

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 4:56 PM, "Carl Eugen Hoyos" wrote: > >2017-11-23 12:21 GMT+01:00 Karthick J : > >> +if (hls->flags & HLS_SPLIT_BY_TIME) { >> +// Independent segments cannot be guaranteed when splitting by time >> +hls->flags &=

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 4:21 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 4:37 GMT+01:00 : > >> +s = x264_encoder_headers(x4->enc, , ); >> +if (avctx->profile == FF_PROFILE_UNKNOWN) >> +avctx->profile = nal->p_payload[5]; >> +if (avctx->level ==

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 12:47 GMT+01:00 Jeyapal, Karthick : > On 11/23/17, 4:21 PM, "Carl Eugen Hoyos" wrote: > >>2017-11-23 4:37 GMT+01:00 : >> >>> +s = x264_encoder_headers(x4->enc, , ); >>> +if (avctx->profile == FF_PROFILE_UNKNOWN) >>> +

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Aman Gupta
On Wed, Nov 22, 2017 at 9:06 PM Karthick J wrote: > --- > doc/muxers.texi | 4 > libavformat/hlsenc.c | 14 ++ > 2 files changed, 18 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index 0bb8ad2..9d9ca31 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

2017-11-23 Thread Tobias Rapp
On 22.11.2017 23:52, Carl Eugen Hoyos wrote: 2017-11-22 16:41 GMT+01:00 Tobias Rapp : Writes one set of field framing information for progressive streams and two sets for interlaced streams. Fixes ticket #6383. Unfortunately the OpenDML v1.02 document is not very

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-23 Thread Aman Gupta
On Wed, Nov 22, 2017 at 7:38 PM wrote: > From: Vishwanath Dixit > > Signed-off-by: Karthick J > --- > libavformat/hlsenc.c | 67 > +++- > 1 file changed, 66 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-23 Thread Carl Eugen Hoyos
Hi! The (external) encoders may overwrite level and profile because of requested encoding properties, allowing libavcodec to (also) overwrite them in the context makes sense (and is already done in some cases afaict). Please comment, Carl Eugen From c6a84f9d8b511a9f4db541f0271748ae5257a0ae Mon

Re: [FFmpeg-devel] [PATCH]ffmpeg: Improve warnings if av_buffersrc_add_frame*() fail

2017-11-23 Thread Derek Buitenhuis
On 11/23/2017 11:09 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch implements more verbose warnings as suggested by Nicolas. > > Please comment, Carl Eugen OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 13:56 GMT+01:00 Jeyapal, Karthick : > > On 11/23/17, 5:33 PM, "Carl Eugen Hoyos" wrote: > >>2017-11-23 12:47 GMT+01:00 Jeyapal, Karthick : >>> On 11/23/17, 4:21 PM, "Carl Eugen Hoyos" wrote: >>>

Re: [FFmpeg-devel] [PATCH]ffmpeg: Improve warnings if av_buffersrc_add_frame*() fail

2017-11-23 Thread Nicolas George
Carl Eugen Hoyos (2017-11-23): > Hi! > > Attached patch implements more verbose warnings as suggested by Nicolas. > > Please comment, Carl Eugen > From 5ec3b8bdb776d9c14127017cd9e3077503be2bea Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Thu, 23 Nov 2017

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc:addition of #EXT-X-MEDIA tag and AUDIO attribute

2017-11-23 Thread Moritz Barsnick
On Thu, Nov 23, 2017 at 11:47:30 +0100, Carl Eugen Hoyos wrote: > (Isn't there a patch to fix the variable name?) Still pending: https://patchwork.ffmpeg.org/patch/6257/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] Revert "udp: fix compilation when HAVE_PTHREAD_CANCEL isnt defined"

2017-11-23 Thread Derek Buitenhuis
On 11/22/2017 4:41 PM, Paul B Mahol wrote: > LGTM Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 5:33 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 12:47 GMT+01:00 Jeyapal, Karthick : >> On 11/23/17, 4:21 PM, "Carl Eugen Hoyos" wrote: >> >>>2017-11-23 4:37 GMT+01:00 : >> +s =

Re: [FFmpeg-devel] [PATCH] avfilter/drawbox: rename variable for maximum thickness

2017-11-23 Thread Gyan Doshi
On 11/20/2017 3:59 PM, Gyan Doshi wrote: At present, the value name 'max' for maximum thickness in drawbox (and drawgrid) filter leads to a parse error if the thickness expression contains 'max(val1,val2)' i.e.     [Eval @ ...] Invalid chars '(20,30)' at the end of expression 'max(20,30)'

[FFmpeg-devel] [PATCH] doc/filters.texi: explain infinite looping

2017-11-23 Thread Werner Robitza
Explain how to achieve infinite looping with the loop / aloop filters. Signed-off-by: Werner Robitza --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 04a8139c6d..b8a4d032e0 100644 ---

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-23 Thread John Stebbins
On 11/23/2017 03:04 AM, Jerome Martinez wrote: > On 12/11/2017 03:12, Carl Eugen Hoyos wrote: >> The matroska spec says blockduration == 0 means the frame is not a >> keyframe. Since all subtitles are "keyframes", 0 blockduration should >> not be written. > As I understand from discussion on

Re: [FFmpeg-devel] [PATCH] doc/filters.texi: explain infinite looping

2017-11-23 Thread Lou Logan
On Thu, Nov 23, 2017, at 03:16 AM, Werner Robitza wrote: > Explain how to achieve infinite looping with the loop / aloop filters. > > Signed-off-by: Werner Robitza > --- > doc/filters.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Pushed. Thanks.

Re: [FFmpeg-devel] avcodec/x86/exrdsp : use ymm constant for pb_80 instead of vbroadcasti128

2017-11-23 Thread Martin Vignali
2017-11-22 18:21 GMT+01:00 James Almer : > On 11/21/2017 6:09 PM, Martin Vignali wrote: > > Hello, > > > > After patch by James Almer > > (pb_80 now fit an ymm) > > > > The two mode (SSE, AVX2) for constant loading can be remove > > > > speed seems to be similar to me > > > >

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-23 Thread John Stebbins
On 11/22/2017 05:26 PM, Carl Eugen Hoyos wrote: > 2017-11-23 1:30 GMT+01:00 John Stebbins : >> On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: >>> 2017-08-24 0:39 GMT+02:00 Dale Curtis : >>> -sc->ctts_data[ctts_count].count= count;

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-23 Thread Nicolas George
nablet developer (2017-11-20): > regarding re-using functions from network.c (like ff_network_wait_fd, > ff_accept, etc) > is suggested approach acceptable? is it okay to define such socket_api > structure and pass to > network.c calls? I do not think so. These functions are very specific to

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-23 Thread Michael Niedermayer
On Thu, Nov 23, 2017 at 04:01:06PM +0100, Carl Eugen Hoyos wrote: > Hi! > > The (external) encoders may overwrite level and profile because of > requested encoding properties, allowing libavcodec to (also) overwrite > them in the context makes sense (and is already done in some cases > afaict). >

[FFmpeg-devel] [PATCH 2/2] avformat/flacenc: add flac_init() and flac_deinit()

2017-11-23 Thread James Almer
Signed-off-by: James Almer --- libavformat/flacenc.c | 58 +-- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 84da54a1df..7c94670f1d 100644 ---

[FFmpeg-devel] [PATCH] avfilter: add lv2 wrapper filter

2017-11-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure| 4 + doc/filters.texi | 37 libavfilter/Makefile | 1 + libavfilter/af_lv2.c | 552 +++ libavfilter/allfilters.c | 1 + 5 files changed, 595

Re: [FFmpeg-devel] [PATCH] avfilter: add lv2 wrapper filter

2017-11-23 Thread James Almer
On 11/23/2017 6:16 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 4 + > doc/filters.texi | 37 > libavfilter/Makefile | 1 + > libavfilter/af_lv2.c | 552 > +++ >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-23 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 11:59:30PM +0100, Hendrik Leppkes wrote: > On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos wrote: > > 2017-11-22 21:00 GMT+01:00 Michael Niedermayer : > > > >> diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c

[FFmpeg-devel] [PATCH 1/2] lavf/flacenc: support writing attached pictures

2017-11-23 Thread James Almer
From: Rodger Combs Signed-off-by: James Almer --- Should be good to commit now. libavformat/flacenc.c | 286 +++--- 1 file changed, 250 insertions(+), 36 deletions(-) diff --git a/libavformat/flacenc.c

[FFmpeg-devel] [PATCH] ffmpeg libopusdec: fix missing include file in libopusdec.c

2017-11-23 Thread Mikulas Patocka
This patch fixes the following error when compiling mplayer with libopus. libavcodec/libopusdec.c: In function 'libopus_decode_init': libavcodec/libopusdec.c:130:27: error: implicit declaration of function 'ff_exp10'; did you mean 'ff_exp2fi'? [-Werror=implicit-function-declaration]

[FFmpeg-devel] [PATCH] hls demuxer: add option to defer parsing of variants

2017-11-23 Thread Rainer Hochecker
--- doc/demuxers.texi | 5 + libavformat/hls.c | 299 -- 2 files changed, 204 insertions(+), 100 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 73dc0feec1..634b122e10 100644 --- a/doc/demuxers.texi +++

[FFmpeg-devel] Adding option B does not work

2017-11-23 Thread shailender Jain
Hello, I am trying to ensure that a specific number of B Frames should be used by FFMPEG. I am running the following command ffmpeg -i Rediff.mp4 -vstats_file stats.txt -c:v libx264 -bf 16 -crf 28 Rediff2.mp4 However, when i look at the stats.txt, i cannot see 16 B-Frames. Is there any

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-23 Thread Richard Ling
On Nov 21, 2017 10:32 PM, "Moritz Barsnick" wrote: > > Nice. I personally appreciate your code comments, as I'm no big filter > author (yet). I've never made any contribution to ffmpeg before, so I'm almost certainly a bad example to follow :-P But I do like code to be well

[FFmpeg-devel] (no subject)

2017-11-23 Thread Rainer Hochecker
Currently all variants/playlists get parsed on open. For a master playlist with many different bitrates this can take several seconds. With the new option set to 0 only the first variant of a master playlist is opened. Others can be activated later by setting discard option on a program. Default

[FFmpeg-devel] [PATCH] ffmpeg fft: fix broken opus on 3dnow

2017-11-23 Thread Mikulas Patocka
The commit b7c16a3f2c4921f613319938b8ee0e3d6fa83e8d ("x86: fft: Port to cpuflags") breaks the opus decoder in ffmpeg when compiling for 3dnow. The output is audible, but there's a lot of noise. This could be tested by disabling sse and compiling ffmpeg on a processor with 3dnow support: CC='gcc

Re: [FFmpeg-devel] [PATCH] ffmpeg libopusdec: fix missing include file in libopusdec.c

2017-11-23 Thread Hendrik Leppkes
On Thu, Nov 23, 2017 at 8:22 PM, Mikulas Patocka wrote: > This patch fixes the following error when compiling mplayer with libopus. > > libavcodec/libopusdec.c: In function 'libopus_decode_init': > libavcodec/libopusdec.c:130:27: error: implicit declaration of function >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc:addition of #EXT-X-MEDIA tag and AUDIO attribute

2017-11-23 Thread Steven Liu
2017-11-24 1:15 GMT+08:00 Moritz Barsnick : > On Thu, Nov 23, 2017 at 11:47:30 +0100, Carl Eugen Hoyos wrote: >> (Isn't there a patch to fix the variable name?) > Still pending: > https://patchwork.ffmpeg.org/patch/6257/ patchset pushed Thanks >

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Steven Liu
2017-11-23 19:33 GMT+08:00 Karthick J : > --- > doc/muxers.texi | 4 > libavformat/hlsenc.c | 17 + > 2 files changed, 21 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index 0bb8ad2..9d9ca31 100644 > --- a/doc/muxers.texi > +++

Re: [FFmpeg-devel] [PATCH 2/3] udp: Check the port number provided by av_url_split as per docs

2017-11-23 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 03:28:41PM +, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/udp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavformat/udp.c b/libavformat/udp.c > index 0dde035..7bbd282 100644 > ---

Re: [FFmpeg-devel] [PATCH] ffmpeg libopusdec: fix missing include file in libopusdec.c

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 23:41 GMT+01:00 Hendrik Leppkes : > On Thu, Nov 23, 2017 at 8:22 PM, Mikulas Patocka > wrote: >> This patch fixes the following error when compiling mplayer with libopus. >> >> libavcodec/libopusdec.c: In function 'libopus_decode_init': >>

Re: [FFmpeg-devel] [PATCH 1/2] lavf/flacenc: support writing attached pictures

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 23:08 GMT+01:00 James Almer : > Should be good to commit now. Please mention ticket #4442. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] hls demuxer: add option to defer parsing of variants

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 23:20 GMT+01:00 Rainer Hochecker : > +@item load_all_variants > +If 0, only the first variant/playlist is loaded on open. All other variants > +get disabled and can be enabled by setting discard option in program. > +Default value is 1. Shouldn't this be: 0 (or

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 22:58 GMT+01:00 Michael Niedermayer : > On Thu, Nov 23, 2017 at 04:01:06PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> The (external) encoders may overwrite level and profile because of >> requested encoding properties, allowing libavcodec to (also) overwrite >>

[FFmpeg-devel] [PATCHv2] avformat/mxfdec: fix last packet timestamps

2017-11-23 Thread Marton Balint
The current edit unit cannot be reliably determined for the last packet of a video stream, because we can't query the start offset of the next edit unit from the index. This caused missing timestamps for the last video packet. Therefore from now on, we allow setting the PTS even if we are not

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-23 Thread Carl Eugen Hoyos
2017-11-23 19:45 GMT+01:00 John Stebbins : > On 11/22/2017 05:26 PM, Carl Eugen Hoyos wrote: >> 2017-11-23 1:30 GMT+01:00 John Stebbins : >>> On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: 2017-08-24 0:39 GMT+02:00 Dale Curtis

Re: [FFmpeg-devel] [PATCH 08/13] ffmpeg: Use codec hardware config to configure hwaccels

2017-11-23 Thread Mark Thompson
On 22/11/17 04:28, Philip Langdale wrote: > On Sat, 18 Nov 2017 18:47:08 + > Mark Thompson wrote: > >> Removes specific support for all hwaccels supported by the generic >> code (DXVA2, D3D11VA, NVDEC, VAAPI, VDPAU and videotoolbox). >> --- >> fftools/ffmpeg.c | 77