Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread 刘歧
> 在 2017年11月24日,18:12,Karthick J 写道: > > --- > libavformat/hlsenc.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 30ccf73..379a4ec 100644 > --- a/libavformat/hlsenc.c > +++

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread Karthick J
Also removed a redundant av_log call --- libavformat/hlsenc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 30ccf73..379a4ec 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1057,7 +1057,6 @@ static

Re: [FFmpeg-devel] [PATCH 13/17] lavc/mjpeg: Add profiles for MJPEG using SOF marker codes

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 1:51 GMT+01:00 Mark Thompson : > This is needed by later hwaccel code to tell which encoding process was > used for a particular frame, because hardware decoders may only support a > subset of possible methods. > --- > libavcodec/avcodec.h | 6 ++ >

Re: [FFmpeg-devel] [PATCH 07/17] lavc: Mark all AVHWAccel structures as const

2017-11-24 Thread Mark Thompson
On 24/11/17 11:29, Carl Eugen Hoyos wrote: > 2017-11-24 1:51 GMT+01:00 Mark Thompson : > >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index 1ae0344bb2..0972df0bde 100644 >> --- a/libavcodec/avcodec.h >> +++ b/libavcodec/avcodec.h >> @@ -2635,7 +2635,7 @@ typedef

[FFmpeg-devel] [PATCH v2 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- libavformat/hlsenc.c | 65 +++- 1 file changed, 64 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 58d7c58..8a634de 100644 --- a/libavformat/hlsenc.c +++

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Jeyapal, Karthick
Since Vishwanath is on leave today, I have made the changes required and have sent patchset v2. On 11/23/17, 4:11 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 4:37 GMT+01:00 : >> From: Vishwanath Dixit >> >> Signed-off-by: Karthick J

[FFmpeg-devel] [PATCH] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread Karthick J
--- libavformat/hlsenc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 30ccf73..379a4ec 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1057,7 +1057,6 @@ static int get_relative_url(const char

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread Moritz Barsnick
On Fri, Nov 24, 2017 at 15:42:30 +0530, Karthick J wrote: > if (av_strncasecmp(master_url, media_url, base_len)) { > -av_log(NULL, AV_LOG_WARNING, "Unable to find relative url\n"); > return AVERROR(EINVAL); Was it intention to remove this one? Moritz

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 11:55 GMT+01:00 Mark Thompson : > On 24/11/17 09:37, Karthick J wrote: >> -s = x264_encoder_headers(x4->enc, , ); >> +if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) { >> avctx->extradata = p = av_mallocz(s + AV_INPUT_BUFFER_PADDING_SIZE); >>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 12:03 GMT+01:00 Moritz Barsnick : > On Fri, Nov 24, 2017 at 15:42:30 +0530, Karthick J wrote: >> if (av_strncasecmp(master_url, media_url, base_len)) { >> -av_log(NULL, AV_LOG_WARNING, "Unable to find relative url\n"); >> return

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Carl Eugen Hoyos
2017-11-23 4:37 GMT+01:00 : > From: Vishwanath Dixit > +// either provide codec string for both active streams or for none > +if (vid_st && aud_st && (!strlen(vcodec) || !strlen(acodec))) { > +acodec[0] = vcodec[0] = '\0'; > +

Re: [FFmpeg-devel] [PATCH 2/2 v2] avformat/flacenc: add flac_init() and flac_deinit()

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 4:38 GMT+01:00 James Almer : > Signed-off-by: James Almer > --- > Simpler/smaller diff. Sorry if this is obvious: What is the advantage of having these new functions? Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread 刘歧
> 在 2017年11月24日,19:03,Moritz Barsnick 写道: > > On Fri, Nov 24, 2017 at 15:42:30 +0530, Karthick J wrote: >> if (av_strncasecmp(master_url, media_url, base_len)) { >> -av_log(NULL, AV_LOG_WARNING, "Unable to find relative url\n"); >> return

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Jeyapal, Karthick
On 11/24/17, 4:41 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 4:37 GMT+01:00 : >> From: Vishwanath Dixit >> +// either provide codec string for both active streams or for none >> +if (vid_st && aud_st && (!strlen(vcodec) ||

Re: [FFmpeg-devel] [PATCH 07/17] lavc: Mark all AVHWAccel structures as const

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 12:42 GMT+01:00 Mark Thompson : > On 24/11/17 11:29, Carl Eugen Hoyos wrote: >> 2017-11-24 1:51 GMT+01:00 Mark Thompson : >> >>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >>> index 1ae0344bb2..0972df0bde 100644 >>> ---

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-24 Thread Jeyapal, Karthick
On 11/24/17, 3:40 PM, "刘歧" wrote: >> 在 2017年11月24日,18:02,Jeyapal, Karthick 写道: >> >> On 11/22/17, 1:27 PM, "Jeyapal, Karthick" wrote: >> On 11/22/17, 9:32 AM, "刘歧" wrote: This patch is ok,

Re: [FFmpeg-devel] Adding option B does not work

2017-11-24 Thread Moritz Barsnick
On Thu, Nov 23, 2017 at 14:41:45 +, shailender Jain wrote: > I am trying to ensure that a specific number of B Frames should be > used by FFMPEG. I am running the following command This list is solely for the discussion of the development of ffmpeg and libav*. For usage questions, please

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-24 Thread 刘歧
> 在 2017年11月24日,18:02,Jeyapal, Karthick 写道: > > On 11/22/17, 1:27 PM, "Jeyapal, Karthick" wrote: > >>> On 11/22/17, 9:32 AM, "刘歧" wrote: >>> >>> This patch is ok, but i see it need an API: ffio_geturlcontext >>> >>> it in the

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Mark Thompson
On 24/11/17 09:37, Karthick J wrote: > From: Vishwanath Dixit > > --- > libavcodec/libx264.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 9c67c91..6b93aa8 100644 > ---

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-24 Thread Mark Thompson
On 24/11/17 02:54, Jeyapal, Karthick wrote: > > > On 11/24/17, 5:17 AM, "Carl Eugen Hoyos" wrote: > >> 2017-11-23 22:58 GMT+01:00 Michael Niedermayer : >>> On Thu, Nov 23, 2017 at 04:01:06PM +0100, Carl Eugen Hoyos wrote: Hi! The

Re: [FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-24 Thread Mark Thompson
On 24/11/17 07:25, Jun Zhao wrote: > > > On 2017/11/24 8:51, Mark Thompson wrote: >> Also adds some extra fields to the main context structure that may >> be needed by a hwaccel decoder. >> --- >> The YUVJ formats really mess with this. This patch hacks them out so that >> the hwaccel works,

Re: [FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 1:51 GMT+01:00 Mark Thompson : > Also adds some extra fields to the main context structure > that may be needed by a hwaccel decoder. > --- > The YUVJ formats really mess with this. This patch hacks > them out so that the hwaccel works, suggestions welcome > on what to

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread Jeyapal, Karthick
On 11/24/17, 4:36 PM, "Carl Eugen Hoyos" wrote: >2017-11-24 12:03 GMT+01:00 Moritz Barsnick : >> On Fri, Nov 24, 2017 at 15:42:30 +0530, Karthick J wrote: >>> if (av_strncasecmp(master_url, media_url, base_len)) { >>> -av_log(NULL,

Re: [FFmpeg-devel] [PATCH 13/17] lavc/mjpeg: Add profiles for MJPEG using SOF marker codes

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 12:35 GMT+01:00 Mark Thompson : > On 24/11/17 11:27, Carl Eugen Hoyos wrote: >> 2017-11-24 1:51 GMT+01:00 Mark Thompson : >>> This is needed by later hwaccel code to tell which encoding process was >>> used for a particular frame, because hardware

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-24 Thread Jerome Martinez
On 23/11/2017 20:02, John Stebbins wrote: [...] It's not practical to know the duration of the previous subtitle before writing it because you can't know it till you have seen this empty PGS.  Once you've seen the empty PGS, it is often too late to properly interleave the previous PGS in the

[FFmpeg-devel] [PATCH] lavu/pixfmt: Remove gap in the middle of enum AVPixelFormat

2017-11-24 Thread Mark Thompson
This was added for compatibility with libav, by leaving a space for formats added in libav to be merged. Since that feature has been removed, we don't need a gap here. --- Should be applied before the unstable ABI period ends. libavutil/pixfmt.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] hwcontext_d3d11va: properly reset values after release/close

2017-11-24 Thread Jan Ekstrom
On Nov 24, 2017 03:01, "Jan Ekström" wrote: Makes the uninit function re-entrable, which can be a common case when an API user first tries to initialize its context, fails, and then finally unrefs the AVHWDevice. Fixes a crash reported by sm2345 on IRC Relevant backtrace I

Re: [FFmpeg-devel] [PATCH 02/17] lavc: Add hardware config metadata for decoders supporting hardware output

2017-11-24 Thread Timo Rothenpieler
diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 806dab2074..3bd2409ea2 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -32,6 +32,7 @@ #include "avcodec.h" #include "decode.h" +#include "hwaccel.h" #include "internal.h" typedef struct CuvidContext

Re: [FFmpeg-devel] [PATCH] hwcontext_d3d11va: properly reset values after release/close

2017-11-24 Thread Hendrik Leppkes
On Fri, Nov 24, 2017 at 2:01 AM, Jan Ekström wrote: > Makes the uninit function re-entrable, which can be a common case > when an API user first tries to initialize its context, fails, and > then finally unrefs the AVHWDevice. > > Fixes a crash reported by sm2345 on IRC. > --- >

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-24 Thread Jeyapal, Karthick
On 11/22/17, 1:27 PM, "Jeyapal, Karthick" wrote: >>On 11/22/17, 9:32 AM, "刘歧" wrote: >> >>This patch is ok, but i see it need an API: ffio_geturlcontext >> >>it in the other patch, i see it have some thing need talk? If that is ok, >>this patch should

[FFmpeg-devel] [PATCH v2 1/3] avformat/hlsenc:addition of #EXT-X-MEDIA tag and AUDIO attribute

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- doc/muxers.texi | 12 ++ libavformat/hlsenc.c | 63 ++-- 2 files changed, 73 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 9d9ca31..7e6d594 100644 ---

[FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- libavcodec/libx264.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91..6b93aa8 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -454,6 +454,9 @@

Re: [FFmpeg-devel] [PATCH 16/17] hwcontext_vaapi: Move better-matching surface formats earlier

2017-11-24 Thread Jun Zhao
On 2017/11/24 8:51, Mark Thompson wrote: > In particular, avoid selecting YV12/YV16 when I420/422H are available. > --- > libavutil/hwcontext_vaapi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index

Re: [FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-24 Thread Mark Thompson
On 24/11/17 11:17, Carl Eugen Hoyos wrote: > 2017-11-24 1:51 GMT+01:00 Mark Thompson : >> Also adds some extra fields to the main context structure >> that may be needed by a hwaccel decoder. >> --- >> The YUVJ formats really mess with this. This patch hacks >> them out so that

Re: [FFmpeg-devel] [PATCH 07/17] lavc: Mark all AVHWAccel structures as const

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 1:51 GMT+01:00 Mark Thompson : > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 1ae0344bb2..0972df0bde 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -2635,7 +2635,7 @@ typedef struct AVCodecContext { > * - encoding:

Re: [FFmpeg-devel] [PATCH 13/17] lavc/mjpeg: Add profiles for MJPEG using SOF marker codes

2017-11-24 Thread Mark Thompson
On 24/11/17 11:27, Carl Eugen Hoyos wrote: > 2017-11-24 1:51 GMT+01:00 Mark Thompson : >> This is needed by later hwaccel code to tell which encoding process was >> used for a particular frame, because hardware decoders may only support a >> subset of possible methods. >> --- >>

Re: [FFmpeg-devel] [PATCH 2/2 v2] avformat/flacenc: add flac_init() and flac_deinit()

2017-11-24 Thread James Almer
On 11/24/2017 8:19 AM, Carl Eugen Hoyos wrote: > 2017-11-24 4:38 GMT+01:00 James Almer : >> Signed-off-by: James Almer >> --- >> Simpler/smaller diff. > > Sorry if this is obvious: > What is the advantage of having these new functions? > > Carl Eugen

[FFmpeg-devel] [PATCH 0/2] alloc NULL check fuzzer finds

2017-11-24 Thread Derek Buitenhuis
This was from a single FATE pass, an only 2 of the 10+ found. Going to send the tool I use to fuzz it to the list as well. Derek Buitenhuis (2): h264_picture: Actually return error during alloc failure vorbisenc: Check the return value of av_frame_clone libavcodec/h264_picture.c | 12

[FFmpeg-devel] [PATCH 2/2] vorbisenc: Check the return value of av_frame_clone

2017-11-24 Thread Derek Buitenhuis
Prevents a segfault when alloc fails. Signed-off-by: Derek Buitenhuis --- libavcodec/vorbisenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index a4ecd8f754..18a679f2dc 100644 ---

[FFmpeg-devel] [PATCH 0/1][TOOL][HACK] Allocation NULL check fuzzer

2017-11-24 Thread Derek Buitenhuis
I've had this kicking around for like 4 years, maybe it can be of use to some people. I haven't done full scale fuzzing with this because laziness. I just sometimes run it when I'm bored. It's not thread-safe, but it would be trivial to make it so. It's based off my old LD_PRELOAD hack from

[FFmpeg-devel] [PATCH 1/1][NO NOT APPLY] Allocation NULL check fuzzing tool

2017-11-24 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavutil/mem.c | 4 ++- libavutil/posixmemalign.c | 86 +++ 2 files changed, 89 insertions(+), 1 deletion(-) create mode 100644 libavutil/posixmemalign.c diff --git

Re: [FFmpeg-devel] [PATCH v4 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 10:57:45AM +0530, Karthick J wrote: > --- > libavformat/Makefile | 2 +- > libavformat/hlsenc.c | 115 +++ > libavformat/hlsplaylist.c | 136 > ++ > libavformat/hlsplaylist.h | 51

Re: [FFmpeg-devel] [PATCH 0/1][TOOL][HACK] Allocation NULL check fuzzer

2017-11-24 Thread Paul B Mahol
On 11/24/17, Derek Buitenhuis wrote: > I've had this kicking around for like 4 years, maybe it can be of use to > some people. > I haven't done full scale fuzzing with this because laziness. I just > sometimes run it > when I'm bored. It's not thread-safe, but it would

Re: [FFmpeg-devel] [PATCH] hls demuxer: add option to defer parsing of variants

2017-11-24 Thread Rainer Hochecker
Shouldn't this be: 0 (or -1) for all streams (default), n>0 (or > -1) for the nth stream. I guess it is at least possible that the user knows in advance which streams the source will offer. No? Carl Eugen It is very unlikely that this is known in advance. Also there is no reason why you want

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/24/17, Nicolas George wrote: > Paul B Mahol (2017-11-24): >> But for what option instead was consensus? > > I do not remember. That is your patch, therefore I think it is your > responsibility to re-read the discussion, make a choice that you think > will suit everybody,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > WTF you are very evil persona. I do not know what you mean, and please stop ad-hominem attacks. I only want time to review the code while knowing what it is supposed to do. So please re-submit your patch. Regards, and EOT for me tonight, -- Nicolas George

[FFmpeg-devel] [PATCH] avfilter/vf_tile: add init_padding option

2017-11-24 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 4 libavfilter/vf_tile.c | 12 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 76929e4db5..11ce0482c2 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 12:47:16AM +0100, Carl Eugen Hoyos wrote: > 2017-11-23 22:58 GMT+01:00 Michael Niedermayer : > > On Thu, Nov 23, 2017 at 04:01:06PM +0100, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> The (external) encoders may overwrite level and profile because of >

Re: [FFmpeg-devel] [PATCH 13/17] lavc/mjpeg: Add profiles for MJPEG using SOF marker codes

2017-11-24 Thread Philip Langdale
On Fri, 24 Nov 2017 00:51:30 + Mark Thompson wrote: > This is needed by later hwaccel code to tell which encoding process > was used for a particular frame, because hardware decoders may only > support a subset of possible methods. > --- > libavcodec/avcodec.h | 6 ++ >

Re: [FFmpeg-devel] [vorbis] 1 << 31 > int32_t::max(), so use 1u << 31 instead.

2017-11-24 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 10:59:48AM -0800, Dale Curtis wrote: > > vorbis.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > cc6147c6f734e06bfe23d0123d8b24a02273431c vorbis_fix_v1.patch > From fa070a9b47f6bef2a12cabdd5854e1dc1a0d4c32 Mon Sep 17 00:00:00 2001 > From: Dale Curtis

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 05:50:36PM +0100, Hendrik Leppkes wrote: > On Fri, Nov 24, 2017 at 5:42 PM, Michael Niedermayer > wrote: > > On Fri, Nov 24, 2017 at 12:47:16AM +0100, Carl Eugen Hoyos wrote: > >> 2017-11-23 22:58 GMT+01:00 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-24 Thread Philip Langdale
On Fri, 24 Nov 2017 00:51:31 + Mark Thompson wrote: > Also adds some extra fields to the main context structure that may > be needed by a hwaccel decoder. > --- > The YUVJ formats really mess with this. This patch hacks them out so > that the hwaccel works, suggestions

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > What you want to change? The name of the option and its documentation. The documentation was unclear, and if there was a consensus about the name of the option, it was not for "queue". Regards, -- Nicolas George signature.asc Description: Digital signature

[FFmpeg-devel] [PATCH 1/2] h264_picture: Actually return error during alloc failure

2017-11-24 Thread Derek Buitenhuis
Fixes NULL dereference during alloc failure. Signed-off-by: Derek Buitenhuis --- libavcodec/h264_picture.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c index

Re: [FFmpeg-devel] [PATCH 0/1][TOOL][HACK] Allocation NULL check fuzzer

2017-11-24 Thread Derek Buitenhuis
On 11/24/2017 8:09 PM, Paul B Mahol wrote: > Do you have backtrace of this one? Yes, but the alloc failure is not in lavfi: my_posix_memalign:77 in libavutil/posixmemalign.c av_malloc:89 in libavutil/mem.c av_mallocz:240 in libavutil/mem.c av_packet_alloc:53 in libavcodec/avpacket.c

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > But for what option instead was consensus? I do not remember. That is your patch, therefore I think it is your responsibility to re-read the discussion, make a choice that you think will suit everybody, and re-submit the patch for final approval. By the way, since

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/24/17, Nicolas George wrote: > Paul B Mahol (2017-11-24): >> WTF you are very evil persona. > > I do not know what you mean, and please stop ad-hominem attacks. > > I only want time to review the code while knowing what it is supposed to > do. So please re-submit your

Re: [FFmpeg-devel] [PATCH] avfilter/af_amix: add double sample format support

2017-11-24 Thread Carl Eugen Hoyos
2017-04-09 22:11 GMT+02:00 Paul B Mahol : > Signed-off-by: Paul B Mahol > --- > libavfilter/af_amix.c | 19 +++ > libavutil/float_dsp.c | 9 + > libavutil/float_dsp.h | 16 The change to libavutil broke ABI, see

[FFmpeg-devel] [PATCH v4 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- libavcodec/libx264.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91..545826c 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -19,11

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-24 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 10:56:07AM -0800, Dale Curtis wrote: > On Tue, Nov 21, 2017 at 7:05 PM, Michael Niedermayer > wrote: > > > > I dont think wrap_bits can/should be > 64 or do i miss something ? > > > > Good point, this seems true with the current code. > > > > >

[FFmpeg-devel] [PATCH] lavf/mov: fix crash in mov_read_sidx

2017-11-24 Thread John Stebbins
Use correct index into streams --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f3e86dfc6d..ddb1e59b85 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4816,7 +4816,7 @@ static int

Re: [FFmpeg-devel] [PATCH 16/17] hwcontext_vaapi: Move better-matching surface formats earlier

2017-11-24 Thread Mark Thompson
On 24/11/17 08:28, Jun Zhao wrote: > On 2017/11/24 8:51, Mark Thompson wrote: >> In particular, avoid selecting YV12/YV16 when I420/422H are available. >> --- >> libavutil/hwcontext_vaapi.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: add mix filter

2017-11-24 Thread Paul B Mahol
On 11/20/17, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 28 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_mix.c | 283 >

Re: [FFmpeg-devel] [PATCH 2/3] udp: Check the port number provided by av_url_split as per docs

2017-11-24 Thread Derek Buitenhuis
On 11/23/2017 11:28 PM, Michael Niedermayer wrote: > this seems to break rtp / rtsp > > ive traced it to > ff_rtsp_make_setup_request() calling ffurl_open_whitelist() without > a port Looking at:

[FFmpeg-devel] [PATCH v3 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- libavformat/hlsenc.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 58d7c58..92c90a1 100644 --- a/libavformat/hlsenc.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/21/17, Paul B Mahol wrote: > On 11/19/17, Nicolas George wrote: >> Thilo Borgmann (2017-11-19): >>> Based on Dave's example I'd say the queue parameter defines the >>> minimum of available tiles before output is generated. >>> >>> 'queue' -> 'min' >>>

Re: [FFmpeg-devel] [PATCH] avfilter: add lv2 wrapper filter

2017-11-24 Thread Paul B Mahol
On 11/23/17, James Almer wrote: > On 11/23/2017 6:16 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure| 4 + >> doc/filters.texi | 37 >> libavfilter/Makefile | 1 + >> libavfilter/af_lv2.c |

[FFmpeg-devel] [PATCH v3 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- libavcodec/libx264.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91..2f7f53c 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -19,6

[FFmpeg-devel] [PATCH v4 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- libavformat/hlsenc.c | 67 +++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 58d7c58..d48963c 100644 --- a/libavformat/hlsenc.c +++

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-24 Thread Paul B Mahol
On 11/23/17, Richard Ling wrote: > On Nov 21, 2017 10:32 PM, "Moritz Barsnick" wrote: >> >> Nice. I personally appreciate your code comments, as I'm no big filter >> author (yet). > > I've never made any contribution to ffmpeg before, so I'm almost

Re: [FFmpeg-devel] [PATCH 16/17] hwcontext_vaapi: Move better-matching surface formats earlier

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 14:06 GMT+01:00 Mark Thompson : > On 24/11/17 08:28, Jun Zhao wrote: >> On 2017/11/24 8:51, Mark Thompson wrote: >>> In particular, avoid selecting YV12/YV16 when I420/422H are available. >>> --- >>> libavutil/hwcontext_vaapi.c | 6 +++--- >>> 1 file changed, 3

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Jeyapal, Karthick
Thanks for your comments. I have uploaded new patchset v4 with suggested corrections. Please ignore patchset v3. On 11/24/17, 4:26 PM, "Mark Thompson" wrote: […] >> +s = x264_encoder_headers(x4->enc, , ); >> +avctx->profile = nal->p_payload[5]; > >AVCodecContext.profile

Re: [FFmpeg-devel] [PATCH] hls demuxer: add option to defer parsing of variants

2017-11-24 Thread Michael Niedermayer
On Thu, Nov 23, 2017 at 11:20:10PM +0100, Rainer Hochecker wrote: > --- > doc/demuxers.texi | 5 + > libavformat/hls.c | 299 > -- > 2 files changed, 204 insertions(+), 100 deletions(-) breaks fate-segment-mp4-to-ts ... Output #0, framecrc,

Re: [FFmpeg-devel] [PATCH 0/1][TOOL][HACK] Allocation NULL check fuzzer

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 07:45:46PM +, Derek Buitenhuis wrote: > I've had this kicking around for like 4 years, maybe it can be of use to some > people. > I haven't done full scale fuzzing with this because laziness. I just > sometimes run it > when I'm bored. It's not thread-safe, but it

Re: [FFmpeg-devel] [PATCH 0/1][TOOL][HACK] Allocation NULL check fuzzer

2017-11-24 Thread Derek Buitenhuis
On 11/24/2017 11:35 PM, Michael Niedermayer wrote: > Maybe integrating this in: > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > would make sense > > That would run it automatically on ffmpeg master HEAD on powerfull hw Could make sense, yeah - wouldn't be that hard. It

Re: [FFmpeg-devel] [PATCH] lavu/pixfmt: Remove gap in the middle of enum AVPixelFormat

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 12:36:09PM +, Mark Thompson wrote: > This was added for compatibility with libav, by leaving a space for > formats added in libav to be merged. Since that feature has been > removed, we don't need a gap here. > --- > Should be applied before the unstable ABI period

[FFmpeg-devel] [PATCH] web/index: add news entry for release 3.4

2017-11-24 Thread James Almer
Signed-off-by: James Almer --- This was for some reason missed back in October. src/index | 52 1 file changed, 52 insertions(+) diff --git a/src/index b/src/index index 0ca7a10..2b44762 100644 --- a/src/index +++

Re: [FFmpeg-devel] [PATCH 1/2] h264_picture: Actually return error during alloc failure

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 07:27:12PM +, Derek Buitenhuis wrote: > Fixes NULL dereference during alloc failure. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/h264_picture.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) LGTM thx

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix crash in mov_read_sidx

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 08:18:16AM -0800, John Stebbins wrote: > Use correct index into streams > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-24 Thread Michael Niedermayer
On Thu, Nov 23, 2017 at 11:00:21PM +0100, Michael Niedermayer wrote: > On Wed, Nov 22, 2017 at 11:59:30PM +0100, Hendrik Leppkes wrote: > > On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos > > wrote: > > > 2017-11-22 21:00 GMT+01:00 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] tests/checkasm/float_dsp: Increase allowed difference for float_dsp.vector_dmul

2017-11-24 Thread James Almer
On 10/29/2017 11:57 AM, Michael Niedermayer wrote: > The choosen value is the lowest power of 2 that allows 1000 iterations of > fate-checkasm-float_dsp > to pass on x86-32 Ticket #6848 reports this value is still not enough. Maybe something like 1.0e-12 or 1.0e-13 instead? > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/2] lavf/flacenc: support writing attached pictures

2017-11-24 Thread Michael Niedermayer
On Thu, Nov 23, 2017 at 07:08:42PM -0300, James Almer wrote: > From: Rodger Combs > > Signed-off-by: James Almer > --- > Should be good to commit now. > > libavformat/flacenc.c | 286 > +++--- > 1 file

Re: [FFmpeg-devel] [PATCH 1/2] lavf/flacenc: support writing attached pictures

2017-11-24 Thread James Almer
On 11/24/2017 8:27 PM, Michael Niedermayer wrote: > On Thu, Nov 23, 2017 at 07:08:42PM -0300, James Almer wrote: >> From: Rodger Combs >> >> Signed-off-by: James Almer >> --- >> Should be good to commit now. >> >> libavformat/flacenc.c | 286 >>

[FFmpeg-devel] [PATCH 2/2] lavc/utils.c: use C11 atomics for entangled thread handling

2017-11-24 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavcodec/utils.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index e50de6e89b..a3cd96ed2e 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -56,6

[FFmpeg-devel] [PATCH 1/2] error_resilience: remove avpriv_atomic usage

2017-11-24 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavcodec/error_resilience.c | 12 ++-- libavcodec/error_resilience.h | 3 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/error_resilience.c b/libavcodec/error_resilience.c index

Re: [FFmpeg-devel] [PATCH 13/17] lavc/mjpeg: Add profiles for MJPEG using SOF marker codes

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 12:51:30AM +, Mark Thompson wrote: > This is needed by later hwaccel code to tell which encoding process was > used for a particular frame, because hardware decoders may only support a > subset of possible methods. > --- > libavcodec/avcodec.h | 6 ++ >

[FFmpeg-devel] [PATCH] avcodec/dirac_dwt: Fix integer overflow in COMPOSE_FIDELITYi*

2017-11-24 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: -2143827186 - 7404944 cannot be represented in type 'int' Fixes: 4354/clusterfuzz-testcase-minimized-4671122764201984 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH v4 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-24 Thread Jeyapal, Karthick
Oops. Sorry about that. Have sent a new patch v5 that fixes this. Regards, Karthick On 11/25/17, 1:31 AM, "Michael Niedermayer" wrote: On Fri, Nov 24, 2017 at 10:57:45AM +0530, Karthick J wrote: > --- > libavformat/Makefile | 2 +- > libavformat/hlsenc.c |

Re: [FFmpeg-devel] [PATCH 0/1][TOOL][HACK] Allocation NULL check fuzzer

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 11:41:06PM +, Derek Buitenhuis wrote: > On 11/24/2017 11:35 PM, Michael Niedermayer wrote: > > Maybe integrating this in: > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > > > would make sense > > > > That would run it automatically on ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] lavc/utils.c: use C11 atomics for entangled thread handling

2017-11-24 Thread James Almer
On 11/24/2017 9:33 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/utils.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index e50de6e89b..a3cd96ed2e

Re: [FFmpeg-devel] [PATCH 1/2] error_resilience: remove avpriv_atomic usage

2017-11-24 Thread James Almer
On 11/24/2017 9:33 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/error_resilience.c | 12 ++-- > libavcodec/error_resilience.h | 3 ++- > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] ffmpeg libopusdec: fix missing include file in libopusdec.c

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 12:30:55AM +0100, Carl Eugen Hoyos wrote: > 2017-11-23 23:41 GMT+01:00 Hendrik Leppkes : > > On Thu, Nov 23, 2017 at 8:22 PM, Mikulas Patocka > > wrote: > >> This patch fixes the following error when compiling mplayer with

[FFmpeg-devel] [PATCH] configure: remove superfluous cuvid and nvdec checks

2017-11-24 Thread James Almer
Both are autodetected, and their dependency on cuda is checked elsewhere. Fixes ticket #6849. --- configure | 4 1 file changed, 4 deletions(-) diff --git a/configure b/configure index 3ec6407fb2..7769427ffb 100755 --- a/configure +++ b/configure @@ -5816,10 +5816,6 @@ done # these are

Re: [FFmpeg-devel] [PATCH 1/2] error_resilience: remove avpriv_atomic usage

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 10:18:06PM -0300, James Almer wrote: > On 11/24/2017 9:33 PM, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > libavcodec/error_resilience.c | 12 ++-- > > libavcodec/error_resilience.h | 3 ++- > > 2 files

Re: [FFmpeg-devel] [PATCH 1/2] lavf/flacenc: support writing attached pictures

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 08:53:55PM -0300, James Almer wrote: > On 11/24/2017 8:27 PM, Michael Niedermayer wrote: > > On Thu, Nov 23, 2017 at 07:08:42PM -0300, James Almer wrote: > >> From: Rodger Combs > >> > >> Signed-off-by: James Almer > >> --- > >>

[FFmpeg-devel] [PATCH v5 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-24 Thread Karthick J
--- libavformat/Makefile | 2 +- libavformat/hlsenc.c | 115 +++--- libavformat/hlsplaylist.c | 138 ++ libavformat/hlsplaylist.h | 51 + 4 files changed, 211 insertions(+), 95 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/2] avocdec/ttaenc: buffer packets directly

2017-11-24 Thread James Almer
On 11/23/2017 2:00 AM, James Almer wrote: > On 11/20/2017 5:44 PM, James Almer wrote: >> This is a bit more robust in case of OOM. >> >> Signed-off-by: James Almer >> --- >> libavformat/ttaenc.c | 42 +- >> 1 file changed, 33

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Nicolas George
Paul B Mahol (2017-11-24): > Because there are no more comments can I assume pushing this patch as is OK? Depends on how you amended it after the discussion. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add queue option

2017-11-24 Thread Paul B Mahol
On 11/24/17, Nicolas George wrote: > Paul B Mahol (2017-11-24): >> Because there are no more comments can I assume pushing this patch as is >> OK? > > Depends on how you amended it after the discussion. What you want to change? ___

Re: [FFmpeg-devel] [PATCH 14/17] mjpegdec: Add hwaccel hooks

2017-11-24 Thread Michael Niedermayer
On Fri, Nov 24, 2017 at 12:51:31AM +, Mark Thompson wrote: > Also adds some extra fields to the main context structure that may > be needed by a hwaccel decoder. > --- > The YUVJ formats really mess with this. This patch hacks them out so that > the hwaccel works, suggestions welcome on what

  1   2   >