[FFmpeg-devel] [PATCH] avformat/mux: factorize AVFormatContext->avoid_negative_ts initialization

2017-12-10 Thread James Almer
Signed-off-by: James Almer --- libavformat/mux.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index effcc1152f..ea9f13fdf5 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -445,6

Re: [FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: resync if cluster parsing fails while seeking

2017-12-10 Thread Rodger Combs
> On Dec 10, 2017, at 08:08, Nicolas George wrote: > > Rodger Combs (2017-12-08): >> --- >> libavformat/matroskadec.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c >> index

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/nvenc: remove YUVJ pixel formats usage

2017-12-10 Thread Philip Langdale
On Sun, 10 Dec 2017 14:14:30 +0100 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/nvenc.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index

Re: [FFmpeg-devel] [PATCH 27/27] all: remove rest of YUVJ pixel formats usage

2017-12-10 Thread Michael Niedermayer
On Sun, Dec 10, 2017 at 11:26:58AM +0100, Paul B Mahol wrote: > On 12/10/17, Michael Niedermayer wrote: > > On Sat, Dec 09, 2017 at 04:38:19PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> fftools/ffmpeg_filter.c

Re: [FFmpeg-devel] [PATCH 3/3] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-10 Thread Nicolas George
Rodger Combs (2017-12-07): > --- > libavformat/avformat.h | 1 + > libavformat/internal.h | 5 + > libavformat/options_table.h | 1 + > libavformat/utils.c | 12 > 4 files changed, 19 insertions(+) Can you give an example of scenario where this option would

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> Just leave for once. > > I have "left" with you more times than I can count. Not today. > Committing like this would be bad for the users, and you can make it > good with not much effort. > > If you do not care

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > For increased tempo it have much better quality. > For decreased tempo is have similar quality. > > Also it have more options and is more configurable > and have increased range of tempo scaling. Is there any benefit in atempo, then? If not, then this filter should

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> See vf_aspect.c, it changes inlink parameters. >> >> This patch is required for example if one change sar of first input >> and that value is not propagated to next links. > > I had not noticed that. The code in

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> For increased tempo it have much better quality. >> For decreased tempo is have similar quality. >> >> Also it have more options and is more configurable >> and have increased range of tempo scaling. > > Is there

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > That is very extreme step, if you insist on such step. > > Could you please change your statement? I do not understand what you mean. For users, having several filters that do almost exactly the same thing is confusing. It should be avoided, with the convenience of

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> That is very extreme step, if you insist on such step. >> >> Could you please change your statement? > > I do not understand what you mean. > > For users, having several filters that do almost exactly the same

Re: [FFmpeg-devel] [PATCH 3/3] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-10 Thread Rodger Combs
> On Dec 10, 2017, at 05:40, Nicolas George wrote: > > Rodger Combs (2017-12-10): >> The goal is to use this in conjunction with the previous patches in >> the set to deal with live broadcast streams coming off a tuner. The >> first patch sets the CORRUPT flag when the TEI bit

Re: [FFmpeg-devel] [PATCH 05/27] avfilter/vf_scale: make use of color_range from filter links

2017-12-10 Thread Michael Niedermayer
On Sat, Dec 09, 2017 at 04:37:57PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_scale.c | 8 > 1 file changed, 8 insertions(+) This changes the output for: ./ffmpeg -i ~/tickets/2939/lena.jpg -y file.jpg Not sure if its more

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-09): >> No new patches require it, it is for case such stereo3d and setsar and >> bunch >> of others that may need to explicitly set sample aspect ratio to each >> frame. > > "May need" is not always a good way of

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-10 Thread Rodger Combs
> On Dec 9, 2017, at 12:19, Michael Niedermayer wrote: > > On Fri, Dec 08, 2017 at 10:34:39PM -0600, Rodger Combs wrote: >> >> >>> On Dec 8, 2017, at 11:06, Michael Niedermayer >>> wrote: >>> >>> On Thu, Dec 07, 2017 at 10:23:15PM -0600,

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> > "May need" is not always a good way of designing changes. It would be >> > much better if you actually changed these filters at the same time to >> > use it. That way you can be more sure that you did not mess

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data

2017-12-10 Thread Nicolas George
Michael Niedermayer (2017-12-03): > I think i may be missing something here > > The way i remember this, is that all the changes do never get > triggered unless the user application passes frames with changing > parameters into the filter graph. > That is something not supported before these

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > I will then just apply this. No, you will not. You will discuss a solution that is good for the project as a whole. > If Carl Eugen can ignore you, I can too. Two wrongs do not make a right. If you feel you have been wronged by Carl Eugene, then complain about it

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> I spent enought time porting this filter and do not intend to waste any >> more >> time in void discussion with your ego. > > Keep your ad-hominem attacks for yourself. It is not a matter about me, > it is a

Re: [FFmpeg-devel] [PATCH] configure: Allow users to disable all hwaccel libraries

2017-12-10 Thread Carl Eugen Hoyos
2017-12-10 13:00 GMT+01:00 Gyan Doshi : > Ping for the patch Threaten to apply and wait a few days. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 03/27] avfilter/buffersrc: recognize color_range as additonal parameter and set it to input link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-09): > Signed-off-by: Paul B Mahol > --- > libavfilter/buffersrc.c | 13 + > libavfilter/buffersrc.h | 5 + > 2 files changed, 18 insertions(+) > > diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c > index

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-09): > No new patches require it, it is for case such stereo3d and setsar and bunch > of others that may need to explicitly set sample aspect ratio to each frame. "May need" is not always a good way of designing changes. It would be much better if you actually changed these

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-02): > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile| 1 + > libavfilter/af_scaletempo.c | 529 > > libavfilter/allfilters.c| 1 + > 3 files changed, 531 insertions(+) > create mode

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > > "May need" is not always a good way of designing changes. It would be > > much better if you actually changed these filters at the same time to > > use it. That way you can be more sure that you did not mess things up in > > a subtle way. > Is changing inlink

Re: [FFmpeg-devel] [PATCH 3/3] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-10 Thread Rodger Combs
> On Dec 10, 2017, at 05:07, Nicolas George wrote: > > Rodger Combs (2017-12-07): >> --- >> libavformat/avformat.h | 1 + >> libavformat/internal.h | 5 + >> libavformat/options_table.h | 1 + >> libavformat/utils.c | 12 >> 4 files changed,

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-02): >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/Makefile| 1 + >> libavfilter/af_scaletempo.c | 529 >> >> libavfilter/allfilters.c|

Re: [FFmpeg-devel] [PATCH] avfilter/video: pick sar from link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > See vf_aspect.c, it changes inlink parameters. > > This patch is required for example if one change sar of first input > and that value is not propagated to next links. I had not noticed that. The code in vf_aspect.c looks invalid to me, I think the change should be

Re: [FFmpeg-devel] [PATCH] configure: Allow users to disable all hwaccel libraries

2017-12-10 Thread Gyan Doshi
On 12/8/2017 6:18 PM, Gyan Doshi wrote: On 12/8/2017 4:56 PM, Tobias Rapp wrote: includes autodetected hwaccels, but that's just my personal opinion. I leave it to the maintainer of the file to decide what to push. Speaking of which, who is the maintainer of configure? Neither the file

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> I will then just apply this. > > No, you will not. You will discuss a solution that is good for the > project as a whole. > >> If Carl Eugen can ignore you, I can too. > > Two wrongs do not make a right. > > If

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > I spent enought time porting this filter and do not intend to waste any more > time in void discussion with your ego. Keep your ad-hominem attacks for yourself. It is not a matter about me, it is a matter about the usability of the project. The patch as is is

Re: [FFmpeg-devel] [PATCH 05/27] avfilter/vf_scale: make use of color_range from filter links

2017-12-10 Thread Paul B Mahol
On 12/10/17, Michael Niedermayer wrote: > On Sat, Dec 09, 2017 at 04:37:57PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/vf_scale.c | 8 >> 1 file changed, 8 insertions(+) > > This changes the output for: > >

Re: [FFmpeg-devel] [PATCH] hls demuxer: add option to defer parsing of variants

2017-12-10 Thread Carl Eugen Hoyos
2017-12-09 20:17 GMT+01:00 Anssi Hannula : >> Selecting the first available program, if none was selected >> seems the most natural way. Selecting all or none make >> less sense. > > Hmm.. I wonder if selecting the highest-bandwidth-one might > make more sense This is what

Re: [FFmpeg-devel] [PATCH 08/27] avcodec/svq3: replace YUVJ pixel format

2017-12-10 Thread Michael Niedermayer
On Sat, Dec 09, 2017 at 04:38:00PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/svq3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Changes: ./ffmpeg -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 2 out.mp4 change happens

Re: [FFmpeg-devel] [PATCH 09/27] avcodec/fraps: replace YUVJ pixel format

2017-12-10 Thread Paul B Mahol
On 12/10/17, Michael Niedermayer wrote: > On Sat, Dec 09, 2017 at 04:38:01PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/fraps.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > breaks > > ./ffmpeg -y -i

Re: [FFmpeg-devel] [PATCH 09/27] avcodec/fraps: replace YUVJ pixel format

2017-12-10 Thread Paul B Mahol
On 12/10/17, Michael Niedermayer wrote: > On Sun, Dec 10, 2017 at 11:25:41AM +0100, Paul B Mahol wrote: >> On 12/10/17, Michael Niedermayer wrote: >> > On Sat, Dec 09, 2017 at 04:38:01PM +0100, Paul B Mahol wrote: >> >> Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [PATCH 08/27] avcodec/svq3: replace YUVJ pixel format

2017-12-10 Thread Michael Niedermayer
On Sun, Dec 10, 2017 at 11:23:10AM +0100, Paul B Mahol wrote: > On 12/10/17, Michael Niedermayer wrote: > > On Sat, Dec 09, 2017 at 04:38:00PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/svq3.c | 4 ++-- > >> 1

Re: [FFmpeg-devel] [PATCH 04/27] avfilter/buffersink: export color_range from filtergraph output

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-09): > Signed-off-by: Paul B Mahol > --- > libavfilter/buffersink.c | 1 + > libavfilter/buffersink.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c > index 0f87b5439a..5f3c932d92 100644 >

[FFmpeg-devel] [PATCH 29/29] all: remove rest of YUVJ pixel formats usage

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- fftools/ffmpeg_filter.c | 4 +-- libavcodec/raw.c | 18 +++--- libavcodec/utils.c | 11 -- libavutil/pixdesc.c | 60

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

2017-12-10 Thread Carl Eugen Hoyos
2017-12-09 2:35 GMT+01:00 Ronald S. Bultje : > Fixes trac issue #6884 and Netflix/vmaf issue #124. > -s->vmaf_score = compute_vmaf(format, s->width, s->height, read_frame, s, > - s->model_path, s->log_path, s->log_fmt, 0, > 0, > -

[FFmpeg-devel] [PATCH 03/29] avfilter/buffersrc: recognize color_range as additonal parameter and set it to input link

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/buffersrc.c | 18 ++ libavfilter/buffersrc.h | 5 + 2 files changed, 23 insertions(+) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index cd56f8ca45..51a1a9fb49 100644 ---

Re: [FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: resync if cluster parsing fails while seeking

2017-12-10 Thread Nicolas George
Rodger Combs (2017-12-08): > --- > libavformat/matroskadec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 496499b553..b51f67af00 100644 > --- a/libavformat/matroskadec.c > +++

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> And how do you know that? >> >> Only users you care about are mplayer users. > > Stop your nonsensical ad-hominem attacks. You are wasting your time and > mine. > > The patch as is is rejected, I have given

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > And how do you know that? > > Only users you care about are mplayer users. Stop your nonsensical ad-hominem attacks. You are wasting your time and mine. The patch as is is rejected, I have given reasons. Update it or discuss them. But I will no longer answer to

Re: [FFmpeg-devel] [PATCH v2] libavfilter/vf_blackdetect.c

2017-12-10 Thread Carl Eugen Hoyos
2017-12-09 19:28 GMT+01:00 Jonathan Baecker : > -static void check_black_end(AVFilterContext *ctx) > +static void check_black(AVFilterContext *ctx) Why do you rename this function? Please remove the superfluous brackets in the "if()" you change. Carl Eugen

Re: [FFmpeg-devel] [PATCH v2] libavfilter/vf_blackdetect.c

2017-12-10 Thread Jonathan Baecker
Am 10.12.2017 um 13:48 schrieb Carl Eugen Hoyos: 2017-12-09 19:28 GMT+01:00 Jonathan Baecker : -static void check_black_end(AVFilterContext *ctx) +static void check_black(AVFilterContext *ctx) Why do you rename this function? I rename them because before the function only

[FFmpeg-devel] [PATCH 24/29] avcodec/qsv: remove YUVJ pixel format usage

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/qsv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index 250b4e61e3..6eee40a222 100644 --- a/libavcodec/qsv.c +++ b/libavcodec/qsv.c @@ -171,7 +171,6 @@ int ff_qsv_map_pixfmt(enum AVPixelFormat

[FFmpeg-devel] [PATCH 27/29] avformat/rtpenc_jpeg: remove usage of YUVJ formats

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/rtpenc_jpeg.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavformat/rtpenc_jpeg.c b/libavformat/rtpenc_jpeg.c index 38eb2e68eb..e0e7afebfc 100644 --- a/libavformat/rtpenc_jpeg.c +++

[FFmpeg-devel] [PATCH 28/29] avfilter: remove YUVJ pixel format usage

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avf_showspectrum.c | 2 +- libavfilter/vaf_spectrumsynth.c| 4 +--- libavfilter/vf_atadenoise.c| 3 --- libavfilter/vf_avgblur.c | 4 +---

[FFmpeg-devel] [PATCH 26/29] avfilter/vf_setrange: change outlink color_range too

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_setparams.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c index 8427f98ba8..98a4aa2ad3 100644 --- a/libavfilter/vf_setparams.c +++

[FFmpeg-devel] [PATCH 25/29] avfilter/vf_blackdetect: use color_range from inlink

2017-12-10 Thread Paul B Mahol
Remove YUVJ pixel format usage. Signed-off-by: Paul B Mahol --- libavfilter/vf_blackdetect.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libavfilter/vf_blackdetect.c b/libavfilter/vf_blackdetect.c index 06ef9988d1..ff4b9eebb9 100644 ---

[FFmpeg-devel] [PATCH 22/29] avcodec/vdpau: remove YUVJ pixel format usage

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/vdpau.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/vdpau.c b/libavcodec/vdpau.c index 1b2ec989cd..f7d1535fc7 100644 --- a/libavcodec/vdpau.c +++ b/libavcodec/vdpau.c @@ -82,19 +82,16 @@ int

[FFmpeg-devel] [PATCH 21/29] libavcodec/hevcdec: remove usage of YUVJ pixel format

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/hevcdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 433a7056ea..d1b54b1db5 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -363,7 +363,6 @@ static enum

[FFmpeg-devel] [PATCH 23/29] avcodec/nvenc: remove YUVJ pixel formats usage

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/nvenc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 4a91d99720..6ef51adaf0 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -911,8 +911,7 @@ static

Re: [FFmpeg-devel] [PATCH 03/29] avfilter/buffersrc: recognize color_range as additonal parameter and set it to input link

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > Signed-off-by: Paul B Mahol > --- > libavfilter/buffersrc.c | 18 ++ > libavfilter/buffersrc.h | 5 + > 2 files changed, 23 insertions(+) > > diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c > index

Re: [FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: resync if cluster parsing fails while seeking

2017-12-10 Thread Carl Eugen Hoyos
2017-12-09 3:24 GMT+01:00 Rodger Combs : > -if (matroska_parse_cluster(matroska) < 0) > -break; > +if ((ret = matroska_parse_cluster(matroska)) < 0) { > +if ((ret == AVERROR_EOF) || matroska_resync(matroska, pos) < >

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-10 Thread Michael Niedermayer
On Sun, Dec 10, 2017 at 05:17:44AM -0600, Rodger Combs wrote: > > > > On Dec 9, 2017, at 12:19, Michael Niedermayer > > wrote: > > > > On Fri, Dec 08, 2017 at 10:34:39PM -0600, Rodger Combs wrote: > >> > >> > >>> On Dec 8, 2017, at 11:06, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-10 Thread Nicolas George
Michael Niedermayer (2017-12-10): > IIUC we are still within the major bump thing (didnt check but others > have said it in relation to other changes) Well, there are no laws that say when we leave the "major bump thing". We dice how long it lasts. I can suggest this: versions with minor 0 have

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-10 Thread Michael Niedermayer
On Sun, Dec 10, 2017 at 04:30:25PM +0100, Nicolas George wrote: > Michael Niedermayer (2017-12-10): > > IIUC we are still within the major bump thing (didnt check but others > > have said it in relation to other changes) > > Well, there are no laws that say when we leave the "major bump thing". >

[FFmpeg-devel] [PATCH 07/29] avcodec/proresenc: prores supports limited color range only

2017-12-10 Thread Paul B Mahol
Add .color_range field to encoder's AVCodec struct. Signed-off-by: Paul B Mahol --- libavcodec/proresenc_anatoliy.c | 2 ++ libavcodec/proresenc_kostya.c | 1 + 2 files changed, 3 insertions(+) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c

[FFmpeg-devel] [PATCH 09/29] avcodec/mjpegdec: replace YUVJ pixel formats

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mjpegdec.c| 18 +- libavcodec/tdsc.c| 2 +- tests/fate/filter-video.mak | 2 +- tests/fate/vcodec.mak| 4 ++-- tests/ref/fate/api-mjpeg-codec-param | 4

[FFmpeg-devel] [PATCH 12/29] avcodec/mjpegenc: remove usage of YUVJ pixel formats

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mjpegenc.c| 6 -- libavcodec/mjpegenc_common.c | 2 +- libavcodec/mpegvideo_enc.c | 8 +--- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/mjpegenc.c b/libavcodec/mjpegenc.c index

[FFmpeg-devel] [PATCH 13/29] avcodec/svq3: replace YUVJ pixel format

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/svq3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index a937b2f951..4c6d838a15 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -1158,7 +1158,7 @@ static

[FFmpeg-devel] [PATCH 19/29] avcodec/roqvideoenc: do not use YUVJ pixel format

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/roqvideoenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/roqvideoenc.c b/libavcodec/roqvideoenc.c index ac05123dc6..0f49450054 100644 --- a/libavcodec/roqvideoenc.c +++ b/libavcodec/roqvideoenc.c

[FFmpeg-devel] [PATCH 14/29] avcodec/fraps: replace YUVJ pixel format

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/fraps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/fraps.c b/libavcodec/fraps.c index 7a7673f73f..b2025b5d3f 100644 --- a/libavcodec/fraps.c +++ b/libavcodec/fraps.c @@ -218,7 +218,7 @@ static int

[FFmpeg-devel] [PATCH 18/29] avcodec/hevc_ps: do not use YUVJ pixel format

2017-12-10 Thread Paul B Mahol
Color range is already set. Signed-off-by: Paul B Mahol --- libavcodec/hevc_ps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index a4f7ed60f7..19ec2d7ebf 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@ -578,8

[FFmpeg-devel] [PATCH 17/29] avcodec/h264_slice: do not use YUVJ pixel formats

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/h264_slice.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index aad5484588..a75ab08c29 100644 --- a/libavcodec/h264_slice.c +++

[FFmpeg-devel] [PATCH 16/29] avcodec/mdec: replace YUVJ pixel format

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mdec.c b/libavcodec/mdec.c index 330b761279..637158d231 100644 --- a/libavcodec/mdec.c +++ b/libavcodec/mdec.c @@ -227,7 +227,7 @@ static av_cold int

[FFmpeg-devel] [PATCH 15/29] avcodec/roqvideodec: replace YUVJ pixel format

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/roqvideodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c index 0ab7d399d6..c5b7bbe236 100644 --- a/libavcodec/roqvideodec.c +++ b/libavcodec/roqvideodec.c @@

[FFmpeg-devel] [PATCH 20/29] avcodec/libx264: do not use YUVJ pixel formats

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/libx264.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91f33..7a7f21c3d0 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -152,7

Re: [FFmpeg-devel] [PATCH 02/29] avfilter/avfilter: add color_range to AVFilterLink struct

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 2 ++ > libavfilter/avfilter.h | 2 ++ > libavfilter/video.c| 8 +++- > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.c

Re: [FFmpeg-devel] [PATCH] fix MSVC compilation errors

2017-12-10 Thread Michael Niedermayer
On Fri, Dec 08, 2017 at 07:42:50PM +0100, Michael Niedermayer wrote: > On Fri, Dec 08, 2017 at 08:46:52AM +0100, Mateusz wrote: > > After commit 3701d49 'error_resilience: remove avpriv_atomic usage' > > we have included windows.h in much more files and we should > > avoid conflicts with

Re: [FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

2017-12-10 Thread Nicolas George
Carl Eugen Hoyos (2017-12-10): > Sorry if I miss something: > This looks completely broken to me, how can the same function > of the same external library have two different amounts of > arguments (in C)? https://github.com/Netflix/vmaf/commit/96b99b9416135a0dfeb42c3b148852cce2b3f531 This commit

[FFmpeg-devel] [PATCH 02/29] avfilter/avfilter: add color_range to AVFilterLink struct

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 2 ++ libavfilter/avfilter.h | 2 ++ libavfilter/video.c| 8 +++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index b98b32bacb..4a579bb49d 100644

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Add support for parsing and exporting video_range

2017-12-10 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4video.h| 3 +++ libavcodec/mpeg4videodec.c | 32 2 files changed, 35 insertions(+) diff --git a/libavcodec/mpeg4video.h b/libavcodec/mpeg4video.h index 515b008ae4..0ba502d50b

[FFmpeg-devel] [PATCH 03/29] avfilter/buffersrc: recognize color_range as additonal parameter and set it to input link

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/buffersrc.c | 18 ++ libavfilter/buffersrc.h | 5 + 2 files changed, 23 insertions(+) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index cd56f8ca45..9e6d07c7df 100644 ---

[FFmpeg-devel] [PATCH 08/29] avcodec/mpeg4videoenc: mark as limited color range only

2017-12-10 Thread Paul B Mahol
lavf-mkv changes only because of metadata. Signed-off-by: Paul B Mahol --- libavcodec/mpeg4videoenc.c | 1 + libavcodec/mpegvideo_enc.c | 4 tests/ref/lavf/mkv | 8 tests/ref/seek/lavf-mkv| 44 ++-- 4 files

[FFmpeg-devel] [PATCH 01/29] avcodec: add color_range to AVCodec struct and use it

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/avcodec.h | 1 + libavcodec/utils.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 5db6a81320..e5de4797c8 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@

[FFmpeg-devel] [PATCH 04/29] avfilter/buffersink: export color_range from filtergraph output

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/buffersink.c | 1 + libavfilter/buffersink.h | 1 + 2 files changed, 2 insertions(+) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 0f87b5439a..897396cac4 100644 --- a/libavfilter/buffersink.c +++

[FFmpeg-devel] [PATCH 02/29] avfilter/avfilter: add color_range to AVFilterLink struct

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 2 ++ libavfilter/avfilter.h | 2 ++ libavfilter/video.c| 8 +++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index b98b32bacb..4a579bb49d 100644

[FFmpeg-devel] [PATCH 10/29] avcodec/ljpegenc: do not use YUVJ pixel formats

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/ljpegenc.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/ljpegenc.c b/libavcodec/ljpegenc.c index 924d2e2fff..2d7235dd96 100644 --- a/libavcodec/ljpegenc.c +++ b/libavcodec/ljpegenc.c @@ -289,10

[FFmpeg-devel] [PATCH 11/29] avcodec/mjpegdec: remove YUVJ pixel format usage

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mjpegdec.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 55676d8576..160bbfd34b 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@

[FFmpeg-devel] [PATCH 05/29] avfilter/vf_scale: make use of color_range from filter links

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_scale.c | 8 1 file changed, 8 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 9f45032e85..802f841cc3 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -303,9 +303,15 @@

[FFmpeg-devel] [PATCH 06/29] fftools/ffmpeg_filter: auto insert scale filter to convert between different color_ranges if necessary

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- fftools/ffmpeg_filter.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 877fd670e6..e69bfe295c 100644 --- a/fftools/ffmpeg_filter.c +++

[FFmpeg-devel] [PATCH v3] libavfilter/vf_blackdetect.c

2017-12-10 Thread Jonathan Baecker
Here the cleanup version from the patch. From b6b6e4ab885f9b35a6696492286e504a4b3d6d92 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Mon, 4 Dec 2017 16:05:48 +0100 Subject: [PATCH] unify blackdetect with af_silencedetect. Is more useful for monitoring streams. ---

Re: [FFmpeg-devel] [PATCH 08/29] avcodec/mpeg4videoenc: mark as limited color range only

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > > Looking at the format convertion it seems that an additional scaler > > is used to convert to gbrp which is then converted again > Here output looks more correct IMHO. What about the performances? Two expensive conversions instead of one (zero?) will cause a loss.

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Add support for parsing and exporting video_range

2017-12-10 Thread Mark Thompson
On 10/12/17 15:20, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4video.h| 3 +++ > libavcodec/mpeg4videodec.c | 32 > 2 files changed, 35 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH 08/27] avcodec/svq3: replace YUVJ pixel format

2017-12-10 Thread Paul B Mahol
On 12/10/17, Michael Niedermayer wrote: > On Sat, Dec 09, 2017 at 04:38:00PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/svq3.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Changes: > ./ffmpeg -i

Re: [FFmpeg-devel] [PATCH 27/27] all: remove rest of YUVJ pixel formats usage

2017-12-10 Thread Paul B Mahol
On 12/10/17, Michael Niedermayer wrote: > On Sat, Dec 09, 2017 at 04:38:19PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> fftools/ffmpeg_filter.c | 4 +-- >> libavcodec/raw.c | 18

Re: [FFmpeg-devel] [PATCH 09/27] avcodec/fraps: replace YUVJ pixel format

2017-12-10 Thread Michael Niedermayer
On Sun, Dec 10, 2017 at 11:25:41AM +0100, Paul B Mahol wrote: > On 12/10/17, Michael Niedermayer wrote: > > On Sat, Dec 09, 2017 at 04:38:01PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/fraps.c | 2 +- > >> 1

Re: [FFmpeg-devel] [PATCH 02/27] avfilter/avfilter: add color_range to AVFilterLink struct

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-09): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 2 ++ > libavfilter/avfilter.h | 2 ++ > libavfilter/video.c| 8 +++- > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.c

Re: [FFmpeg-devel] [PATCH 3/3] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-10 Thread Nicolas George
Rodger Combs (2017-12-10): > The goal is to use this in conjunction with the previous patches in > the set to deal with live broadcast streams coming off a tuner. The > first patch sets the CORRUPT flag when the TEI bit is set in a TS > packet (indicating that the tuner detected uncorrectable

Re: [FFmpeg-devel] [PATCH] avfilter: port scaletempo filter from mpv

2017-12-10 Thread Nicolas George
Paul B Mahol (2017-12-10): > Just leave for once. I have "left" with you more times than I can count. Not today. Committing like this would be bad for the users, and you can make it good with not much effort. If you do not care about the good of the users, then why are you contributing to the

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-10 Thread Mateusz
W dniu 09.12.2017 o 15:46, Martin Vignali pisze: >> >>> Do you test on X86_32 or x86_64 ? >> >> failure occurs on both >> >> >>> Nasm or Yasm ? >> >> NASM version 2.10.09 compiled on Dec 29 2013 >> >> >> >> I try to compile with the same nasm version (on os X, X86_64) > using

Re: [FFmpeg-devel] [PATCH 08/29] avcodec/mpeg4videoenc: mark as limited color range only

2017-12-10 Thread Paul B Mahol
On 12/10/17, Michael Niedermayer wrote: > On Sun, Dec 10, 2017 at 02:14:15PM +0100, Paul B Mahol wrote: >> lavf-mkv changes only because of metadata. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/mpeg4videoenc.c | 1 + >>

Re: [FFmpeg-devel] [PATCH 08/29] avcodec/mpeg4videoenc: mark as limited color range only

2017-12-10 Thread Paul B Mahol
On 12/10/17, Nicolas George wrote: > Paul B Mahol (2017-12-10): >> > Looking at the format convertion it seems that an additional scaler >> > is used to convert to gbrp which is then converted again >> Here output looks more correct IMHO. > > What about the performances? Two

Re: [FFmpeg-devel] checkasm/vf_hflip : add test for vf_hflip SIMD

2017-12-10 Thread Martin Vignali
> > For me there is no "src + (width - 1) * step" in tests/checkasm/vf_hflip.c > > You pass start of the src buffer but you should pass end of the buffer. > > > > Thanks ! New patch in attach. Martin 0001-avfilter-vf_hflip-move-context-func-init-in.patch Description: Binary data

[FFmpeg-devel] [PATCH 1/2] avfilter/video: pick sar from link

2017-12-10 Thread Paul B Mahol
It should not be needed for each filter that sets sample aspect ratio to set it explicitly also for each and every frame, instead that is automatically done in get_buffer call. Signed-off-by: Paul B Mahol --- libavfilter/video.c | 9 - 1 file changed, 8 insertions(+),

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_aspect: change outlink sample aspect ratio instead of inlink

2017-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_aspect.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_aspect.c b/libavfilter/vf_aspect.c index 4c93639554..c042698ef7 100644 --- a/libavfilter/vf_aspect.c +++

Re: [FFmpeg-devel] [PATCH] configure: Allow users to disable all hwaccel libraries

2017-12-10 Thread Mark Thompson
On 07/12/17 09:31, Gyan Doshi wrote: > On 12/7/2017 12:59 PM, Tobias Rapp wrote: >> >> Why not add the HWACCEL_AUTODETECT_LIBRARY_LIST to --disable-hwaccels? > > That is a better choice but there wasn't a bespoke case for > '--disable-hwaccels', so originally ignored that possibility. Added it

Re: [FFmpeg-devel] [PATCH] configure: Allow users to disable all hwaccel libraries

2017-12-10 Thread Gyan Doshi
On 12/10/2017 10:44 PM, Mark Thompson wrote: Can you explain what you actually want to achieve here? It sounds more like you want --disable-autodetect (hardware libraries are not the only ones which can give surprise dependencies). If the ffmpeg HW decoder/encoder wrappers are disabled,

  1   2   >